-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[security-in-core] Expose userProfile
APIs from Core
#178932
Comments
Pinging @elastic/kibana-core (Team:Core) |
Pinging @elastic/kibana-security (Team:Security) |
This is the only point we need to figure out. In my initial PR I assumed we would be registering all of security's API from a single registration hook kibana/packages/core/security/core-security-server/src/contracts.ts Lines 17 to 24 in b816af4
But this also assumed everything was exposed from the same service. If we want this If we want to keep the registration being done with a single hook (and I think we do), then it means a few things:
The alternative would be to have a distinct |
As discussed, I tentatively assigned myself to take this work on. We can change that if needed later. |
We discussed it with @TinaHeiligers today, and came to the agreement that adding a dedicated registration hook for the userProfile API was the best solution, long term. |
## Summary Fix #178932 - Introduce the new `userProfile` core service, both on the browser and server-side. - Have the security plugin register its API to Core for re-exposition --------- Co-authored-by: kibanamachine <[email protected]>
Part of #174578
This issue is about migrating the
userProfile
APIs to re-expose them from Core, similar to what was done toauthc
in #177976We want to expose them from their dedicated service (so
core.userProfile
and notcore.security.userProfile
)The public API doesn't need to change, we can re-expose them exactly the same
The internal API will need to expose all the APIs for Core to use
update
is not exposed on the server-side as a public APIThere is a package about UI components for user profile, but we don't need to do anything about it
(Optional) Given we have only few consumers of the userProfiles APIs, we could even adapt the existing consumers to use the new Core APIs and then simply remove them from the security plugin’s contract (if the effort is reasonable)
Tech pointers
Server-side:
kibana/x-pack/packages/security/plugin_types_server/src/plugin.ts
Lines 44 to 47 in f7fa846
Browser-side:
kibana/x-pack/packages/security/plugin_types_public/src/plugin.ts
Lines 33 to 36 in f7fa846
The text was updated successfully, but these errors were encountered: