-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra UI] Update Host Disk Partition Average Metrics to 'max' #179044
Comments
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
Hey @roshan-elastic,
Regarding
|
Hey @jennypavlova - thanks for this!
👍
Quick Q - how does this question play out if you look at the parent issue?
Good catch - yeah, let's remove it.
Yeahhhhh :( I'll add it to my list... |
@roshan-elastic Thank you for your reply! I saw that there will be changes in the charts we show in the metrics tab and the overview tab, I guess this space won't be an issue for now (as it will change anyway) so we can go with this change, I think and remove the Disk Usage chart everywhere. |
Closes [#179044](#179044) ## Summary This PR changes the disk usage formula to `max` and removes the disk usage charts. Charts removed: `Disk Usage` - Hosts view - Asset Details Page/Flyout Changes in KPIs / Table: | Before | After | | ------- | ----- | | <img width="1883" alt="image" src="https://github.com/elastic/kibana/assets/14139027/81735a00-857b-459b-bcd0-4e5c252a0265"> | <img width="1881" alt="image" src="https://github.com/elastic/kibana/assets/14139027/86d53a22-dc7b-40c4-bcbc-d4bf7b607a00"> | - With Hosts Limit: <img width="1627" alt="image" src="https://github.com/elastic/kibana/assets/14139027/9ea4416a-fee0-49c1-b4f4-8df1d934a940"> ## Testing: - Go to Hosts view and check - In the table Disk usage column formula, tooltip and title are changed to `max` - the Disk usage KPI (subtitle, tooltip & formula) is changed to `max` and verify that the Disk Usage chart is removed - Same steps (2 and 3) on Asset details flyout page: The Disk Usage by Mount Point Chart should be still there only the Disk Usage chart is removed https://github.com/elastic/kibana/assets/14139027/68107a8f-3d7f-4b68-a39a-bc2766f933b6
Hey @roshan-elastic, FYI this change will be available in 8.14 so it will be good to have the docs ready as well for the version release. |
Cheers @jennypavlova - question, will the metrics tab be available as well? |
@roshan-elastic If we close this issue (#175446) before FF it will be available. Does it matter for the docs changes related to this issue? I am not familiar with how the changes in the docs work - can it be that we have 2 separate changes or do they update the docs once per release? |
Hey @jennypavlova - I believe they update docs as part of the release cycle too but they typically do this considerably past FF. Thinking maybe we wait to know if we'll be doing the metrics tab in 8.14 and then I can file a single docs request? |
@jennypavlova - FYI created a docs issue: |
@roshan-elastic Thank you for opening the request! BTW the metrics tab PR is also merged and it will be part of the 8.14 release |
Background
Users want to understand if a disk on a host is running out. Currently, we show the 'average' disk partition space across all partitions (mount points) on a host - this is meaningless as is disguises any partitions which run out of space
Description
Update two visualisations to use 'max' instead of 'average' partition space to ensure any partitions which are high will be apparent in the UI.
Related Issues
Solution
1. Update Disk Usage KPI Tile to use 'max' in Hosts List
New formulae
max(system.filesystem.used.pct)
New name
Disk Usage (Max)...see below
Updated tooltip
Maximum usage of any partition across all hosts.
Formula Calculation:
max(system.filesystem.used.pct)
2. Update Disk Usage in table to 'max' in Hosts List
New formulae
max(system.filesystem.used.pct)
New name
Disk Usage (max.)
Updated tooltip
Maximum percentage of disk space used across all partitions per host.
Formula Calculation:
max(system.filesystem.used.pct)
See documentation(opens in a new tab or window) for more information.
3. Remove Disk Usage in visualisation in fly-out and detail view
This chart isn't that helpful - the existing disk usage by mount-point is more helpful so removing this to reduce confusion.
The text was updated successfully, but these errors were encountered: