Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra UI] Update Host Disk Partition Average Metrics to 'max' #179044

Closed
2 of 3 tasks
roshan-elastic opened this issue Mar 20, 2024 · 11 comments · Fixed by #180392
Closed
2 of 3 tasks

[Infra UI] Update Host Disk Partition Average Metrics to 'max' #179044

roshan-elastic opened this issue Mar 20, 2024 · 11 comments · Fixed by #180392
Assignees
Labels
enhancement New value added to drive a business result Feature:ObsHosts Hosts feature within Observability Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@roshan-elastic
Copy link

roshan-elastic commented Mar 20, 2024

Background

Users want to understand if a disk on a host is running out. Currently, we show the 'average' disk partition space across all partitions (mount points) on a host - this is meaningless as is disguises any partitions which run out of space

Description

Update two visualisations to use 'max' instead of 'average' partition space to ensure any partitions which are high will be apparent in the UI.

Note : See imminently related issue:

Related Issues

Solution

1. Update Disk Usage KPI Tile to use 'max' in Hosts List

image

New formulae
max(system.filesystem.used.pct)

New name
Disk Usage (Max)...see below

image

Updated tooltip

Maximum usage of any partition across all hosts.

Formula Calculation:
max(system.filesystem.used.pct)

2. Update Disk Usage in table to 'max' in Hosts List

image

New formulae
max(system.filesystem.used.pct)

New name
Disk Usage (max.)

Updated tooltip

Maximum percentage of disk space used across all partitions per host.

Formula Calculation:
max(system.filesystem.used.pct)

See documentation(opens in a new tab or window) for more information.

3. Remove Disk Usage in visualisation in fly-out and detail view

This chart isn't that helpful - the existing disk usage by mount-point is more helpful so removing this to reduce confusion.

@botelastic botelastic bot added the needs-team Issues missing a team label label Mar 20, 2024
@roshan-elastic
Copy link
Author

@smith - This should be a quick win - it's just lens config and will fix the following ER:

Where's best to put this? Would be great to get this done as a snack!

cc @herrBez

@jsanz jsanz added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Mar 21, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Mar 21, 2024
@smith smith added the enhancement New value added to drive a business result label Mar 27, 2024
@roshan-elastic roshan-elastic changed the title [Infra UI] Update Host Disk Partition Average Metricsto 'max' [Infra UI] Update Host Disk Partition Average Metrics to 'max' Apr 2, 2024
@smith smith added the Feature:ObsHosts Hosts feature within Observability label Apr 2, 2024
@jennypavlova jennypavlova self-assigned this Apr 8, 2024
@jennypavlova
Copy link
Member

Hey @roshan-elastic,
I have a couple of questions:

  • The disk usage by mount point chart should remain unchanged right? (still using the average formula)

Regarding 3.:

  • What should we show instead of the chart in asset details full page view? (we will have a 'free' space when the chart is removed) or we will leave it like that?
image
  • It looks fine in the flyout view as we already have an odd chart count:
    image

  • Should we remove the chart from the hosts view (list view) as well as the asset details flyout/page view?

    • If yes, this is the chart(s) we need to remove right?
    image
    • So not the Disk space available on the hosts view (list view):
    image

image

@roshan-elastic
Copy link
Author

Hey @jennypavlova - thanks for this!

The disk usage by mount point chart should remain unchanged right? (still using the average formula)

👍

What should we show instead of the chart in asset details full page view? (we will have a 'free' space when the chart is removed) or we will leave it like that?

Quick Q - how does this question play out if you look at the parent issue?

Should we remove the chart from the hosts view (list view) as well as the asset details flyout/page view?

Good catch - yeah, let's remove it.

The Docs should be updated as well right?

Yeahhhhh :( I'll add it to my list...

@jennypavlova
Copy link
Member

Quick Q - how does this question play out if you look at the https://github.com/elastic/observability-dev/issues/3311?

@roshan-elastic Thank you for your reply! I saw that there will be changes in the charts we show in the metrics tab and the overview tab, I guess this space won't be an issue for now (as it will change anyway) so we can go with this change, I think and remove the Disk Usage chart everywhere.

jennypavlova added a commit that referenced this issue Apr 11, 2024
Closes [#179044](#179044)

## Summary
This PR changes the disk usage formula to `max` and removes the disk
usage charts.

Charts removed: `Disk Usage`
- Hosts view 
- Asset Details Page/Flyout

Changes in KPIs / Table: 

| Before |  After | 
| ------- | ----- |
| <img width="1883" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/81735a00-857b-459b-bcd0-4e5c252a0265">
| <img width="1881" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/86d53a22-dc7b-40c4-bcbc-d4bf7b607a00">
|

- With Hosts Limit: 

<img width="1627" alt="image"
src="https://github.com/elastic/kibana/assets/14139027/9ea4416a-fee0-49c1-b4f4-8df1d934a940">

## Testing:
- Go to Hosts view and check 
- In the table Disk usage column formula, tooltip and title are changed
to `max`
- the Disk usage KPI (subtitle, tooltip & formula) is changed to `max`
and verify that the Disk Usage chart is removed
- Same steps (2 and 3) on Asset details flyout page: The Disk Usage by
Mount Point Chart should be still there only the Disk Usage chart is
removed


https://github.com/elastic/kibana/assets/14139027/68107a8f-3d7f-4b68-a39a-bc2766f933b6
@jennypavlova
Copy link
Member

Hey @roshan-elastic, FYI this change will be available in 8.14 so it will be good to have the docs ready as well for the version release.

@roshan-elastic
Copy link
Author

Cheers @jennypavlova - question, will the metrics tab be available as well?

@jennypavlova
Copy link
Member

will the metrics tab be available as well?

@roshan-elastic If we close this issue (#175446) before FF it will be available. Does it matter for the docs changes related to this issue? I am not familiar with how the changes in the docs work - can it be that we have 2 separate changes or do they update the docs once per release?

@roshan-elastic
Copy link
Author

Hey @jennypavlova - I believe they update docs as part of the release cycle too but they typically do this considerably past FF.

Thinking maybe we wait to know if we'll be doing the metrics tab in 8.14 and then I can file a single docs request?

@roshan-elastic
Copy link
Author

@jennypavlova - FYI created a docs issue:

@jennypavlova
Copy link
Member

@roshan-elastic Thank you for opening the request! BTW the metrics tab PR is also merged and it will be part of the 8.14 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:ObsHosts Hosts feature within Observability Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants