Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][AVC banner] Hide AVC banner on January 1, 2025 #187929

Merged
merged 19 commits into from
Aug 1, 2024
Merged

[Security Solution][AVC banner] Hide AVC banner on January 1, 2025 #187929

merged 19 commits into from
Aug 1, 2024
+35 −8

Conversation

parkiino
Copy link
Contributor

@parkiino parkiino commented Jul 10, 2024 •
edited
Loading

Summary

  • Hides the avc banner when the local system time is 1/1/2025
  • Updates the blog link
  • Unit tests

@parkiino parkiino changed the title compact svg and date wip [Security Solution][AVC banner] Hide AVC banner on January 1, 2025 Jul 12, 2024
@parkiino parkiino marked this pull request as ready for review July 12, 2024 20:21
@parkiino parkiino requested review from a team as code owners July 12, 2024 20:21
@parkiino parkiino added release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-defend-workflows (Team:Defend Workflows)

@parkiino parkiino removed the auto-backport Deprecated - use backport:version if exact versions are needed label Jul 12, 2024
@parkiino parkiino mentioned this pull request Jul 17, 2024
Merged
3 tasks
@parkiino parkiino requested a review from a team as a code owner July 19, 2024 18:14
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Jul 19, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

paul-tavares
paul-tavares approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@paul-tavares paul-tavares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving , but I did leave a comment that you should consider implementing prior to merge.

also - have you created an issue to follow up on this some time after the new year and remove/clean up the code?

packages/kbn-avc-banner/src/index.tsx Outdated
Comment on lines 19 to 21
const year2025 = new Date('January 01, 2025 00:00:00');
const today = new Date(Date.now());
return today < year2025;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you memoize this with useMemo()

Also - please add a return type (boolean) to the hook

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function isn't inside another component, so useMemo() wouldn't work here. I thought the date calculation would be simple enough where memoizing doesn't really make that much of a difference. Is this actually not the case?

@parkiino
Copy link
Contributor Author

parkiino commented Aug 1, 2024

@elasticmachine merge upstream

@parkiino parkiino enabled auto-merge (squash) August 1, 2024 03:49
@parkiino parkiino disabled auto-merge August 1, 2024 03:49
@parkiino parkiino enabled auto-merge (squash) August 1, 2024 03:49
@parkiino parkiino added v8.16.0 backport:skip This commit does not require backporting labels Aug 1, 2024
@parkiino
Copy link
Contributor Author

parkiino commented Aug 1, 2024

@elasticmachine merge upstream

joepeeples
joepeeples approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@joepeeples joepeeples left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@parkiino
Copy link
Contributor Author

parkiino commented Aug 1, 2024

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/avc-banner 2 3 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.8MB 1.8MB +61.0B
lists 143.0KB 143.0KB -10.0B
securitySolution 20.5MB 20.5MB +61.0B
total +112.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 419.3KB 419.3KB -10.0B
Unknown metric groups

API count

id before after diff
@kbn/avc-banner 2 3 +1

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@parkiino parkiino merged commit f4b2b44 into elastic:main Aug 1, 2024
45 checks passed
@parkiino parkiino deleted the task/avc-2025 branch August 2, 2024 15:17
@parkiino parkiino removed backport:skip This commit does not require backporting v8.16.0 labels Dec 18, 2024
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 19, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

10 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 187929 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joepeeples joepeeples joepeeples approved these changes

@paul-tavares paul-tavares paul-tavares approved these changes

@nchaulet nchaulet nchaulet approved these changes

@tomsonpl tomsonpl Awaiting requested review from tomsonpl tomsonpl was automatically assigned from elastic/security-defend-workflows

Assignees
No one assigned
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@parkiino @elasticmachine @kibana-ci @kibanamachine @nchaulet @paul-tavares @joepeeples