Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log metrics for Services don't show unless "log.level" emitted #189389

Closed
5 tasks done
Tracked by #189501 ...
roshan-elastic opened this issue Jul 29, 2024 · 9 comments
Closed
5 tasks done
Tracked by #189501 ...

Log metrics for Services don't show unless "log.level" emitted #189389

roshan-elastic opened this issue Jul 29, 2024 · 9 comments
Assignees
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team

Comments

@roshan-elastic
Copy link

roshan-elastic commented Jul 29, 2024

This isn't technically a bug but I'd like to discuss if we can avoid a situation where when a service only emits logs without log.level then neither the log rate or log error % will show:

New Services Inventory
image

Logs-only Service View
image

We require log.level vs any logs in the logs-* index to filter out a lot of noise from APM likely to relating failed transactions (to avoid duplication) and general unhelpful noise.

Tasks

Preview Give feedback
  1. needs-team
    roshan-elastic
  2. needs-team
    roshan-elastic
  3. needs-team
    roshan-elastic
  4. Team:obs-ux-infra_services enhancement
    cauemarcondes

Related

🎨 Design

Service View message
Figma

Copy:

No log metrics have been detected against this service
Please ensure you are surfacing log.levelin your logs to display log metrics. Learn more

Service Inventory log rate and log error % columns
Image

Copy:

Want to see more?
In order to see log metrics against this service, please declare log.level in your logs.

Learn more

@botelastic botelastic bot added the needs-team Issues missing a team label label Jul 29, 2024
@roshan-elastic roshan-elastic added the Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team label Jul 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jul 29, 2024
@roshan-elastic
Copy link
Author

Why do we filter out anything without log.level?

Looking into the underlying data, I think I found why we restricted this to only count when log.level is set. The APM services emit a lot of noise to the logs-* indices which get filtered out if we filter for log.level : *:

Sample logs for an APM service
image

If I look at all services as a whole, you can see it's broken down into these categories:

image

Digging around these messages, they generally seem to be APM-specific relating to transactions that I don't think are helpful to the user (and perhaps captured in the 'failed transactions' metrics anyway?):

image image

What should we do?

Assuming I'm right about the above, I think we should keep this filter and follow up on @cauemarcondes' suggestion to add the (i) N/A state for the log rate/log error rate to explain to the user how to get these populated:

Sample message
image

(and update the docs too)

We can then explain to the user why log metrics aren't there so they can take action and we can also wait for feedback to see how this plays out with customers.

Be keen to hear thoughts when this gets picked up.

@roshan-elastic
Copy link
Author

Decision

cc @kkurstak @kpatticha @cauemarcondes

We spoke on the design call and agreed:

  1. We'll stick with the requirement for log.level for the log metrics
  2. We'll stick the N/A box in the log columns as per the above comment
  3. On the service view page, we'll add a permanent warning to explain why the log metrics aren't populated (with links to docs)
  4. On the service view page, we'll ensure the 'Add APM' CTA is dismissible

Actions

@cauemarcondes
Copy link
Contributor

I don't think we need to mention the service.name on the N/A copy. If the user is seeing that service means the service.name was already provided.

@roshan-elastic
Copy link
Author

I don't think we need to mention the service.name on the N/A copy. If the user is seeing that service means the service.name was already provided.

I hear you. Let me think about the copy and I'll post it once the designs are shared.

@kkurstak
Copy link

kkurstak commented Jul 31, 2024

FYI -
Created this issue for the design work: https://github.com/elastic/observability-design/issues/302
Design is ready, final copy to be provided by @roshan-elastic

@roshan-elastic
Copy link
Author

FYI copy in issue description for when engineering pick up

@roshan-elastic
Copy link
Author

Removing issues which don't block this work

@kpatticha
Copy link
Contributor

closing this one since the PR has been merged into main

#189644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team
Projects
None yet
Development

No branches or pull requests

5 participants