Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] [Serverless] User without privileges can see the Chat option on the Quality Dashboard #189888

Open
MadameSheema opened this issue Aug 5, 2024 · 9 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team triage_needed

Comments

@MadameSheema
Copy link
Member

Describe the bug:

  • User without privileges can see the Chat option on the Quality Dashboard

Preconditions:

  • To have a user with AI assistant set to none.
  • To have a complete project
  • To have indices with incompatibles fields

Steps to reproduce:

  1. Navigate to Data quality dashboard
  2. Click on Check all
  3. On the index with incompatible fields, expand the dropdwon

Current behavior:

  • The chat option is displayed
Screenshot 2024-08-05 at 15 52 08

Expected behavior:

  • The chat option should not be displayed

Additional information:

  • The behavior should be fixed on ESS as well if present.
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Project:Serverless Work as part of the Serverless project for its initial release labels Aug 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@angorayc angorayc assigned kapral18 and unassigned asnehalb Nov 19, 2024
@kapral18
Copy link
Contributor

hey @MadameSheema the Chat has (correct me if I am wrong @andrew-goldstein) an upsell builtin for when no privilege or when on lower tier.

I additionally double checked with @dhru42 and the understanding is it's ok for us in DQD to show the button and allow it to handle the restrictions.

Additionally from what I noticed alerts page also exercises the same behavior, but correct me if I am wrong.

@MadameSheema
Copy link
Member Author

Hey @kapral18 this was brought in one of the serverless testing parties that have been executed as well as per Kibana team, this is more about the UX rather than the functionality.

There are places where we don't allow the user to perform an action if they don't have the privileges, it would be great if we have a unified experience in the application, no idea who needs to take that decision :)

@kapral18
Copy link
Contributor

hey @einatjacoby can you share your perspective on how to proceed with this UI from consistency perspective?

@kapral18
Copy link
Contributor

@asnehalb can you please help get this unstuck? :) Thanks

@einatjacoby
Copy link

einatjacoby commented Jan 2, 2025

@kapral18 From what I recall, this was the decision on the designer side:
The button stays there, enabled,
but the assistant flyout displays a message about requiring an enterprise license
Image

@kapral18
Copy link
Contributor

kapral18 commented Jan 2, 2025

Hey @MadameSheema I've discussed this with designers and the consensus is this change is not needed. Is this enough to close the ticket? If not let us know who else should we discuss this with? Thanks. cc: @asnehalb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Project:Serverless Work as part of the Serverless project for its initial release Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team triage_needed
Projects
None yet
Development

No branches or pull requests

5 participants