Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution][Serverless] Anomalies for explore pages are displayed on the global search when the user does not have ML privileges #189893

Closed
MadameSheema opened this issue Aug 5, 2024 · 4 comments
Closed

[Security Solution][Serverless] Anomalies for explore pages are displayed on the global search when the user does not have ML privileges #189893

MadameSheema opened this issue Aug 5, 2024 · 4 comments
Assignees
@angorayc
Labels
bug Fixes for quality problems that affect the customer experience fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team

Comments

@MadameSheema
Copy link
Member

Describe the bug:

  • Anomalies for explore pages are displayed on the global search when the user does not have ML privileges

Preconditions:

  • To have a project on complete mode
  • To have a user with ML privilege set to none

Steps to reproduce:

  1. On the global search enter anomalies

Current behavior:

  • The explore anomalies pages are displayed
Screenshot 2024-08-05 at 16 45 00

Expected behavior:

  • The explore anomalies pages should not be displayed

Additional information:

  • This behaviour should be fixed on ESS as well if present.
@MadameSheema MadameSheema added bug Fixes for quality problems that affect the customer experience triage_needed Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore labels Aug 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@angorayc angorayc mentioned this issue Nov 25, 2024
Merged
@angorayc angorayc assigned angorayc and unassigned asnehalb Nov 26, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 26, 2024
@angorayc
[SecuritySolution] Add ml.canGetMlInfo capabilities (elastic#201652)
6814944 
## Summary

Fixes:
elastic#189893
elastic#189948

Steps to verify:

1. Open
`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,
comment feature_ml.read from t1_analyst
2. Open kibana serverless locally as t1_analyst, see links are not
displayed
3. Open kibana serverless locally as t2_analyst, see the links are
displayed

(cherry picked from commit eca6951)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Nov 26, 2024
@angorayc
[SecuritySolution] Add ml.canGetMlInfo capabilities (elastic#201652)
79bc02a 
## Summary

Fixes:
elastic#189893
elastic#189948

Steps to verify:

1. Open
`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,
comment feature_ml.read from t1_analyst
2. Open kibana serverless locally as t1_analyst, see links are not
displayed
3. Open kibana serverless locally as t2_analyst, see the links are
displayed

(cherry picked from commit eca6951)
kibanamachine added a commit that referenced this issue Nov 26, 2024
@kibanamachine @angorayc
[8.x] [SecuritySolution] Add ml.canGetMlInfo capabilities (#201652) (#…
7372276 
…201862)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[SecuritySolution] Add ml.canGetMlInfo capabilities
(#201652)](#201652)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T19:43:08Z","message":"[SecuritySolution]
Add ml.canGetMlInfo capabilities (#201652)\n\n##
Summary\r\n\r\nFixes:\r\nhttps://github.com//issues/189893\r\nhttps://github.com//issues/189948\r\n\r\nSteps
to verify:\r\n\r\n1.
Open\r\n`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,\r\ncomment
feature_ml.read from t1_analyst\r\n2. Open kibana serverless locally as
t1_analyst, see links are not\r\ndisplayed\r\n3. Open kibana serverless
locally as t2_analyst, see the links
are\r\ndisplayed","sha":"eca69516374cf2927e958e6b70502b038284756a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","v9.0.0","v8.17.0"],"title":"[SecuritySolution]
Add ml.canGetMlInfo
capabilities","number":201652,"url":"https://github.com/elastic/kibana/pull/201652","mergeCommit":{"message":"[SecuritySolution]
Add ml.canGetMlInfo capabilities (#201652)\n\n##
Summary\r\n\r\nFixes:\r\nhttps://github.com//issues/189893\r\nhttps://github.com//issues/189948\r\n\r\nSteps
to verify:\r\n\r\n1.
Open\r\n`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,\r\ncomment
feature_ml.read from t1_analyst\r\n2. Open kibana serverless locally as
t1_analyst, see links are not\r\ndisplayed\r\n3. Open kibana serverless
locally as t2_analyst, see the links
are\r\ndisplayed","sha":"eca69516374cf2927e958e6b70502b038284756a"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201652","number":201652,"mergeCommit":{"message":"[SecuritySolution]
Add ml.canGetMlInfo capabilities (#201652)\n\n##
Summary\r\n\r\nFixes:\r\nhttps://github.com//issues/189893\r\nhttps://github.com//issues/189948\r\n\r\nSteps
to verify:\r\n\r\n1.
Open\r\n`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,\r\ncomment
feature_ml.read from t1_analyst\r\n2. Open kibana serverless locally as
t1_analyst, see links are not\r\ndisplayed\r\n3. Open kibana serverless
locally as t2_analyst, see the links
are\r\ndisplayed","sha":"eca69516374cf2927e958e6b70502b038284756a"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
kibanamachine added a commit that referenced this issue Nov 26, 2024
@kibanamachine @angorayc
[8.17] [SecuritySolution] Add ml.canGetMlInfo capabilities (#201652) (#…
2478274 
…201861)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[SecuritySolution] Add ml.canGetMlInfo capabilities
(#201652)](#201652)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Angela
Chuang","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-26T19:43:08Z","message":"[SecuritySolution]
Add ml.canGetMlInfo capabilities (#201652)\n\n##
Summary\r\n\r\nFixes:\r\nhttps://github.com//issues/189893\r\nhttps://github.com//issues/189948\r\n\r\nSteps
to verify:\r\n\r\n1.
Open\r\n`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,\r\ncomment
feature_ml.read from t1_analyst\r\n2. Open kibana serverless locally as
t1_analyst, see links are not\r\ndisplayed\r\n3. Open kibana serverless
locally as t2_analyst, see the links
are\r\ndisplayed","sha":"eca69516374cf2927e958e6b70502b038284756a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","backport","v9.0.0","v8.17.0"],"title":"[SecuritySolution]
Add ml.canGetMlInfo
capabilities","number":201652,"url":"https://github.com/elastic/kibana/pull/201652","mergeCommit":{"message":"[SecuritySolution]
Add ml.canGetMlInfo capabilities (#201652)\n\n##
Summary\r\n\r\nFixes:\r\nhttps://github.com//issues/189893\r\nhttps://github.com//issues/189948\r\n\r\nSteps
to verify:\r\n\r\n1.
Open\r\n`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,\r\ncomment
feature_ml.read from t1_analyst\r\n2. Open kibana serverless locally as
t1_analyst, see links are not\r\ndisplayed\r\n3. Open kibana serverless
locally as t2_analyst, see the links
are\r\ndisplayed","sha":"eca69516374cf2927e958e6b70502b038284756a"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/201652","number":201652,"mergeCommit":{"message":"[SecuritySolution]
Add ml.canGetMlInfo capabilities (#201652)\n\n##
Summary\r\n\r\nFixes:\r\nhttps://github.com//issues/189893\r\nhttps://github.com//issues/189948\r\n\r\nSteps
to verify:\r\n\r\n1.
Open\r\n`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,\r\ncomment
feature_ml.read from t1_analyst\r\n2. Open kibana serverless locally as
t1_analyst, see links are not\r\ndisplayed\r\n3. Open kibana serverless
locally as t2_analyst, see the links
are\r\ndisplayed","sha":"eca69516374cf2927e958e6b70502b038284756a"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Angela Chuang <[email protected]>
paulinashakirova pushed a commit to paulinashakirova/kibana that referenced this issue Nov 26, 2024
@angorayc @paulinashakirova
[SecuritySolution] Add ml.canGetMlInfo capabilities (elastic#201652)
8829f88 
## Summary

Fixes:
elastic#189893
elastic#189948

Steps to verify:

1. Open
`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,
comment feature_ml.read from t1_analyst
2. Open kibana serverless locally as t1_analyst, see links are not
displayed
3. Open kibana serverless locally as t2_analyst, see the links are
displayed
@angorayc angorayc reopened this Nov 29, 2024
@angorayc angorayc added the fixed label Nov 29, 2024
@MadameSheema
Copy link
Member Author

Tested the fix using an MKI environment with the latest dev-devenv version at the moment a3496c9 and now works as expected.

Tested the fix also in 8.17.0BC2 and works as expected as well.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@angorayc @CAWilson94
[SecuritySolution] Add ml.canGetMlInfo capabilities (elastic#201652)
cbb1ac5 
## Summary

Fixes:
elastic#189893
elastic#189948

Steps to verify:

1. Open
`packages/kbn-es/src/serverless_resources/project_roles/security/roles.yml`,
comment feature_ml.read from t1_analyst
2. Open kibana serverless locally as t1_analyst, see links are not
displayed
3. Open kibana serverless locally as t2_analyst, see the links are
displayed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angorayc angorayc

Labels
bug Fixes for quality problems that affect the customer experience fixed Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting:Explore Team:Threat Hunting Security Solution Threat Hunting Team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@angorayc @elasticmachine @MadameSheema @asnehalb