Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] install Entity definitions included in packages #193882

Open
klacabane opened this issue Sep 24, 2024 · 3 comments
Open

[Fleet] install Entity definitions included in packages #193882

klacabane opened this issue Sep 24, 2024 · 3 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@klacabane
Copy link
Contributor

Summary

We'd like to include Entity definitions in packages. When included in a package, entity definitions should be loaded by the fleet plugin on package installation and further logic should be applied to install them.

In their current state (Entity definitions are tech preview), installing a definition means installing ingest pipelines, index templates and transforms. The logic to do that is hosted in the entity_manager kibana plugin and exposed by a client that can be consumed by fleet.

This issue tracks feasibility and discussion around the implementation

@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 24, 2024
@jughosta jughosta added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 24, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Sep 24, 2024
@klacabane
Copy link
Contributor Author

klacabane commented Sep 24, 2024

I have a draft fleet implementation #193416 relying on elastic/package-spec#804.

While the package-spec defines definitions under <package>/kibana/entity_definitions, they're not stored as saved objects like sibling assets but instead as a json blob. As such I've not included definitions as a KibanaAssets type but as a separate step in the installation process. Happy to reconsider this if it does not make sense.

The current implementation #193416 is fairly straightforward, it will install/update definitions when appropriate and also delete them. I'd love to get an initial feedback on this to understand if this would be the right direction, what is missing and what else should be considered.

@klacabane
Copy link
Contributor Author

I've closed #193416 as we'll look into another approach to include the definitions for now, I'll link a new PR soon

@kpollich kpollich changed the title [fleet] install Entity definitions included in packages [Fleet] install Entity definitions included in packages Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

3 participants