Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Presentation Util] Remove the PluginServices registry from PresentationUtil #194199

Closed
Tracked by #154677
Heenawter opened this issue Sep 26, 2024 · 1 comment · Fixed by #195502
Closed
Tracked by #154677

[Presentation Util] Remove the PluginServices registry from PresentationUtil #194199

Heenawter opened this issue Sep 26, 2024 · 1 comment · Fixed by #195502
Assignees
@Heenawter
Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Sep 26, 2024 •
edited
Loading

Once all uses of the PluginServices registry are removed (see #154677), we should remove the registry entirely from the PresentationUtil plugin
@Heenawter Heenawter mentioned this issue Sep 26, 2024
Closed
@Heenawter Heenawter changed the title Remove the PluginServices registry from PresentationUtil [Presentation Util] Remove the PluginServices registry from PresentationUtil Sep 26, 2024
@Heenawter Heenawter self-assigned this Sep 26, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 26, 2024
@Heenawter Heenawter added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed needs-team Issues missing a team label labels Sep 26, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter mentioned this issue Oct 8, 2024
Merged
2 tasks
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 8, 2024
@Heenawter
[Presentation Util] Remove the plugin services toolkit (elastic#195502)
8cf8424 
Closes elastic#194199

## Summary

Now that no plugins use anything from the `PresentationUtil` services
toolkit, it is safe to remove all code and documentation related to this
from the `PresentationUtil` plugin.

### Checklist

- [x]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 1053493)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Presentation Util] Remove the plugin services toolkit Heenawter/kibana
2 participants
@Heenawter @elasticmachine