Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Rules] Move the params of synthetics and uptime rule types to the @kbn/response-ops-rule-params package #195187

Closed
7 tasks done
cnasikas opened this issue Oct 7, 2024 · 1 comment
Closed
7 tasks done

[ResponseOps][Rules] Move the params of synthetics and uptime rule types to the @kbn/response-ops-rule-params package #195187

cnasikas opened this issue Oct 7, 2024 · 1 comment
Assignees
@adcoelho
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 7, 2024 •
edited by adcoelho
Loading

Towards #187356 we should move the parameters of the synthetics and uptime rule types to the @kbn/response-ops-rule-params package.

Blocked by: #195183

DoD
Preview Give feedback
@cnasikas cnasikas added Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas changed the title [Rules] Move the params of synthetics and uptime rule types to the @kbn/response-ops-rule-params package [ResponseOps][Rules] Move the params of synthetics and uptime rule types to the @kbn/response-ops-rule-params package Oct 7, 2024
@adcoelho adcoelho assigned adcoelho and unassigned adcoelho Dec 16, 2024
This was referenced Dec 27, 2024
Merged
Open
Merged
adcoelho added a commit that referenced this issue Jan 3, 2025
@adcoelho @kibanamachine
[ResponseOps][Rules] Move synthetic rule types' params to @kbn/respon…
98cc4b1 
…se-ops-rule-params (#204582)

Connected with #195187

## Summary

- Moved params of synthetic status monitor rule type to
`/response-ops/rule_params/synthetics_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/synthetics_tls/`

I created a follow-up issue to handle the places where io-ts is used for
params validation in `observability/plugins/synthetics`. #205207

---------

Co-authored-by: kibanamachine <[email protected]>
adcoelho added a commit that referenced this issue Jan 3, 2025
@adcoelho @kibanamachine
[ResponseOps][Rules]Move uptime rule params to package (#205238)
c8d46ee 
Connected with #195187

## Summary

- Moved params of duration anomaly rule type to
`/response-ops/rule_params/uptime_duration_anomaly/`
- Moved params of monitor status rule type to
`/response-ops/rule_params/uptime_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/uptime_tls/`
- **Did not move anything related to the legacy TLS rule type.**

I ran into a similar issue to #205207 for the monitor status rule type.
It doesn't block this PR but some follow up work might be needed for
`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.
We will probably decide after the new year.

---------

Co-authored-by: kibanamachine <[email protected]>
@adcoelho adcoelho mentioned this issue Jan 3, 2025
Merged
adcoelho added a commit to adcoelho/kibana that referenced this issue Jan 7, 2025
@adcoelho
[ResponseOps][Rules] Move synthetic rule types' params to @kbn/respon…
2c2b5e4 
…se-ops-rule-params (elastic#204582)

Connected with elastic#195187

- Moved params of synthetic status monitor rule type to
`/response-ops/rule_params/synthetics_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/synthetics_tls/`

I created a follow-up issue to handle the places where io-ts is used for
params validation in `observability/plugins/synthetics`. elastic#205207

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 98cc4b1)
adcoelho added a commit to adcoelho/kibana that referenced this issue Jan 7, 2025
@adcoelho
[ResponseOps][Rules]Move uptime rule params to package (elastic#205238)
ca09a65 
Connected with elastic#195187

- Moved params of duration anomaly rule type to
`/response-ops/rule_params/uptime_duration_anomaly/`
- Moved params of monitor status rule type to
`/response-ops/rule_params/uptime_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/uptime_tls/`
- **Did not move anything related to the legacy TLS rule type.**

I ran into a similar issue to elastic#205207 for the monitor status rule type.
It doesn't block this PR but some follow up work might be needed for
`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.
We will probably decide after the new year.

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit c8d46ee)
adcoelho added a commit that referenced this issue Jan 8, 2025
@adcoelho @kibanamachine
[8.x] [ResponseOps][Rules] Move synthetic rule types' params to @kbn/…
45c4faa 
…response-ops-rule-params (#204582) (#205724)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Move synthetic rule types' params to
@kbn/response-ops-rule-params
(#204582)](#204582)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T12:20:03Z","message":"[ResponseOps][Rules]
Move synthetic rule types' params to @kbn/response-ops-rule-params
(#204582)\n\nConnected with #195187\r\n\r\n## Summary\r\n\r\n- Moved
params of synthetic status monitor rule type
to\r\n`/response-ops/rule_params/synthetics_monitor_status/`\r\n- Moved
params of TLS rule type
to\r\n`/response-ops/rule_params/synthetics_tls/`\r\n\r\nI created a
follow-up issue to handle the places where io-ts is used for\r\nparams
validation in `observability/plugins/synthetics`.
#205207\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"98cc4b153fb884baa26cc5965fd299a8413e4f2d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport
missing","v9.0.0","backport:prev-minor","Team:obs-ux-management"],"number":204582,"url":"https://github.com/elastic/kibana/pull/204582","mergeCommit":{"message":"[ResponseOps][Rules]
Move synthetic rule types' params to @kbn/response-ops-rule-params
(#204582)\n\nConnected with #195187\r\n\r\n## Summary\r\n\r\n- Moved
params of synthetic status monitor rule type
to\r\n`/response-ops/rule_params/synthetics_monitor_status/`\r\n- Moved
params of TLS rule type
to\r\n`/response-ops/rule_params/synthetics_tls/`\r\n\r\nI created a
follow-up issue to handle the places where io-ts is used for\r\nparams
validation in `observability/plugins/synthetics`.
#205207\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"98cc4b153fb884baa26cc5965fd299a8413e4f2d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204582","number":204582,"mergeCommit":{"message":"[ResponseOps][Rules]
Move synthetic rule types' params to @kbn/response-ops-rule-params
(#204582)\n\nConnected with #195187\r\n\r\n## Summary\r\n\r\n- Moved
params of synthetic status monitor rule type
to\r\n`/response-ops/rule_params/synthetics_monitor_status/`\r\n- Moved
params of TLS rule type
to\r\n`/response-ops/rule_params/synthetics_tls/`\r\n\r\nI created a
follow-up issue to handle the places where io-ts is used for\r\nparams
validation in `observability/plugins/synthetics`.
#205207\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"98cc4b153fb884baa26cc5965fd299a8413e4f2d"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
adcoelho added a commit that referenced this issue Jan 8, 2025
@adcoelho @kibanamachine
[8.x] [ResponseOps][Rules]Move uptime rule params to package (#205238) (
31e59f0 
#205725)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules]Move uptime rule params to package
(#205238)](#205238)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T12:20:20Z","message":"[ResponseOps][Rules]Move
uptime rule params to package (#205238)\n\nConnected with
#195187\r\n\r\n## Summary\r\n\r\n- Moved params of duration anomaly rule
type to\r\n`/response-ops/rule_params/uptime_duration_anomaly/`\r\n-
Moved params of monitor status rule type
to\r\n`/response-ops/rule_params/uptime_monitor_status/`\r\n- Moved
params of TLS rule type
to\r\n`/response-ops/rule_params/uptime_tls/`\r\n- **Did not move
anything related to the legacy TLS rule type.**\r\n\r\nI ran into a
similar issue to #205207 for the monitor status rule type.\r\nIt doesn't
block this PR but some follow up work might be needed
for\r\n`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.\r\nWe
will probably decide after the new
year.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c8d46ee94982cf38163786f0890bafd43ec07247","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport
missing","v9.0.0","backport:prev-minor","Team:obs-ux-management"],"number":205238,"url":"https://github.com/elastic/kibana/pull/205238","mergeCommit":{"message":"[ResponseOps][Rules]Move
uptime rule params to package (#205238)\n\nConnected with
#195187\r\n\r\n## Summary\r\n\r\n- Moved params of duration anomaly rule
type to\r\n`/response-ops/rule_params/uptime_duration_anomaly/`\r\n-
Moved params of monitor status rule type
to\r\n`/response-ops/rule_params/uptime_monitor_status/`\r\n- Moved
params of TLS rule type
to\r\n`/response-ops/rule_params/uptime_tls/`\r\n- **Did not move
anything related to the legacy TLS rule type.**\r\n\r\nI ran into a
similar issue to #205207 for the monitor status rule type.\r\nIt doesn't
block this PR but some follow up work might be needed
for\r\n`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.\r\nWe
will probably decide after the new
year.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c8d46ee94982cf38163786f0890bafd43ec07247"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205238","number":205238,"mergeCommit":{"message":"[ResponseOps][Rules]Move
uptime rule params to package (#205238)\n\nConnected with
#195187\r\n\r\n## Summary\r\n\r\n- Moved params of duration anomaly rule
type to\r\n`/response-ops/rule_params/uptime_duration_anomaly/`\r\n-
Moved params of monitor status rule type
to\r\n`/response-ops/rule_params/uptime_monitor_status/`\r\n- Moved
params of TLS rule type
to\r\n`/response-ops/rule_params/uptime_tls/`\r\n- **Did not move
anything related to the legacy TLS rule type.**\r\n\r\nI ran into a
similar issue to #205207 for the monitor status rule type.\r\nIt doesn't
block this PR but some follow up work might be needed
for\r\n`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.\r\nWe
will probably decide after the new
year.\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"c8d46ee94982cf38163786f0890bafd43ec07247"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
@adcoelho adcoelho mentioned this issue Jan 9, 2025
Open
@cnasikas cnasikas closed this as completed Jan 9, 2025
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@adcoelho @kibanamachine @CAWilson94
[ResponseOps][Rules] Move synthetic rule types' params to @kbn/respon…
1b0e829 
…se-ops-rule-params (elastic#204582)

Connected with elastic#195187

## Summary

- Moved params of synthetic status monitor rule type to
`/response-ops/rule_params/synthetics_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/synthetics_tls/`

I created a follow-up issue to handle the places where io-ts is used for
params validation in `observability/plugins/synthetics`. elastic#205207

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@adcoelho @kibanamachine @CAWilson94
[ResponseOps][Rules]Move uptime rule params to package (elastic#205238)
ae3514c 
Connected with elastic#195187

## Summary

- Moved params of duration anomaly rule type to
`/response-ops/rule_params/uptime_duration_anomaly/`
- Moved params of monitor status rule type to
`/response-ops/rule_params/uptime_monitor_status/`
- Moved params of TLS rule type to
`/response-ops/rule_params/uptime_tls/`
- **Did not move anything related to the legacy TLS rule type.**

I ran into a similar issue to elastic#205207 for the monitor status rule type.
It doesn't block this PR but some follow up work might be needed for
`x-pack/solutions/observability/plugins/uptime/public/legacy_uptime/lib/alert_types/lazy_wrapper/validate_monitor_status.ts`.
We will probably decide after the new year.

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adcoelho adcoelho

Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adcoelho @cnasikas @elasticmachine