Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ResponseOps][Rules] Move the params of ML and infrastructure rule types to the @kbn/response-ops-rule-params package #195189

Closed
5 tasks done
cnasikas opened this issue Oct 7, 2024 · 1 comment
Assignees
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@cnasikas
Copy link
Member

cnasikas commented Oct 7, 2024

Towards #187356 we should move the parameters of the ML and infrastructure rule types to the @kbn/response-ops-rule-params package.

Blocked by: #195183

DoD

Preview Give feedback
@cnasikas cnasikas added Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 7, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@cnasikas cnasikas changed the title [Rules] Move the params of ML and infrastructure rule types to the @kbn/response-ops-rule-params package [ResponseOps][Rules] Move the params of ML and infrastructure rule types to the @kbn/response-ops-rule-params package Oct 7, 2024
@js-jankisalvi js-jankisalvi self-assigned this Dec 24, 2024
@adcoelho adcoelho assigned adcoelho and unassigned js-jankisalvi Jan 2, 2025
adcoelho added a commit that referenced this issue Jan 8, 2025
Connected with #195189

## Summary

- Moved params of duration metric inventory threshold rule type to
`/response-ops/rule_params/metric_inventory_threshold/`
- Moved params of metric threshold rule type to
`/response-ops/rule_params/metric_threshold/`

**I did NOT move the corresponding type to the rule_params package due
to the recursive imports it would create.**

---------

Co-authored-by: kibanamachine <[email protected]>
crespocarlos pushed a commit to crespocarlos/kibana that referenced this issue Jan 8, 2025
…ic#205492)

Connected with elastic#195189

## Summary

- Moved params of duration metric inventory threshold rule type to
`/response-ops/rule_params/metric_inventory_threshold/`
- Moved params of metric threshold rule type to
`/response-ops/rule_params/metric_threshold/`

**I did NOT move the corresponding type to the rule_params package due
to the recursive imports it would create.**

---------

Co-authored-by: kibanamachine <[email protected]>
adcoelho added a commit to adcoelho/kibana that referenced this issue Jan 8, 2025
…ic#205492)

Connected with elastic#195189

- Moved params of duration metric inventory threshold rule type to
`/response-ops/rule_params/metric_inventory_threshold/`
- Moved params of metric threshold rule type to
`/response-ops/rule_params/metric_threshold/`

**I did NOT move the corresponding type to the rule_params package due
to the recursive imports it would create.**

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 4873fa1)
adcoelho added a commit that referenced this issue Jan 9, 2025
…205492) (#205912)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Move metric rule params schema to package
(#205492)](#205492)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-08T09:50:26Z","message":"[ResponseOps][Rules]
Move metric rule params schema to package (#205492)\n\nConnected with
#195189\r\n\r\n## Summary\r\n\r\n- Moved params of duration metric
inventory threshold rule type
to\r\n`/response-ops/rule_params/metric_inventory_threshold/`\r\n- Moved
params of metric threshold rule type
to\r\n`/response-ops/rule_params/metric_threshold/`\r\n\r\n**I did NOT
move the corresponding type to the rule_params package due\r\nto the
recursive imports it would
create.**\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4873fa18d70142c5c2e6633d51648c45f6f481cb","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor"],"number":205492,"url":"https://github.com/elastic/kibana/pull/205492","mergeCommit":{"message":"[ResponseOps][Rules]
Move metric rule params schema to package (#205492)\n\nConnected with
#195189\r\n\r\n## Summary\r\n\r\n- Moved params of duration metric
inventory threshold rule type
to\r\n`/response-ops/rule_params/metric_inventory_threshold/`\r\n- Moved
params of metric threshold rule type
to\r\n`/response-ops/rule_params/metric_threshold/`\r\n\r\n**I did NOT
move the corresponding type to the rule_params package due\r\nto the
recursive imports it would
create.**\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4873fa18d70142c5c2e6633d51648c45f6f481cb"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205492","number":205492,"mergeCommit":{"message":"[ResponseOps][Rules]
Move metric rule params schema to package (#205492)\n\nConnected with
#195189\r\n\r\n## Summary\r\n\r\n- Moved params of duration metric
inventory threshold rule type
to\r\n`/response-ops/rule_params/metric_inventory_threshold/`\r\n- Moved
params of metric threshold rule type
to\r\n`/response-ops/rule_params/metric_threshold/`\r\n\r\n**I did NOT
move the corresponding type to the rule_params package due\r\nto the
recursive imports it would
create.**\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"4873fa18d70142c5c2e6633d51648c45f6f481cb"}}]}]
BACKPORT-->
adcoelho added a commit that referenced this issue Jan 9, 2025
…arate package (#205497)

Connected with #195189

## Summary

- Moved params of anomaly detection rule type to
`/response-ops/rule_params/anomaly_detection/`
- Moved params of anomaly detection jobs health rule type to
`/response-ops/rule_params/anomaly_detection_jobs_health/`

---------

Co-authored-by: kibanamachine <[email protected]>
adcoelho added a commit to adcoelho/kibana that referenced this issue Jan 9, 2025
…arate package (elastic#205497)

Connected with elastic#195189

- Moved params of anomaly detection rule type to
`/response-ops/rule_params/anomaly_detection/`
- Moved params of anomaly detection jobs health rule type to
`/response-ops/rule_params/anomaly_detection_jobs_health/`

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 5235234)
@cnasikas cnasikas closed this as completed Jan 9, 2025
adcoelho added a commit that referenced this issue Jan 9, 2025
… a separate package (#205497) (#206057)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Rules] Moved params of anomaly detection rules to a
separate package
(#205497)](#205497)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Antonio","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-09T11:58:40Z","message":"[ResponseOps][Rules]
Moved params of anomaly detection rules to a separate package
(#205497)\n\nConnected with #195189\r\n\r\n## Summary\r\n\r\n- Moved
params of anomaly detection rule type
to\r\n`/response-ops/rule_params/anomaly_detection/`\r\n- Moved params
of anomaly detection jobs health rule type
to\r\n`/response-ops/rule_params/anomaly_detection_jobs_health/`\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"5235234640277d6f3a2f864f57aebb970190761a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","backport:prev-minor"],"number":205497,"url":"https://github.com/elastic/kibana/pull/205497","mergeCommit":{"message":"[ResponseOps][Rules]
Moved params of anomaly detection rules to a separate package
(#205497)\n\nConnected with #195189\r\n\r\n## Summary\r\n\r\n- Moved
params of anomaly detection rule type
to\r\n`/response-ops/rule_params/anomaly_detection/`\r\n- Moved params
of anomaly detection jobs health rule type
to\r\n`/response-ops/rule_params/anomaly_detection_jobs_health/`\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"5235234640277d6f3a2f864f57aebb970190761a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205497","number":205497,"mergeCommit":{"message":"[ResponseOps][Rules]
Moved params of anomaly detection rules to a separate package
(#205497)\n\nConnected with #195189\r\n\r\n## Summary\r\n\r\n- Moved
params of anomaly detection rule type
to\r\n`/response-ops/rule_params/anomaly_detection/`\r\n- Moved params
of anomaly detection jobs health rule type
to\r\n`/response-ops/rule_params/anomaly_detection_jobs_health/`\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"5235234640277d6f3a2f864f57aebb970190761a"}}]}]
BACKPORT-->
Zacqary pushed a commit to Zacqary/kibana that referenced this issue Jan 9, 2025
…arate package (elastic#205497)

Connected with elastic#195189

## Summary

- Moved params of anomaly detection rule type to
`/response-ops/rule_params/anomaly_detection/`
- Moved params of anomaly detection jobs health rule type to
`/response-ops/rule_params/anomaly_detection_jobs_health/`

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
…ic#205492)

Connected with elastic#195189

## Summary

- Moved params of duration metric inventory threshold rule type to
`/response-ops/rule_params/metric_inventory_threshold/`
- Moved params of metric threshold rule type to
`/response-ops/rule_params/metric_threshold/`

**I did NOT move the corresponding type to the rule_params package due
to the recursive imports it would create.**

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
…arate package (elastic#205497)

Connected with elastic#195189

## Summary

- Moved params of anomaly detection rule type to
`/response-ops/rule_params/anomaly_detection/`
- Moved params of anomaly detection jobs health rule type to
`/response-ops/rule_params/anomaly_detection_jobs_health/`

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

4 participants