-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types #195496
Conversation
Pinging @elastic/response-ops (Team:ResponseOps) |
💔 Build Failed
Failed CI StepsTest FailuresThe CI Stats report is too large to be displayed here, check out the CI build annotation for this information. Historycc @ymao1 |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Starting backport for target branches: 8.x |
…r/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (elastic#195496) Resolves elastic#194208 ## Summary The original integration test was checking for the (non) existence of any error logs on startup when there are removed task types, which was not specific enough because there were occasionally error logs like ``` "Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK \"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\" failed: ResponseError: search_phase_execution_exception ``` so this PR updates the integration test to check specifically for workload aggregator error logs Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 742cd13)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#195496) (#195677) # Backport This will backport the following commits from `main` to `8.x`: - [Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#195496)](#195496) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ying Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T21:01:49Z","message":"Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#195496)\n\nResolves https://github.com/elastic/kibana/issues/194208\r\n\r\n## Summary\r\n\r\nThe original integration test was checking for the (non) existence of\r\nany error logs on startup when there are removed task types, which was\r\nnot specific enough because there were occasionally error logs like\r\n\r\n```\r\n\"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK \\\"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\\\" failed: ResponseError: search_phase_execution_exception\r\n```\r\n\r\nso this PR updates the integration test to check specifically for\r\nworkload aggregator error logs\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"742cd1336e71d2236608450e2a6a77b3ce9b3c4c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task Manager","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types","number":195496,"url":"https://github.com/elastic/kibana/pull/195496","mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#195496)\n\nResolves https://github.com/elastic/kibana/issues/194208\r\n\r\n## Summary\r\n\r\nThe original integration test was checking for the (non) existence of\r\nany error logs on startup when there are removed task types, which was\r\nnot specific enough because there were occasionally error logs like\r\n\r\n```\r\n\"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK \\\"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\\\" failed: ResponseError: search_phase_execution_exception\r\n```\r\n\r\nso this PR updates the integration test to check specifically for\r\nworkload aggregator error logs\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"742cd1336e71d2236608450e2a6a77b3ce9b3c4c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195496","number":195496,"mergeCommit":{"message":"Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#195496)\n\nResolves https://github.com/elastic/kibana/issues/194208\r\n\r\n## Summary\r\n\r\nThe original integration test was checking for the (non) existence of\r\nany error logs on startup when there are removed task types, which was\r\nnot specific enough because there were occasionally error logs like\r\n\r\n```\r\n\"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK \\\"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\\\" failed: ResponseError: search_phase_execution_exception\r\n```\r\n\r\nso this PR updates the integration test to check specifically for\r\nworkload aggregator error logs\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"742cd1336e71d2236608450e2a6a77b3ce9b3c4c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ying Mao <[email protected]>
Resolves #194208
Summary
The original integration test was checking for the (non) existence of any error logs on startup when there are removed task types, which was not specific enough because there were occasionally error logs like
so this PR updates the integration test to check specifically for workload aggregator error logs