Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types #195496

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented Oct 8, 2024

Resolves #194208

Summary

The original integration test was checking for the (non) existence of any error logs on startup when there are removed task types, which was not specific enough because there were occasionally error logs like

"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK \"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\" failed: ResponseError: search_phase_execution_exception

so this PR updates the integration test to check specifically for workload aggregator error logs

@ymao1 ymao1 self-assigned this Oct 8, 2024
@ymao1 ymao1 added release_note:skip Skip the PR/issue when compiling release notes Feature:Task Manager Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v9.0.0 backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 8, 2024
@ymao1 ymao1 marked this pull request as ready for review October 8, 2024 19:40
@ymao1 ymao1 requested a review from a team as a code owner October 8, 2024 19:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@ymao1 ymao1 requested review from pmuellr and guskovaue October 8, 2024 19:40
@ymao1 ymao1 changed the title Checking for specific error message Fixes Failing test: Jest Integration Tests.x-pack/plugins/task_manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types Oct 8, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 8, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / Template fields renders template fields correctly

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

cc @ymao1

@ymao1
Copy link
Contributor Author

ymao1 commented Oct 8, 2024

@elasticmachine merge upstream

Copy link
Member

@pmuellr pmuellr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymao1 ymao1 merged commit 742cd13 into elastic:main Oct 9, 2024
38 checks passed
@ymao1 ymao1 deleted the flaky-test-194208 branch October 9, 2024 21:01
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11263001357

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 9, 2024
…r/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (elastic#195496)

Resolves elastic#194208

## Summary

The original integration test was checking for the (non) existence of
any error logs on startup when there are removed task types, which was
not specific enough because there were occasionally error logs like

```
"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK \"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\" failed: ResponseError: search_phase_execution_exception
```

so this PR updates the integration test to check specifically for
workload aggregator error logs

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 742cd13)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 9, 2024
…manager/server/integration_tests - unrecognized task types should be no workload aggregator errors when there are removed task types (#195496) (#195677)

# Backport

This will backport the following commits from `main` to `8.x`:
- [Fixes Failing test: Jest Integration
Tests.x-pack/plugins/task_manager/server/integration_tests -
unrecognized task types should be no workload aggregator errors when
there are removed task types
(#195496)](#195496)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ying
Mao","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-09T21:01:49Z","message":"Fixes
Failing test: Jest Integration
Tests.x-pack/plugins/task_manager/server/integration_tests -
unrecognized task types should be no workload aggregator errors when
there are removed task types (#195496)\n\nResolves
https://github.com/elastic/kibana/issues/194208\r\n\r\n##
Summary\r\n\r\nThe original integration test was checking for the (non)
existence of\r\nany error logs on startup when there are removed task
types, which was\r\nnot specific enough because there were occasionally
error logs like\r\n\r\n```\r\n\"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK
\\\"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\\\" failed: ResponseError:
search_phase_execution_exception\r\n```\r\n\r\nso this PR updates the
integration test to check specifically for\r\nworkload aggregator error
logs\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"742cd1336e71d2236608450e2a6a77b3ce9b3c4c","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Feature:Task
Manager","Team:ResponseOps","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Fixes
Failing test: Jest Integration
Tests.x-pack/plugins/task_manager/server/integration_tests -
unrecognized task types should be no workload aggregator errors when
there are removed task
types","number":195496,"url":"https://github.com/elastic/kibana/pull/195496","mergeCommit":{"message":"Fixes
Failing test: Jest Integration
Tests.x-pack/plugins/task_manager/server/integration_tests -
unrecognized task types should be no workload aggregator errors when
there are removed task types (#195496)\n\nResolves
https://github.com/elastic/kibana/issues/194208\r\n\r\n##
Summary\r\n\r\nThe original integration test was checking for the (non)
existence of\r\nany error logs on startup when there are removed task
types, which was\r\nnot specific enough because there were occasionally
error logs like\r\n\r\n```\r\n\"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK
\\\"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\\\" failed: ResponseError:
search_phase_execution_exception\r\n```\r\n\r\nso this PR updates the
integration test to check specifically for\r\nworkload aggregator error
logs\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"742cd1336e71d2236608450e2a6a77b3ce9b3c4c"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195496","number":195496,"mergeCommit":{"message":"Fixes
Failing test: Jest Integration
Tests.x-pack/plugins/task_manager/server/integration_tests -
unrecognized task types should be no workload aggregator errors when
there are removed task types (#195496)\n\nResolves
https://github.com/elastic/kibana/issues/194208\r\n\r\n##
Summary\r\n\r\nThe original integration test was checking for the (non)
existence of\r\nany error logs on startup when there are removed task
types, which was\r\nnot specific enough because there were occasionally
error logs like\r\n\r\n```\r\n\"Task SLO:ORPHAN_SUMMARIES-CLEANUP-TASK
\\\"SLO:ORPHAN_SUMMARIES-CLEANUP-TASK:1.0.0\\\" failed: ResponseError:
search_phase_execution_exception\r\n```\r\n\r\nso this PR updates the
integration test to check specifically for\r\nworkload aggregator error
logs\r\n\r\nCo-authored-by: Elastic Machine
<[email protected]>","sha":"742cd1336e71d2236608450e2a6a77b3ce9b3c4c"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ying Mao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:Task Manager release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 v9.0.0
Projects
None yet
4 participants