[Security Solution] [Bug] The 'Enable' button should be disabled if no changes are made to the confirmation modal

[muskangulati-qasource]

Describe the bug
The 'Enable' button should be disabled if no changes are made to the confirmation modal

Kibana/Elasticsearch Stack version

VERSION: 8.16.0
BUILD: 79314
COMMIT: 5575428dd3aef69366cddb4ccf07a2a26d30ce48

Steps

1. Kibana version 8.16.0 or above should exist
2. Navigate to the Dashboards tab under Security
3. Select Entity Analytics dashboard
4. Click on the enable button
5. Disable the options for both risk score and Entity store
6. Observe the Enable button is still enabled

Expected Result
The Enable button should be disabled when no changes are made

Screen Recording

Bug14.mp4

[elasticmachine]

Pinging @elastic/security-solution (Team: SecuritySolution)

[elasticmachine]

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

[muskangulati-qasource]

@amolnater-qasource please review!

[amolnater-qasource]

Reviewed & assigned to @MadameSheema

[CAWilson94]

@muskangulati-qasource heya, for this, the enable button that should be disabled, is it the one on the modal? e.g. this one:

[muskangulati-qasource]

Hi @CAWilson94,

the enable button that should be disabled, is it the one on the modal

Yes, it is correct. The enable button we are talking about is the one on the modal.

Thank you!

[CAWilson94]

I had a brief chat with @r4zr32d3k1l who suggested instead of disabling this button we should show a warning sign to align with good UX practise. So I will align my fix with the modal here:

[CAWilson94]

Draft PR here - #199523

[CAWilson94]

#199523 PR here - disable button + warning callout used in solution.

[jaredburgettelastic]

@muskangulati-qasource @MadameSheema this fix did not make it into 8.16.1 BC2, and should instead be verified in the next 8.16.2 release

[MadameSheema]

@jaredburgettelastic please remember to add the proper labels once an issue is fixed so we can keep track of it :)

I'll do it this time, but for future reference.

[MadameSheema]

@muskangulati-qasource please validate the fix on 8.17.0 BC1, thanks! :)

[muskangulati-qasource]

Hi @MadameSheema,

We have tested this ticket on the latest 8.17.0 BC1 build and found the issue is now fixed.

Please find below the testing details:

Build Details

VERSION: 8.17.0
BUILD: 80364
COMMIT: e3c75d19d796c366aedc5788960b2c6cc868014f

Screenshot

Hence, we are closing this issue and marking it as 'QA Validated'.

Thanks!!