Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution][Data Quality Dashboard] fix pattern state reset on ilm phase filter change (#198549) #198806

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…n ilm phase filter change (elastic#198549)

addresses elastic#196523

- Fixes ilm phase change propagation on patterns.
- Adds missing tests for useResultsRollup functionality

## UI changes

### Before

https://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017

### After

https://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4
(cherry picked from commit ddf55ea)
@kibanamachine kibanamachine merged commit fa0bdda into elastic:8.x Nov 7, 2024
29 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 6126 6127 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 13.4MB 13.4MB -136.0B

History

cc @kapral18

kapral18 added a commit that referenced this pull request Nov 18, 2024
…reset on ilm phase filter change (#198549) (#200618)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Security Solution][Data Quality Dashboard] fix pattern state reset
on ilm phase filter change
(#198549)](#198549)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Karen
Grigoryan","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-04T15:09:12Z","message":"[Security
Solution][Data Quality Dashboard] fix pattern state reset on ilm phase
filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase
change propagation on patterns.\r\n- Adds missing tests for
useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n###
Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n###
After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting","Team:Threat
Hunting:Explore","backport:prev-minor","ci:cloud-deploy","ci:project-deploy-security","v8.17.0"],"number":198549,"url":"https://github.com/elastic/kibana/pull/198549","mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] fix pattern state reset on ilm phase
filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase
change propagation on patterns.\r\n- Adds missing tests for
useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n###
Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n###
After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198549","number":198549,"mergeCommit":{"message":"[Security
Solution][Data Quality Dashboard] fix pattern state reset on ilm phase
filter change (#198549)\n\naddresses #196523\r\n\r\n- Fixes ilm phase
change propagation on patterns.\r\n- Adds missing tests for
useResultsRollup functionality\r\n\r\n## UI changes\r\n\r\n###
Before\r\n\r\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\r\n\r\n###
After\r\n\r\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4","sha":"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198806","number":198806,"state":"MERGED","mergeCommit":{"sha":"fa0bddaac166c1bd17989a54b183677203f1812b","message":"[8.x]
[Security Solution][Data Quality Dashboard] fix pattern state reset on
ilm phase filter change (#198549) (#198806)\n\n# Backport\n\nThis will
backport the following commits from `main` to `8.x`:\n- [[Security
Solution][Data Quality Dashboard] fix pattern state reset\non ilm phase
filter
change\n(#198549)](https://github.com/elastic/kibana/pull/198549)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT
[{\"author\":{\"name\":\"Karen\nGrigoryan\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-11-04T15:09:12Z\",\"message\":\"[Security\nSolution][Data
Quality Dashboard] fix pattern state reset on ilm phase\nfilter change
(#198549)\\n\\naddresses #196523\\r\\n\\r\\n- Fixes ilm phase\nchange
propagation on patterns.\\r\\n- Adds missing tests for\nuseResultsRollup
functionality\\r\\n\\r\\n## UI
changes\\r\\n\\r\\n###\nBefore\\r\\n\\r\\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4\",\"sha\":\"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:Threat\nHunting\",\"Team:Threat\nHunting:Explore\",\"backport:prev-minor\",\"ci:cloud-deploy\",\"ci:project-deploy-security\"],\"title\":\"[Security\nSolution][Data
Quality Dashboard] fix pattern state reset on ilm
phase\nfilter\nchange\",\"number\":198549,\"url\":\"https://github.com/elastic/kibana/pull/198549\",\"mergeCommit\":{\"message\":\"[Security\nSolution][Data
Quality Dashboard] fix pattern state reset on ilm phase\nfilter change
(#198549)\\n\\naddresses #196523\\r\\n\\r\\n- Fixes ilm phase\nchange
propagation on patterns.\\r\\n- Adds missing tests for\nuseResultsRollup
functionality\\r\\n\\r\\n## UI
changes\\r\\n\\r\\n###\nBefore\\r\\n\\r\\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4\",\"sha\":\"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198549\",\"number\":198549,\"mergeCommit\":{\"message\":\"[Security\nSolution][Data
Quality Dashboard] fix pattern state reset on ilm phase\nfilter change
(#198549)\\n\\naddresses #196523\\r\\n\\r\\n- Fixes ilm phase\nchange
propagation on patterns.\\r\\n- Adds missing tests for\nuseResultsRollup
functionality\\r\\n\\r\\n## UI
changes\\r\\n\\r\\n###\nBefore\\r\\n\\r\\nhttps://github.com/user-attachments/assets/78a1d809-6a9a-4bfc-88a9-079f829a2017\\r\\n\\r\\n###\nAfter\\r\\n\\r\\nhttps://github.com/user-attachments/assets/f689fcc9-e1c6-4ccf-a7ca-8f13e9507ba4\",\"sha\":\"ddf55ea3a79ad7439dc02cb1f93291b1bc95c3b9\"}}]}]\nBACKPORT-->\n\nCo-authored-by:
Karen Grigoryan <[email protected]>"}}]}] BACKPORT-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants