[Security solution] Knowledge base entry telemetry #199225
Merged
+578
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
WIP
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
e40pud
approved these changes
Nov 11, 2024
| @@ -82,6 +84,16 @@ const buildBulkResponse = ( | |||
| skipped, | |||
| }; | |||
|
|
|||
| if (created.length) { | |||
| created.forEach((entry) => { | |||
There was a problem hiding this comment.
Should this be done after the successful bulk create entry operation? Just wondering if we partially created entries and some of them failed, in this case we still will report that all of them were created in telemetry?
There was a problem hiding this comment.
buildBulkResponse is called after the request has already been completed, so only created entries exist here
There was a problem hiding this comment.
ohh, I missed that this is inside buildBulkResponse :-)
| response, | ||
| { | ||
| // @ts-ignore-next-line TS2322 | ||
| updated: transformESToKnowledgeBase(docsUpdated), |
There was a problem hiding this comment.
Maybe we could also add telemetry for update and delete operations.
There was a problem hiding this comment.
Also, would be nice to report errors during the bulk call.
There was a problem hiding this comment.
Do we have a separate task for these operations?
There was a problem hiding this comment.
It seems we're not interested in update or delete, I asked Pedro and was told that wasn't important to track
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
History
|
|
Starting backport for target branches: 8.16, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 1127bf4)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
(cherry picked from commit 1127bf4)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…199723) # Backport This will backport the following commits from `main` to `8.16`: - [[Security solution] Knowledge base entry telemetry (#199225)](#199225) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T00:10:07Z","message":"[Security solution] Knowledge base entry telemetry (#199225)","sha":"1127bf491d78b7ce2319a13257dbf0b1e84226e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["WIP","release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security solution] Knowledge base entry telemetry","number":199225,"url":"https://github.com/elastic/kibana/pull/199225","mergeCommit":{"message":"[Security solution] Knowledge base entry telemetry (#199225)","sha":"1127bf491d78b7ce2319a13257dbf0b1e84226e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199225","number":199225,"mergeCommit":{"message":"[Security solution] Knowledge base entry telemetry (#199225)","sha":"1127bf491d78b7ce2319a13257dbf0b1e84226e8"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…199724) # Backport This will backport the following commits from `main` to `8.x`: - [[Security solution] Knowledge base entry telemetry (#199225)](#199225) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Steph Milovic","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T00:10:07Z","message":"[Security solution] Knowledge base entry telemetry (#199225)","sha":"1127bf491d78b7ce2319a13257dbf0b1e84226e8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["WIP","release_note:skip","v9.0.0","Team: SecuritySolution","Team:Security Generative AI","backport:version","v8.17.0","v8.16.1"],"title":"[Security solution] Knowledge base entry telemetry","number":199225,"url":"https://github.com/elastic/kibana/pull/199225","mergeCommit":{"message":"[Security solution] Knowledge base entry telemetry (#199225)","sha":"1127bf491d78b7ce2319a13257dbf0b1e84226e8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199225","number":199225,"mergeCommit":{"message":"[Security solution] Knowledge base entry telemetry (#199225)","sha":"1127bf491d78b7ce2319a13257dbf0b1e84226e8"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Steph Milovic <[email protected]>
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds 2 new events for tracking knowledge base entry creation:
Updates the
INVOKE_ASSISTANT_SUCCESSevent to track request duration, tools invoked, and optionallyisOssModel:Allows the addition of 2 new charts to GenAI Dashboard
Moved
INVOKE_ASSISTANT_SUCCESSeventMoved the
INVOKE_ASSISTANT_SUCCESSto be reported from the LangChain tracers in order to get information about the run.