[Fleet] Fix Install with streaming to save readme and icons #199727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchaulet
added
bug
|
Pinging @elastic/fleet (Team:Fleet) |
xcrzx
added
v9.0.0
v8.17.0
backport:version
juliaElastic
approved these changes
Nov 12, 2024
⏳ Build in-progress, with failures
Failed CI StepsHistory
cc @nchaulet |
…tection-reamde-image
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…99727) (#199823) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Fix Install with streaming to save readme and icons (#199727)](#199727) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-12T16:21:22Z","message":"[Fleet] Fix Install with streaming to save readme and icons (#199727)","sha":"839a9759ea56ded48477c8d31100c7f265add553","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v9.0.0","backport:version","v8.17.0"],"title":"[Fleet] Fix Install with streaming to save readme and icons","number":199727,"url":"https://github.com/elastic/kibana/pull/199727","mergeCommit":{"message":"[Fleet] Fix Install with streaming to save readme and icons (#199727)","sha":"839a9759ea56ded48477c8d31100c7f265add553"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199727","number":199727,"mergeCommit":{"message":"[Fleet] Fix Install with streaming to save readme and icons (#199727)","sha":"839a9759ea56ded48477c8d31100c7f265add553"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix installing security_detection_engine with streaming to save related readme, changelog and icons in ES, as once the package is installed we load the assets from ES and not the registry.
How to test?
Install
security_detection_engine(reload without cache) and verify image and reamde are correctly accessible in the integrations app forsecurity_detection_engine