-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet][Meta] Eui Visual Refresh #202008
Comments
Pinging @elastic/fleet (Team:Fleet) |
I ran Fleet with the new theme:
I got some screenshots of Fleet and Integrations: |
@andreadelrio @simosilvestri 👋 Regarding
All the PRs to update the use of colors have been merged. Is there anything else to validate on your side? |
@jillguyonnet sure! I just saw the deprecations mentioned in #204784 and I agree that we should add the ones in the current issue there. I'll add the deprecations on the new issue and we can then close this one as completed. |
Looks good to me! Thanks @jillguyonnet :) |
Context
The EUI team is making updates to EUI that require updates and QA by all Kibana Codeowners. Parent ticket: #199715
Instructions for updating and QA
).Changes can be applied directly in Kibana main.
Required
success
toaccentSecondary
where needed #201945Non blocking
Address deprecations
As part of this change, we also need to we address some deprecations in
Eui
:EuiThemeProvider
: https://github.com/search?q=repo%3Aelastic%2Fkibana+path%3Ax-pack%2Fplugins%2Ffleet%2Fpublic+EuiThemeProvider&type=code. This was deprecated a while ago but we need to check how to replace it (see comment)EuiStyled
: https://github.com/criamico/kibana/blob/8c14ca26ecce910f779ea7c050834014db3817dc/x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/overview/details.tsx#L50 this was also deprecated a while ago but it should be easy to replace as it's only used once across Fleet UI.The text was updated successfully, but these errors were encountered: