Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard][Collapsable Panels] Respond to touch events #202014

Closed
Tracked by #190342
Heenawter opened this issue Nov 27, 2024 · 1 comment · Fixed by #204225
Closed
Tracked by #190342

[Dashboard][Collapsable Panels] Respond to touch events #202014

Heenawter opened this issue Nov 27, 2024 · 1 comment · Fixed by #204225
Assignees
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Heenawter commented Nov 27, 2024

Describe the feature:

Currently, everything in kbn-grid-layout is driven by mouse events - onmousedown, onmouseup, onmousemove, etc. react-grid-layout responds to touch events (i.e. touchstart, touchend, touchmove, etc), and so we should also add support for these events in kbn-grid-layout.

@Heenawter Heenawter added Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@Heenawter Heenawter added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Nov 27, 2024
@mbondyra mbondyra self-assigned this Dec 12, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 9, 2025
## Summary

Adds support to touch events. The difference between these ones and
mouse events is that once they are active, the scroll is off (just like
in the current Dashboard)

https://github.com/user-attachments/assets/4cdcc850-7391-441e-ab9a-0abbe70e4e56

Fixes elastic#202014

(cherry picked from commit ea6d7be)
Zacqary pushed a commit to Zacqary/kibana that referenced this issue Jan 9, 2025
## Summary

Adds support to touch events. The difference between these ones and
mouse events is that once they are active, the scroll is off (just like
in the current Dashboard)


https://github.com/user-attachments/assets/4cdcc850-7391-441e-ab9a-0abbe70e4e56

Fixes elastic#202014
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
## Summary

Adds support to touch events. The difference between these ones and
mouse events is that once they are active, the scroll is off (just like
in the current Dashboard)


https://github.com/user-attachments/assets/4cdcc850-7391-441e-ab9a-0abbe70e4e56

Fixes elastic#202014
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
## Summary

Adds support to touch events. The difference between these ones and
mouse events is that once they are active, the scroll is off (just like
in the current Dashboard)


https://github.com/user-attachments/assets/4cdcc850-7391-441e-ab9a-0abbe70e4e56

Fixes elastic#202014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Collapsable Panels Related to the project for adding collapsable sections to Dashboards. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants