Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Fix DocViewer in light borealis theme #202043

Closed
jughosta opened this issue Nov 27, 2024 · 4 comments · Fixed by #202918
Closed

[Discover] Fix DocViewer in light borealis theme #202043

jughosta opened this issue Nov 27, 2024 · 4 comments · Fixed by #202918
Assignees
@jughosta @l-suarez
Labels
EUI Visual Refresh Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.

Comments

@jughosta
Copy link
Contributor

Values are hardly visible:

Image
@jughosta jughosta added the Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. label Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@jughosta jughosta mentioned this issue Dec 4, 2024
Merged
@l-suarez
Copy link

l-suarez commented Dec 9, 2024

hi @jughosta, it looks like this one might be already fixed?

@jughosta
Copy link
Contributor Author

jughosta commented Dec 9, 2024

@l-suarez Yes, I have a PR for fixing it #202918

@jughosta jughosta self-assigned this Dec 9, 2024
@l-suarez l-suarez closed this as completed Dec 9, 2024
@jughosta
Copy link
Contributor Author

jughosta commented Dec 9, 2024

The PR is in not merged yet so I would leave the issue open for now.

@jughosta jughosta reopened this Dec 9, 2024
jughosta added a commit that referenced this issue Dec 11, 2024
@jughosta
[Discover][Borealis] Fix DocViewer cell color (#202918)
545ef8a 
- Closes #202043

## Summary

This PR fixes text color in DocViewer in the light Borealis theme.

Before:
<img width="400" alt="390511364-e73c9c18-a40a-4026-8a94-e24212f19ca4"
src="https://github.com/user-attachments/assets/ecb12c37-3dc3-4163-b9d1-beaebf914faa">


After:
<img width="597" alt="Screenshot 2024-12-09 at 16 12 08"
src="https://github.com/user-attachments/assets/ea839509-6732-426f-b048-6e73fc2270a1">


### Testing

* Add the following to your `kibana.dev.yml`
```
uiSettings.experimental.themeSwitcherEnabled: true
uiSettings.overrides.theme:name: borealis
```
* Start Kibana with `KBN_OPTIMIZER_THEMES="experimental" yarn start`
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Dec 12, 2024
@jughosta @CAWilson94
[Discover][Borealis] Fix DocViewer cell color (elastic#202918)
3946bef 
- Closes elastic#202043

## Summary

This PR fixes text color in DocViewer in the light Borealis theme.

Before:
<img width="400" alt="390511364-e73c9c18-a40a-4026-8a94-e24212f19ca4"
src="https://github.com/user-attachments/assets/ecb12c37-3dc3-4163-b9d1-beaebf914faa">


After:
<img width="597" alt="Screenshot 2024-12-09 at 16 12 08"
src="https://github.com/user-attachments/assets/ea839509-6732-426f-b048-6e73fc2270a1">


### Testing

* Add the following to your `kibana.dev.yml`
```
uiSettings.experimental.themeSwitcherEnabled: true
uiSettings.overrides.theme:name: borealis
```
* Start Kibana with `KBN_OPTIMIZER_THEMES="experimental" yarn start`
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@jughosta @CAWilson94
[Discover][Borealis] Fix DocViewer cell color (elastic#202918)
d1f7431 
- Closes elastic#202043

## Summary

This PR fixes text color in DocViewer in the light Borealis theme.

Before:
<img width="400" alt="390511364-e73c9c18-a40a-4026-8a94-e24212f19ca4"
src="https://github.com/user-attachments/assets/ecb12c37-3dc3-4163-b9d1-beaebf914faa">


After:
<img width="597" alt="Screenshot 2024-12-09 at 16 12 08"
src="https://github.com/user-attachments/assets/ea839509-6732-426f-b048-6e73fc2270a1">


### Testing

* Add the following to your `kibana.dev.yml`
```
uiSettings.experimental.themeSwitcherEnabled: true
uiSettings.overrides.theme:name: borealis
```
* Start Kibana with `KBN_OPTIMIZER_THEMES="experimental" yarn start`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

@l-suarez l-suarez

Labels
EUI Visual Refresh Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover][Borealis] Fix DocViewer cell color jughosta/kibana
3 participants
@jughosta @elasticmachine @l-suarez