Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Embeddable Rebuild] Make HasSupportedTriggers optional for drilldown actions #202054

Open
Heenawter opened this issue Nov 27, 2024 · 1 comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Heenawter
Copy link
Contributor

Describe the feature:
Currently, we require supportedTriggers() to be defined in both the create and edit drilldown actions in order for them to be compatible. This is overkill IMO, because it's possible for drilldowns to only be supported via the context menu, which is already provided as a default:

const triggers = [
...ensureNestedTriggers(embeddable.supportedTriggers()),
CONTEXT_MENU_TRIGGER,
];

Because it's required, embeddables that don't need other supported triggers are forced to return an empty array in order to have context menu drilldowns. See #201870 (comment) for more context.

@Heenawter Heenawter added Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Nov 27, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort project:embeddableRebuild Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

2 participants