Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bulk Selection and Bulk Change Criticality Feature to DataGrid #202095

Open
5 tasks
opauloh opened this issue Nov 28, 2024 · 2 comments
Open
5 tasks

Add Bulk Selection and Bulk Change Criticality Feature to DataGrid #202095

opauloh opened this issue Nov 28, 2024 · 2 comments
Assignees
Labels
Team:Cloud Security Cloud Security team related
Milestone

Comments

@opauloh
Copy link
Contributor

opauloh commented Nov 28, 2024

Motivation

To enhance efficiency in managing assets, the DataGrid should support bulk selection of assets and provide the ability to change the criticality of selected assets. This feature allows users to manage multiple assets simultaneously, improving their workflow and reducing repetitive actions.

Definition of Done

  • Add a checkbox to the DataGrid header for selecting all items on the current page.
    • Clicking the header checkbox should:
      • Select all documents displayed on the current page.
      • Check the checkboxes of all rows in the current page.
    • Ensure clicking on individual row checkboxes updates the selection status of the header checkbox.
  • Implement a context action bar that appears when any assets are selected, showing:
    • "X assets selected": A dynamic text showing the number of selected assets.
      • Clicking on this text should open the Change Asset Criticality Flyout, allowing users to update the criticality of all selected items in bulk.
    • "Select all X assets": A button to select all items across all pages of the DataGrid.
      • The total count of selectable assets should be displayed in the button text (e.g., "Select all 500 assets").
      • Ensure the button toggles between selecting all assets and deselecting all assets.
  • Implement bulk actions in the Change Asset Criticality Flyout to:
    • Display the current criticality for selected assets.
    • Allow updating the criticality for all selected assets.
    • Provide success or error notifications for the operation.
  • Add unit tests to verify the functionality.
  • Add integration tests to ensure:
    • Interaction between the DataGrid and the Change Asset Criticality Flyout works as expected.
    • The "Select all X assets" button selects/deselects all items correctly across pages.

Requirements

  • The DataGrid should display feedback for slow operations when handling large selections (e.g., a loading spinner or progress indicator).

Out of Scope

  • Changes to the backend logic for fetching or updating asset criticality (assumes API already supports bulk updates).
  • Additional bulk actions beyond changing criticality.

Related tasks/epics

@opauloh opauloh added the Team:Cloud Security Cloud Security team related label Nov 28, 2024
@opauloh opauloh added this to the 8.18 milestone Nov 28, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@opauloh opauloh assigned albertoblaz and opauloh and unassigned albertoblaz Dec 19, 2024
@opauloh opauloh modified the milestones: 8.18, 9.1 Dec 19, 2024
@opauloh
Copy link
Contributor Author

opauloh commented Jan 23, 2025

As per conversation with @tinnytintin10, we are lowering the priority of this ticket to prioritize other functionalities such as onboarding and group by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Cloud Security Cloud Security team related
Projects
None yet
Development

No branches or pull requests

3 participants