Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UA] Support Deprecated Data Streams Migrations #202204

Merged
merged 9 commits into from
Dec 2, 2024

Conversation

Bamieh
Copy link
Member

@Bamieh Bamieh commented Nov 28, 2024

Summary

  • Fix UA currently failing to return upgrade status
  • Support surfacing data_streams migrations in UA under the ES tab
  • Refactor code for better readablity
  • Add more test cases across the board for all the es migrations status feature in UA
  • Add a featureSet.migrateDataStreams to enable surfacing data streams migrations
  • Surface data streams in UA UI
  • Take screenshots for a product review discussions
  • Unskip api_integration test cases

Imporant Notes

ES deprecations are hidden behind the featureSet flag and will only be shown in 8.last for users.
This gives us time to review the copy and implement the corrective action for reindexing data streams which is still pending implementaiton from ES side.

For now we will merge this to unblock upgrades in 8.17 and support surfacing data_streams deprecations and add tests.

Follow up work for 8.18

  • Add integration Tests
  • Update copy of flyout and documentation link
  • Reindexing data streams corrective action

Screenshots

Overview Page

image

Elasticsearch deprecation issues Page

image

Data streams deprecation details flyout

image

@Bamieh Bamieh added v9.0.0 auto-backport Deprecated - use backport:version if exact versions are needed v8.17.0 v8.18.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 28, 2024
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far!

I tested locally and this does fix the UI and API (/api/upgrade_assistant/status) error we were seeing from UA before.

If I am following correctly, this should surface data streams in the UI but with no corrective action. The intention is to add this later and it will not be shown in the meantime?

Aside: do you have a data archive that you are using to test the behavior on a 7.x data stream?

const clusterSettingDeprecation = metadata?.actions?.find(
(action) => action.action_type === 'remove_settings' && typeof indexName === 'undefined'
);
const requiresReindexAction = /Index created before/.test(message);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I've seen some response messages like:

Old index with a compatibility version < 8.0

We should update this logic to surface these as requiring reindex too... I'll ask ES how to reliably get this information from their deprecation API

@Bamieh Bamieh marked this pull request as ready for review December 2, 2024 15:42
@Bamieh Bamieh requested a review from a team as a code owner December 2, 2024 15:42
@Bamieh Bamieh added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels labels Dec 2, 2024
@Bamieh Bamieh requested a review from jloleysens December 2, 2024 15:47
Copy link
Contributor

@jloleysens jloleysens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test locally (again), but code LGTM.

It would be nice to add a simple integration test for /api/upgrade_assistant/state to ensure that it is 200 in order to detect issues early, but happy to do that in a follow up.

@Bamieh Bamieh requested a review from a team as a code owner December 2, 2024 20:09
@Bamieh
Copy link
Member Author

Bamieh commented Dec 2, 2024

It would be nice to add a simple integration test for /api/upgrade_assistant/state to ensure that it is 200 in order to detect issues early, but happy to do that in a follow up.

We had one but it was skipped when ES introduced the API: https://github.com/elastic/kibana-team/issues/1293

I did unskip it here: https://github.com/elastic/kibana/pull/202204/files#diff-8d5b1491cd749f69dbe216e6d1fc690676254fd8182c834231965b430609edb0

@Bamieh Bamieh enabled auto-merge (squash) December 2, 2024 20:26
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to test/plugin_functional/test_suites/core_plugins/rendering.ts LGTM

Copy link
Contributor

@mattkime mattkime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good nice work!

@Bamieh Bamieh merged commit a6b3743 into elastic:main Dec 2, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12128635123

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
upgradeAssistant 158.8KB 159.0KB +123.0B

History

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
## Summary

- [x] Fix UA currently failing to return upgrade status
- [x] Support surfacing `data_streams` migrations in UA under the ES tab
- [x] Refactor code for better readablity
- [x] Add more test cases across the board for all the es migrations
status feature in UA
- [x] Add a `featureSet.migrateDataStreams` to enable surfacing data
streams migrations
- [x] Surface data streams in UA UI
- [x] Take screenshots for a product review discussions
- [x] Unskip api_integration test cases

### Imporant Notes

ES deprecations are hidden behind the `featureSet` flag and will only be
shown in `8.last` for users.
This gives us time to review the copy and implement the corrective
action for reindexing data streams which is still pending implementaiton
from ES side.

For now we will merge this to unblock upgrades in `8.17` and support
surfacing data_streams deprecations and add tests.

Follow up work for `8.18`
- Add integration Tests
- Update copy of flyout and documentation link
- Reindexing data streams corrective action

closes elastic/kibana-team#1293

## Screenshots

#### Overview Page
<img width="683" alt="image"
src="https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d">

####  Elasticsearch deprecation issues Page

<img width="1453" alt="image"
src="https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb">

####  Data streams deprecation details flyout
<img width="778" alt="image"
src="https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59">

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit a6b3743)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
8.17 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 202204

Questions ?

Please refer to the Backport tool documentation

@Bamieh
Copy link
Member Author

Bamieh commented Dec 2, 2024

💚 All backports created successfully

Status Branch Result
8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@Bamieh Bamieh deleted the ua/support_data_streams_migrations branch December 2, 2024 22:44
kibanamachine added a commit that referenced this pull request Dec 2, 2024
)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[UA] Support Deprecated Data Streams Migrations
(#202204)](#202204)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ahmad
Bamieh","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T21:53:24Z","message":"[UA]
Support Deprecated Data Streams Migrations (#202204)\n\n##
Summary\r\n\r\n- [x] Fix UA currently failing to return upgrade
status\r\n- [x] Support surfacing `data_streams` migrations in UA under
the ES tab\r\n- [x] Refactor code for better readablity\r\n- [x] Add
more test cases across the board for all the es migrations\r\nstatus
feature in UA\r\n- [x] Add a `featureSet.migrateDataStreams` to enable
surfacing data\r\nstreams migrations\r\n- [x] Surface data streams in UA
UI\r\n- [x] Take screenshots for a product review discussions\r\n- [x]
Unskip api_integration test cases\r\n\r\n### Imporant Notes\r\n\r\nES
deprecations are hidden behind the `featureSet` flag and will only
be\r\nshown in `8.last` for users.\r\nThis gives us time to review the
copy and implement the corrective\r\naction for reindexing data streams
which is still pending implementaiton\r\nfrom ES side.\r\n\r\nFor now we
will merge this to unblock upgrades in `8.17` and support\r\nsurfacing
data_streams deprecations and add tests.\r\n\r\nFollow up work for
`8.18`\r\n- Add integration Tests\r\n- Update copy of flyout and
documentation link\r\n- Reindexing data streams corrective
action\r\n\r\ncloses
https://github.com/elastic/kibana-team/issues/1293\r\n\r\n##
Screenshots\r\n\r\n#### Overview Page\r\n<img width=\"683\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d\">\r\n\r\n####
Elasticsearch deprecation issues Page\r\n\r\n<img width=\"1453\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb\">\r\n\r\n\r\n####
Data streams deprecation details flyout\r\n<img width=\"778\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a6b3743e00add07c315eacadda4d0dbb532042ac","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","auto-backport","backport:prev-minor","backport:version","v8.17.0","v8.18.0"],"title":"[UA]
Support Deprecated Data Streams
Migrations","number":202204,"url":"https://github.com/elastic/kibana/pull/202204","mergeCommit":{"message":"[UA]
Support Deprecated Data Streams Migrations (#202204)\n\n##
Summary\r\n\r\n- [x] Fix UA currently failing to return upgrade
status\r\n- [x] Support surfacing `data_streams` migrations in UA under
the ES tab\r\n- [x] Refactor code for better readablity\r\n- [x] Add
more test cases across the board for all the es migrations\r\nstatus
feature in UA\r\n- [x] Add a `featureSet.migrateDataStreams` to enable
surfacing data\r\nstreams migrations\r\n- [x] Surface data streams in UA
UI\r\n- [x] Take screenshots for a product review discussions\r\n- [x]
Unskip api_integration test cases\r\n\r\n### Imporant Notes\r\n\r\nES
deprecations are hidden behind the `featureSet` flag and will only
be\r\nshown in `8.last` for users.\r\nThis gives us time to review the
copy and implement the corrective\r\naction for reindexing data streams
which is still pending implementaiton\r\nfrom ES side.\r\n\r\nFor now we
will merge this to unblock upgrades in `8.17` and support\r\nsurfacing
data_streams deprecations and add tests.\r\n\r\nFollow up work for
`8.18`\r\n- Add integration Tests\r\n- Update copy of flyout and
documentation link\r\n- Reindexing data streams corrective
action\r\n\r\ncloses
https://github.com/elastic/kibana-team/issues/1293\r\n\r\n##
Screenshots\r\n\r\n#### Overview Page\r\n<img width=\"683\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d\">\r\n\r\n####
Elasticsearch deprecation issues Page\r\n\r\n<img width=\"1453\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb\">\r\n\r\n\r\n####
Data streams deprecation details flyout\r\n<img width=\"778\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a6b3743e00add07c315eacadda4d0dbb532042ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202204","number":202204,"mergeCommit":{"message":"[UA]
Support Deprecated Data Streams Migrations (#202204)\n\n##
Summary\r\n\r\n- [x] Fix UA currently failing to return upgrade
status\r\n- [x] Support surfacing `data_streams` migrations in UA under
the ES tab\r\n- [x] Refactor code for better readablity\r\n- [x] Add
more test cases across the board for all the es migrations\r\nstatus
feature in UA\r\n- [x] Add a `featureSet.migrateDataStreams` to enable
surfacing data\r\nstreams migrations\r\n- [x] Surface data streams in UA
UI\r\n- [x] Take screenshots for a product review discussions\r\n- [x]
Unskip api_integration test cases\r\n\r\n### Imporant Notes\r\n\r\nES
deprecations are hidden behind the `featureSet` flag and will only
be\r\nshown in `8.last` for users.\r\nThis gives us time to review the
copy and implement the corrective\r\naction for reindexing data streams
which is still pending implementaiton\r\nfrom ES side.\r\n\r\nFor now we
will merge this to unblock upgrades in `8.17` and support\r\nsurfacing
data_streams deprecations and add tests.\r\n\r\nFollow up work for
`8.18`\r\n- Add integration Tests\r\n- Update copy of flyout and
documentation link\r\n- Reindexing data streams corrective
action\r\n\r\ncloses
https://github.com/elastic/kibana-team/issues/1293\r\n\r\n##
Screenshots\r\n\r\n#### Overview Page\r\n<img width=\"683\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d\">\r\n\r\n####
Elasticsearch deprecation issues Page\r\n\r\n<img width=\"1453\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb\">\r\n\r\n\r\n####
Data streams deprecation details flyout\r\n<img width=\"778\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a6b3743e00add07c315eacadda4d0dbb532042ac"}},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ahmad Bamieh <[email protected]>
Bamieh added a commit that referenced this pull request Dec 3, 2024
…2601)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[UA] Support Deprecated Data Streams Migrations
(#202204)](#202204)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ahmad
Bamieh","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T21:53:24Z","message":"[UA]
Support Deprecated Data Streams Migrations (#202204)\n\n##
Summary\r\n\r\n- [x] Fix UA currently failing to return upgrade
status\r\n- [x] Support surfacing `data_streams` migrations in UA under
the ES tab\r\n- [x] Refactor code for better readablity\r\n- [x] Add
more test cases across the board for all the es migrations\r\nstatus
feature in UA\r\n- [x] Add a `featureSet.migrateDataStreams` to enable
surfacing data\r\nstreams migrations\r\n- [x] Surface data streams in UA
UI\r\n- [x] Take screenshots for a product review discussions\r\n- [x]
Unskip api_integration test cases\r\n\r\n### Imporant Notes\r\n\r\nES
deprecations are hidden behind the `featureSet` flag and will only
be\r\nshown in `8.last` for users.\r\nThis gives us time to review the
copy and implement the corrective\r\naction for reindexing data streams
which is still pending implementaiton\r\nfrom ES side.\r\n\r\nFor now we
will merge this to unblock upgrades in `8.17` and support\r\nsurfacing
data_streams deprecations and add tests.\r\n\r\nFollow up work for
`8.18`\r\n- Add integration Tests\r\n- Update copy of flyout and
documentation link\r\n- Reindexing data streams corrective
action\r\n\r\ncloses
https://github.com/elastic/kibana-team/issues/1293\r\n\r\n##
Screenshots\r\n\r\n#### Overview Page\r\n<img width=\"683\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d\">\r\n\r\n####
Elasticsearch deprecation issues Page\r\n\r\n<img width=\"1453\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb\">\r\n\r\n\r\n####
Data streams deprecation details flyout\r\n<img width=\"778\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a6b3743e00add07c315eacadda4d0dbb532042ac","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","auto-backport","backport:prev-minor","backport:version","v8.17.0","v8.18.0"],"number":202204,"url":"https://github.com/elastic/kibana/pull/202204","mergeCommit":{"message":"[UA]
Support Deprecated Data Streams Migrations (#202204)\n\n##
Summary\r\n\r\n- [x] Fix UA currently failing to return upgrade
status\r\n- [x] Support surfacing `data_streams` migrations in UA under
the ES tab\r\n- [x] Refactor code for better readablity\r\n- [x] Add
more test cases across the board for all the es migrations\r\nstatus
feature in UA\r\n- [x] Add a `featureSet.migrateDataStreams` to enable
surfacing data\r\nstreams migrations\r\n- [x] Surface data streams in UA
UI\r\n- [x] Take screenshots for a product review discussions\r\n- [x]
Unskip api_integration test cases\r\n\r\n### Imporant Notes\r\n\r\nES
deprecations are hidden behind the `featureSet` flag and will only
be\r\nshown in `8.last` for users.\r\nThis gives us time to review the
copy and implement the corrective\r\naction for reindexing data streams
which is still pending implementaiton\r\nfrom ES side.\r\n\r\nFor now we
will merge this to unblock upgrades in `8.17` and support\r\nsurfacing
data_streams deprecations and add tests.\r\n\r\nFollow up work for
`8.18`\r\n- Add integration Tests\r\n- Update copy of flyout and
documentation link\r\n- Reindexing data streams corrective
action\r\n\r\ncloses
https://github.com/elastic/kibana-team/issues/1293\r\n\r\n##
Screenshots\r\n\r\n#### Overview Page\r\n<img width=\"683\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d\">\r\n\r\n####
Elasticsearch deprecation issues Page\r\n\r\n<img width=\"1453\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb\">\r\n\r\n\r\n####
Data streams deprecation details flyout\r\n<img width=\"778\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a6b3743e00add07c315eacadda4d0dbb532042ac"}},"sourceBranch":"main","suggestedTargetBranches":["8.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202204","number":202204,"mergeCommit":{"message":"[UA]
Support Deprecated Data Streams Migrations (#202204)\n\n##
Summary\r\n\r\n- [x] Fix UA currently failing to return upgrade
status\r\n- [x] Support surfacing `data_streams` migrations in UA under
the ES tab\r\n- [x] Refactor code for better readablity\r\n- [x] Add
more test cases across the board for all the es migrations\r\nstatus
feature in UA\r\n- [x] Add a `featureSet.migrateDataStreams` to enable
surfacing data\r\nstreams migrations\r\n- [x] Surface data streams in UA
UI\r\n- [x] Take screenshots for a product review discussions\r\n- [x]
Unskip api_integration test cases\r\n\r\n### Imporant Notes\r\n\r\nES
deprecations are hidden behind the `featureSet` flag and will only
be\r\nshown in `8.last` for users.\r\nThis gives us time to review the
copy and implement the corrective\r\naction for reindexing data streams
which is still pending implementaiton\r\nfrom ES side.\r\n\r\nFor now we
will merge this to unblock upgrades in `8.17` and support\r\nsurfacing
data_streams deprecations and add tests.\r\n\r\nFollow up work for
`8.18`\r\n- Add integration Tests\r\n- Update copy of flyout and
documentation link\r\n- Reindexing data streams corrective
action\r\n\r\ncloses
https://github.com/elastic/kibana-team/issues/1293\r\n\r\n##
Screenshots\r\n\r\n#### Overview Page\r\n<img width=\"683\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d\">\r\n\r\n####
Elasticsearch deprecation issues Page\r\n\r\n<img width=\"1453\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb\">\r\n\r\n\r\n####
Data streams deprecation details flyout\r\n<img width=\"778\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59\">\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"a6b3743e00add07c315eacadda4d0dbb532042ac"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/202593","number":202593,"state":"OPEN"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
## Summary

- [x] Fix UA currently failing to return upgrade status
- [x] Support surfacing `data_streams` migrations in UA under the ES tab
- [x] Refactor code for better readablity
- [x] Add more test cases across the board for all the es migrations
status feature in UA
- [x] Add a `featureSet.migrateDataStreams` to enable surfacing data
streams migrations
- [x] Surface data streams in UA UI
- [x] Take screenshots for a product review discussions
- [x] Unskip api_integration test cases

### Imporant Notes

ES deprecations are hidden behind the `featureSet` flag and will only be
shown in `8.last` for users.
This gives us time to review the copy and implement the corrective
action for reindexing data streams which is still pending implementaiton
from ES side.

For now we will merge this to unblock upgrades in `8.17` and support
surfacing data_streams deprecations and add tests.

Follow up work for `8.18`
- Add integration Tests
- Update copy of flyout and documentation link
- Reindexing data streams corrective action

closes elastic/kibana-team#1293

## Screenshots

#### Overview Page
<img width="683" alt="image"
src="https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d">

####  Elasticsearch deprecation issues Page

<img width="1453" alt="image"
src="https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb">


####  Data streams deprecation details flyout
<img width="778" alt="image"
src="https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59">

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
## Summary

- [x] Fix UA currently failing to return upgrade status
- [x] Support surfacing `data_streams` migrations in UA under the ES tab
- [x] Refactor code for better readablity
- [x] Add more test cases across the board for all the es migrations
status feature in UA
- [x] Add a `featureSet.migrateDataStreams` to enable surfacing data
streams migrations
- [x] Surface data streams in UA UI
- [x] Take screenshots for a product review discussions
- [x] Unskip api_integration test cases

### Imporant Notes

ES deprecations are hidden behind the `featureSet` flag and will only be
shown in `8.last` for users.
This gives us time to review the copy and implement the corrective
action for reindexing data streams which is still pending implementaiton
from ES side.

For now we will merge this to unblock upgrades in `8.17` and support
surfacing data_streams deprecations and add tests.

Follow up work for `8.18`
- Add integration Tests
- Update copy of flyout and documentation link
- Reindexing data streams corrective action

closes elastic/kibana-team#1293

## Screenshots

#### Overview Page
<img width="683" alt="image"
src="https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d">

####  Elasticsearch deprecation issues Page

<img width="1453" alt="image"
src="https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb">


####  Data streams deprecation details flyout
<img width="778" alt="image"
src="https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59">

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
## Summary

- [x] Fix UA currently failing to return upgrade status
- [x] Support surfacing `data_streams` migrations in UA under the ES tab
- [x] Refactor code for better readablity
- [x] Add more test cases across the board for all the es migrations
status feature in UA
- [x] Add a `featureSet.migrateDataStreams` to enable surfacing data
streams migrations
- [x] Surface data streams in UA UI
- [x] Take screenshots for a product review discussions
- [x] Unskip api_integration test cases

### Imporant Notes

ES deprecations are hidden behind the `featureSet` flag and will only be
shown in `8.last` for users.
This gives us time to review the copy and implement the corrective
action for reindexing data streams which is still pending implementaiton
from ES side.

For now we will merge this to unblock upgrades in `8.17` and support
surfacing data_streams deprecations and add tests.

Follow up work for `8.18`
- Add integration Tests
- Update copy of flyout and documentation link
- Reindexing data streams corrective action

closes elastic/kibana-team#1293

## Screenshots

#### Overview Page
<img width="683" alt="image"
src="https://github.com/user-attachments/assets/246d89ac-02cd-4813-ba38-e2e28df00c8d">

####  Elasticsearch deprecation issues Page

<img width="1453" alt="image"
src="https://github.com/user-attachments/assets/b5fd5f15-fa44-4acb-b7ff-4973593dcfbb">


####  Data streams deprecation details flyout
<img width="778" alt="image"
src="https://github.com/user-attachments/assets/af343f69-7e76-4c91-a6e3-cff29e26df59">

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants