Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[One Discover] change log.level colors slightly for Amsterdam theme #202258

Closed
LucaWintergerst opened this issue Nov 29, 2024 · 1 comment · Fixed by #202985
Closed

[One Discover] change log.level colors slightly for Amsterdam theme #202258

LucaWintergerst opened this issue Nov 29, 2024 · 1 comment · Fixed by #202985
Assignees
@tonyghiani
Labels
Project:OneDiscover Enrich Discover with contextual awareness Team:obs-ux-logs Observability Logs User Experience Team

Comments

@LucaWintergerst
Copy link
Contributor

For 8.x / Amsterdam, we need to make small adjustments to the log.level colors

We will follow up with more future proof changes in Borealis

We decided to use Option A from this comment
#186273 (comment)
@LucaWintergerst LucaWintergerst added the Team:obs-ux-logs Observability Logs User Experience Team label Nov 29, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@LucaWintergerst LucaWintergerst added the Project:OneDiscover Enrich Discover with contextual awareness label Nov 29, 2024
@tonyghiani tonyghiani self-assigned this Dec 4, 2024
@tonyghiani tonyghiani mentioned this issue Dec 4, 2024
Merged
tonyghiani added a commit that referenced this issue Dec 12, 2024
@tonyghiani
[One Discover] Update log.level indicators color (#202985)
c47b509 
## 📓 Summary

Closes #202258 

This change updates the colors scale for Discover's `log.level`
indicators to differentiate errors from other levels better.

**N.B. As this relies on some hard-coded values defined
[here](#186273 (comment)),
it is not a definitive version, but a middle step to enhance the scale
in v8.x versions.**
With the introduction of the Borealis theme in v9, a new scale
token-based will replace this.

<img width="934" alt="Screenshot 2024-12-04 at 17 40 32"
src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Dec 12, 2024
@tonyghiani
[One Discover] Update log.level indicators color (elastic#202985)
1cc0735 
## 📓 Summary

Closes elastic#202258

This change updates the colors scale for Discover's `log.level`
indicators to differentiate errors from other levels better.

**N.B. As this relies on some hard-coded values defined
[here](elastic#186273 (comment)),
it is not a definitive version, but a middle step to enhance the scale
in v8.x versions.**
With the introduction of the Borealis theme in v9, a new scale
token-based will replace this.

<img width="934" alt="Screenshot 2024-12-04 at 17 40 32"
src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
(cherry picked from commit c47b509)
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@tonyghiani @CAWilson94
[One Discover] Update log.level indicators color (elastic#202985)
e54b7a5 
## 📓 Summary

Closes elastic#202258 

This change updates the colors scale for Discover's `log.level`
indicators to differentiate errors from other levels better.

**N.B. As this relies on some hard-coded values defined
[here](elastic#186273 (comment)),
it is not a definitive version, but a middle step to enhance the scale
in v8.x versions.**
With the introduction of the Borealis theme in v9, a new scale
token-based will replace this.

<img width="934" alt="Screenshot 2024-12-04 at 17 40 32"
src="https://github.com/user-attachments/assets/b3da1300-b39a-4ad0-92c9-fde5dabe91ec">

---------

Co-authored-by: Marco Antonio Ghiani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyghiani tonyghiani

Labels
Project:OneDiscover Enrich Discover with contextual awareness Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[One Discover] Update log.level indicators color tonyghiani/kibana
3 participants
@LucaWintergerst @elasticmachine @tonyghiani