Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ent Search Deprecation] Update enterprise_search URLs for Elasticsearch->Build #202371

Merged
merged 4 commits into from
Dec 10, 2024

Conversation

saikatsarkar056
Copy link
Contributor

@saikatsarkar056 saikatsarkar056 commented Nov 29, 2024

This change is related to this issue. This PR replaces 'enterprise_search' with 'elasticsearch' in all urls for Elasticsearch->Build. In the PR, we replaced the following URLs.

Old URL New URL
app/enterprise_search/applications/search_applications app/elasticsearch/applications/search_applications
app/enterprise_search/analytics app/elasticsearch/analytics
Screen.Recording.2024-12-03.at.9.56.41.AM.mov

@saikatsarkar056 saikatsarkar056 requested a review from a team as a code owner November 29, 2024 22:59
@saikatsarkar056 saikatsarkar056 changed the title [Ent Search Deprecation] Update enterprise_search URLs [Ent Search Deprecation] Update enterprise_search URLs for Elasticsearch->Build Nov 29, 2024
@saikatsarkar056 saikatsarkar056 self-assigned this Nov 29, 2024
@saikatsarkar056 saikatsarkar056 added backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.18.0 v9.0.0 labels Nov 29, 2024
@saikatsarkar056
Copy link
Contributor Author

@elasticmachine merge upstream

@saikatsarkar056
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem good. You need to fix the labels if you want this PR to backport to v8.18.0 remove the backport:skip and add backport:prev-minor

@saikatsarkar056 saikatsarkar056 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 9, 2024
@saikatsarkar056
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.6MB 2.6MB -32.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
enterpriseSearch 52.3KB 52.3KB -8.0B

History

cc @saikatsarkar056

@saikatsarkar056 saikatsarkar056 merged commit a3d9fe3 into elastic:main Dec 10, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12259862624

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
…rch->Build (elastic#202371)

This change is related to this
[issue](elastic/search-team#7961). This PR
replaces 'enterprise_search' with 'elasticsearch' in all urls for
Elasticsearch->Build. In the PR, we replaced the following URLs.

| Old URL | New URL |
| :------------------------------------- |
:------------------------------------- |
| app/enterprise_search/applications/search_applications |
app/elasticsearch/applications/search_applications |
| app/enterprise_search/analytics | app/elasticsearch/analytics |

https://github.com/user-attachments/assets/e7b6ba66-e47b-4d99-8edc-37a9d30edc69

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit a3d9fe3)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
…ticsearch-&gt;Build (#202371) (#203630)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Ent Search Deprecation] Update enterprise_search URLs for
Elasticsearch-&gt;Build
(#202371)](#202371)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Saikat
Sarkar","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:55:15Z","message":"[Ent
Search Deprecation] Update enterprise_search URLs for
Elasticsearch->Build (#202371)\n\nThis change is related to
this\r\n[issue](elastic/search-team#7961).
This PR\r\nreplaces 'enterprise_search' with 'elasticsearch' in all urls
for\r\nElasticsearch->Build. In the PR, we replaced the following
URLs.\r\n\r\n| Old URL | New URL |\r\n|
:-------------------------------------
|\r\n:------------------------------------- |\r\n|
app/enterprise_search/applications/search_applications
|\r\napp/elasticsearch/applications/search_applications |\r\n|
app/enterprise_search/analytics | app/elasticsearch/analytics
|\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e7b6ba66-e47b-4d99-8edc-37a9d30edc69\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"a3d9fe34b4faf679fa883279dfecae5710423bde","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:EnterpriseSearch","backport:prev-minor","v8.18.0"],"title":"[Ent
Search Deprecation] Update enterprise_search URLs for
Elasticsearch->Build","number":202371,"url":"https://github.com/elastic/kibana/pull/202371","mergeCommit":{"message":"[Ent
Search Deprecation] Update enterprise_search URLs for
Elasticsearch->Build (#202371)\n\nThis change is related to
this\r\n[issue](elastic/search-team#7961).
This PR\r\nreplaces 'enterprise_search' with 'elasticsearch' in all urls
for\r\nElasticsearch->Build. In the PR, we replaced the following
URLs.\r\n\r\n| Old URL | New URL |\r\n|
:-------------------------------------
|\r\n:------------------------------------- |\r\n|
app/enterprise_search/applications/search_applications
|\r\napp/elasticsearch/applications/search_applications |\r\n|
app/enterprise_search/analytics | app/elasticsearch/analytics
|\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e7b6ba66-e47b-4d99-8edc-37a9d30edc69\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"a3d9fe34b4faf679fa883279dfecae5710423bde"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202371","number":202371,"mergeCommit":{"message":"[Ent
Search Deprecation] Update enterprise_search URLs for
Elasticsearch->Build (#202371)\n\nThis change is related to
this\r\n[issue](elastic/search-team#7961).
This PR\r\nreplaces 'enterprise_search' with 'elasticsearch' in all urls
for\r\nElasticsearch->Build. In the PR, we replaced the following
URLs.\r\n\r\n| Old URL | New URL |\r\n|
:-------------------------------------
|\r\n:------------------------------------- |\r\n|
app/enterprise_search/applications/search_applications
|\r\napp/elasticsearch/applications/search_applications |\r\n|
app/enterprise_search/analytics | app/elasticsearch/analytics
|\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/e7b6ba66-e47b-4d99-8edc-37a9d30edc69\r\n\r\n---------\r\n\r\nCo-authored-by:
Elastic Machine
<[email protected]>","sha":"a3d9fe34b4faf679fa883279dfecae5710423bde"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Saikat Sarkar <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
…rch->Build (elastic#202371)

This change is related to this
[issue](elastic/search-team#7961). This PR
replaces 'enterprise_search' with 'elasticsearch' in all urls for
Elasticsearch->Build. In the PR, we replaced the following URLs.

| Old URL | New URL |
| :------------------------------------- |
:------------------------------------- |
| app/enterprise_search/applications/search_applications |
app/elasticsearch/applications/search_applications |
| app/enterprise_search/analytics | app/elasticsearch/analytics |



https://github.com/user-attachments/assets/e7b6ba66-e47b-4d99-8edc-37a9d30edc69

---------

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:EnterpriseSearch v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants