[OpenAPI] Fix Serverless API base URL #202373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcawl
added
Team:Docs
release_note:skip
|
Pinging @elastic/kibana-docs (Team:Docs) |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
|
|
Starting backport for target branches: 8.16, 8.17 |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 54370b2)
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 54370b2)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
lcawl
added a commit
to lcawl/kibana
that referenced
this pull request
Dec 2, 2024
(cherry picked from commit 54370b2)
lcawl
added a commit
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[OpenAPI] Fix Serverless API base URL (#202373)](#202373) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T20:09:03Z","message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0","v8.16.2"],"number":202373,"url":"https://github.com/elastic/kibana/pull/202373","mergeCommit":{"message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202373","number":202373,"mergeCommit":{"message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
lcawl
added a commit
that referenced
this pull request
Dec 3, 2024
# Backport This will backport the following commits from `main` to `8.16`: - [[OpenAPI] Fix Serverless API base URL (#202373)](#202373) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T20:09:03Z","message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0","v8.16.2"],"number":202373,"url":"https://github.com/elastic/kibana/pull/202373","mergeCommit":{"message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202373","number":202373,"mergeCommit":{"message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
lcawl
added a commit
that referenced
this pull request
Dec 4, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[OpenAPI] Fix Serverless API base URL (#202373)](#202373) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Lisa Cawley","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T20:09:03Z","message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Docs","release_note:skip","v9.0.0","docs","ci:project-deploy-observability","Team:obs-ux-management","backport:version","v8.17.0","v8.18.0","v8.16.2"],"number":202373,"url":"https://github.com/elastic/kibana/pull/202373","mergeCommit":{"message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e"}},"sourceBranch":"main","suggestedTargetBranches":["8.17","8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202373","number":202373,"mergeCommit":{"message":"[OpenAPI] Fix Serverless API base URL (#202373)","sha":"54370b209cb8f4fe02186355f69b8d2f4e4bc97e"}},{"branch":"8.17","label":"v8.17.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dominique Clarke <[email protected]>
kibanamachine
removed
the
backport missing
hop-dev
pushed a commit
to hop-dev/kibana
that referenced
this pull request
Dec 5, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 9, 2024
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes elastic/docs-content#153
In particular, it removes unnecessary server URL declarations from some SLO API files and updates the kibana API overlays so that the serverless API document is no longer referring to "localhost".
NOTE: Per https://spec.openapis.org/oas/v3.0.3#server-object the "default" value is required.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
No
Screenshots
The Kibana Serverless API examples will look like this:
The Kibana API examples will look like this: