Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics TLS certificate] Fix error when opening rule flyout #202386

Merged
merged 4 commits into from
Dec 2, 2024
Merged

[Synthetics TLS certificate] Fix error when opening rule flyout #202386

merged 4 commits into from
Dec 2, 2024

Conversation

benakansara
Copy link
Contributor

@benakansara benakansara commented Nov 30, 2024 •
edited by kibanamachine
Loading

Fixes #188828

@benakansara benakansara added release_note:fix Team:obs-ux-management Observability Management User Experience Team labels Nov 30, 2024
@benakansara benakansara self-assigned this Nov 30, 2024
@benakansara benakansara marked this pull request as ready for review November 30, 2024 14:33
@benakansara benakansara requested a review from a team as a code owner November 30, 2024 14:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@benakansara benakansara added the backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development label Nov 30, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

maryam-saeidi
maryam-saeidi approved these changes Dec 2, 2024
View reviewed changes
Copy link
Member

@maryam-saeidi maryam-saeidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Do you know why this issue happened? Or when was it introduced?

@benakansara
Copy link
Contributor Author

benakansara commented Dec 2, 2024 •
edited
Loading

Do you know why this issue happened? Or when was it introduced?

I think the issue was there (error creating rule from Observability) since the introduction of this new rule. I don't see any other commit related to this rule other than this PR, unless this was a side effect of some other changes.

I am not entirely sure why the issue happened, maybe @shahzad31 can provide more information

shahzad31
shahzad31 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

@benakansara benakansara enabled auto-merge (squash) December 2, 2024 14:36
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 2, 2024 •
edited
Loading

💚 Build Succeeded

  • Buildkite Build
  • Commit: bf992e5
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-202386-bf992e5b5acd

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.1MB 1.1MB +23.0B

History

cc @benakansara

@benakansara benakansara merged commit c4dc230 into elastic:main Dec 2, 2024
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.16, 8.17, 8.x

https://github.com/elastic/kibana/actions/runs/12123341174

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@benakansara
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
26848d6 
…tic#202386)

Fixes elastic#188828

(cherry picked from commit c4dc230)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@benakansara
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
62ea05a 
…tic#202386)

Fixes elastic#188828

(cherry picked from commit c4dc230)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@benakansara
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
b5a6513 
…tic#202386)

Fixes elastic#188828

(cherry picked from commit c4dc230)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 2, 2024
@benakansara
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
7fe2e93 
…tic#202386)

Fixes elastic#188828

(cherry picked from commit c4dc230)
@kibanamachine kibanamachine mentioned this pull request Dec 2, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.15
✅ 8.16
✅ 8.17
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @benakansara
[8.15] [Synthetics TLS certificate] Fix error when opening rule flyout (
271455a 
#202386) (#202524)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Synthetics TLS certificate] Fix error when opening rule flyout
(#202386)](#202386)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:11:12Z","message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics
TLS certificate] Fix error when opening rule
flyout","number":202386,"url":"https://github.com/elastic/kibana/pull/202386","mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202386","number":202386,"mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @benakansara
[8.16] [Synthetics TLS certificate] Fix error when opening rule flyout (
264b11d 
#202386) (#202525)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[Synthetics TLS certificate] Fix error when opening rule flyout
(#202386)](#202386)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:11:12Z","message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics
TLS certificate] Fix error when opening rule
flyout","number":202386,"url":"https://github.com/elastic/kibana/pull/202386","mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202386","number":202386,"mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @benakansara
[8.x] [Synthetics TLS certificate] Fix error when opening rule flyout (…
8b19158 
…#202386) (#202527)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics TLS certificate] Fix error when opening rule flyout
(#202386)](#202386)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:11:12Z","message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics
TLS certificate] Fix error when opening rule
flyout","number":202386,"url":"https://github.com/elastic/kibana/pull/202386","mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202386","number":202386,"mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
kibanamachine added a commit that referenced this pull request Dec 2, 2024
@kibanamachine @benakansara
[8.17] [Synthetics TLS certificate] Fix error when opening rule flyout (
4266673 
#202386) (#202526)

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Synthetics TLS certificate] Fix error when opening rule flyout
(#202386)](#202386)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Bena
Kansara","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-02T16:11:12Z","message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics
TLS certificate] Fix error when opening rule
flyout","number":202386,"url":"https://github.com/elastic/kibana/pull/202386","mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202386","number":202386,"mergeCommit":{"message":"[Synthetics
TLS certificate] Fix error when opening rule flyout (#202386)\n\nFixes
https://github.com/elastic/kibana/issues/188828","sha":"c4dc230f2ee3da6568d58e4f7caf2daba2ad842f"}}]}]
BACKPORT-->

Co-authored-by: Bena Kansara <[email protected]>
hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
@benakansara @hop-dev
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
3e170a6 
…tic#202386)

Fixes elastic#188828
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@benakansara @CAWilson94
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
5af5fa7 
…tic#202386)

Fixes elastic#188828
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@benakansara @CAWilson94
[Synthetics TLS certificate] Fix error when opening rule flyout (elas…
c0aa6b0 
…tic#202386)

Fixes elastic#188828
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maryam-saeidi maryam-saeidi maryam-saeidi approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

Assignees

@benakansara benakansara

Labels
backport:prev-major Backport to (8.x, 8.17, 8.16) the previous major branch and other branches in development ci:project-deploy-observability Create an Observability project release_note:fix Team:obs-ux-management Observability Management User Experience Team v8.15.6 v8.16.2 v8.17.0 v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Synthetics TLS certificate] Error when opening the rule's flyout
5 participants
@benakansara @elasticmachine @kibanamachine @shahzad31 @maryam-saeidi