Sustainable Kibana Architecture: Move modules owned by @elastic/kibana-operations
#202739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsoldevila
added
Team:Core
|
Pinging @elastic/kibana-core (Team:Core) |
|
Pinging @elastic/kibana-operations (Team:Operations) |
gsoldevila
added
backport:skip
gsoldevila
force-pushed
the
kbn-team-1309-move-kibana-operations
branch
4 times, most recently
from
d892cfa to
8d6a37f
Compare
Ikuni17
requested changes
Dec 11, 2024
There was a problem hiding this comment.
We will need an update for the gitignore
Line 135 in e3ec477
Also, I think we need to update limits.yml for the build to pass
|
@Ikuni17 - I fixed the mentioned issues, and merge conflicts. let's hope CI will be green after this |
delanni
reviewed
Dec 12, 2024
packages/kbn-optimizer/limits.yml
Outdated
| @@ -10,14 +10,14 @@ pageLoadAssetSize: | |||
| bfetch: 22837 | |||
| canvas: 29355 | |||
| cases: 180037 | |||
| charts: 55000 | |||
| cloud: 21076 | |||
| charts: 92400 | |||
There was a problem hiding this comment.
This is a notable increase. Along with the other ones. @elastic/kibana-operations / @gsoldevila - are these expected through the move?
There was a problem hiding this comment.
No it's not, I have no idea what is causing this increase yet, but might be worth digging into.
tsullivan
approved these changes
Dec 13, 2024
rudolf
added
the
plugin groups
dokmic
force-pushed
the
kbn-team-1309-move-kibana-operations
branch
from
6655395 to
66b023c
Compare
dokmic
approved these changes
Dec 19, 2024
dokmic
force-pushed
the
kbn-team-1309-move-kibana-operations
branch
from
66b023c to
952d659
Compare
dokmic
force-pushed
the
kbn-team-1309-move-kibana-operations
branch
from
152bffa to
1b98ded
Compare
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
|
jbudz
approved these changes
Dec 30, 2024
Ikuni17
approved these changes
Dec 30, 2024
dokmic
added
v9.0.0
backport:version
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
dokmic
added a commit
that referenced
this pull request
Dec 31, 2024
…c/kibana-operations` (#202739) (#205320) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-operations` (#202739)](#202739) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Gerard Soldevila","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-31T12:47:59Z","message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-operations` (#202739)\n\n## Summary\n\nThis PR aims at relocating some of the Kibana modules (plugins and\npackages) into a new folder structure, according to the _Sustainable\nKibana Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you to:\n> * Manually fix the errors in the error section below (if there are\nany).\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config files), and update them\nappropriately.\n> * Manually review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\nany CI pipeline customizations continue to be correctly applied after\nthe changed path names\n> * Review all of the updated files, specially the `.ts` and `.js` files\nlisted in the sections below, as some of them contain relative paths\nthat have been updated.\n> * Think of potential impact of the move, including tooling and\nconfiguration files that can be pointing to the relocated modules. E.g.:\n> * customised eslint rules\n> * docs pointing to source code\n\n> [!NOTE]\n> * This PR has been auto-generated.\n> * Any manual contributions will be lost if the 'relocate' script is\nre-run.\n> * Try to obtain the missing reviews / approvals before applying manual\nfixes, and/or keep your changes in a .patch / git stash.\n> * Please use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack channel for feedback.\n\nAre you trying to rebase this PR to solve merge conflicts? Please follow\nthe steps describe\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\n\n#### 9 packages(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/cbor` | `src/platform/packages/shared/kbn-cbor` |\n| `@kbn/repo-info` | `src/platform/packages/shared/kbn-repo-info` |\n| `@kbn/repo-packages` |\n`src/platform/packages/private/kbn-repo-packages` |\n| `@kbn/rison` | `src/platform/packages/shared/kbn-rison` |\n| `@kbn/ui-shared-deps-npm` |\n`src/platform/packages/private/kbn-ui-shared-deps-npm` |\n| `@kbn/ui-shared-deps-src` |\n`src/platform/packages/private/kbn-ui-shared-deps-src` |\n| `@kbn/ui-theme` | `src/platform/packages/shared/kbn-ui-theme` |\n| `@kbn/utility-types-jest` |\n`src/platform/packages/shared/kbn-utility-types-jest` |\n| `@kbn/utils` | `src/platform/packages/shared/kbn-utils` |\n\n\n<details >\n<summary>Updated references</summary>\n\n```\n./kbn_pm/src/lib/bazel.mjs\n./kbn_pm/src/lib/external_packages.js\n./package.json\n./packages/core/rendering/core-rendering-server-internal/src/bootstrap/get_theme_tag.ts\n./packages/kbn-babel-register/BUILD.bazel\n./packages/kbn-eslint-plugin-imports/src/helpers/groups.ts\n./packages/kbn-monaco/BUILD.bazel\n./packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts\n./packages/kbn-repo-packages/package-map.json\n./packages/kbn-ts-projects/config-paths.json\n./packages/kbn-ui-shared-deps-npm/BUILD.bazel\n./packages/kbn-ui-shared-deps-src/BUILD.bazel\n./src/dev/build/tasks/build_packages_task.ts\n./src/platform/packages/private/kbn-repo-packages/jest.config.js\n./src/platform/packages/private/kbn-repo-packages/package-map.json\n./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel\n./src/platform/packages/shared/kbn-cbor/jest.config.js\n./src/platform/packages/shared/kbn-repo-info/jest.config.js\n./src/platform/packages/shared/kbn-rison/jest.config.js\n./src/platform/packages/shared/kbn-utils/jest.config.js\n./tsconfig.base.json\n./yarn.lock\n.github/CODEOWNERS\n```\n\n</details><details >\n<summary>Updated relative paths</summary>\n\n```\nsrc/platform/packages/private/kbn-repo-packages/jest.config.js:12\nsrc/platform/packages/private/kbn-repo-packages/tsconfig.json:2\nsrc/platform/packages/private/kbn-ui-shared-deps-npm/tsconfig.json:2\nsrc/platform/packages/private/kbn-ui-shared-deps-src/tsconfig.json:2\nsrc/platform/packages/shared/kbn-cbor/jest.config.js:12\nsrc/platform/packages/shared/kbn-cbor/tsconfig.json:12\nsrc/platform/packages/shared/kbn-cbor/tsconfig.json:2\nsrc/platform/packages/shared/kbn-repo-info/jest.config.js:12\nsrc/platform/packages/shared/kbn-repo-info/tsconfig.json:2\nsrc/platform/packages/shared/kbn-rison/jest.config.js:12\nsrc/platform/packages/shared/kbn-rison/tsconfig.json:2\nsrc/platform/packages/shared/kbn-ui-theme/tsconfig.json:2\nsrc/platform/packages/shared/kbn-utility-types-jest/tsconfig.json:2\nsrc/platform/packages/shared/kbn-utils/jest.config.js:12\nsrc/platform/packages/shared/kbn-utils/tsconfig.json:2\n```\n\n</details>\n\n---------\n\nCo-authored-by: Alex Szabo <[email protected]>\nCo-authored-by: Jonathan Budzenski <[email protected]>\nCo-authored-by: Michael Dokolin <[email protected]>","sha":"6a25db96053ae5dd39a7f2d4c4ac27182fd92bc4","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Core","Team:Operations","release_note:skip","v9.0.0","backport:version","v8.18.0","plugin groups"],"number":202739,"url":"https://github.com/elastic/kibana/pull/202739","mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-operations` (#202739)\n\n## Summary\n\nThis PR aims at relocating some of the Kibana modules (plugins and\npackages) into a new folder structure, according to the _Sustainable\nKibana Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you to:\n> * Manually fix the errors in the error section below (if there are\nany).\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config files), and update them\nappropriately.\n> * Manually review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\nany CI pipeline customizations continue to be correctly applied after\nthe changed path names\n> * Review all of the updated files, specially the `.ts` and `.js` files\nlisted in the sections below, as some of them contain relative paths\nthat have been updated.\n> * Think of potential impact of the move, including tooling and\nconfiguration files that can be pointing to the relocated modules. E.g.:\n> * customised eslint rules\n> * docs pointing to source code\n\n> [!NOTE]\n> * This PR has been auto-generated.\n> * Any manual contributions will be lost if the 'relocate' script is\nre-run.\n> * Try to obtain the missing reviews / approvals before applying manual\nfixes, and/or keep your changes in a .patch / git stash.\n> * Please use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack channel for feedback.\n\nAre you trying to rebase this PR to solve merge conflicts? Please follow\nthe steps describe\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\n\n#### 9 packages(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/cbor` | `src/platform/packages/shared/kbn-cbor` |\n| `@kbn/repo-info` | `src/platform/packages/shared/kbn-repo-info` |\n| `@kbn/repo-packages` |\n`src/platform/packages/private/kbn-repo-packages` |\n| `@kbn/rison` | `src/platform/packages/shared/kbn-rison` |\n| `@kbn/ui-shared-deps-npm` |\n`src/platform/packages/private/kbn-ui-shared-deps-npm` |\n| `@kbn/ui-shared-deps-src` |\n`src/platform/packages/private/kbn-ui-shared-deps-src` |\n| `@kbn/ui-theme` | `src/platform/packages/shared/kbn-ui-theme` |\n| `@kbn/utility-types-jest` |\n`src/platform/packages/shared/kbn-utility-types-jest` |\n| `@kbn/utils` | `src/platform/packages/shared/kbn-utils` |\n\n\n<details >\n<summary>Updated references</summary>\n\n```\n./kbn_pm/src/lib/bazel.mjs\n./kbn_pm/src/lib/external_packages.js\n./package.json\n./packages/core/rendering/core-rendering-server-internal/src/bootstrap/get_theme_tag.ts\n./packages/kbn-babel-register/BUILD.bazel\n./packages/kbn-eslint-plugin-imports/src/helpers/groups.ts\n./packages/kbn-monaco/BUILD.bazel\n./packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts\n./packages/kbn-repo-packages/package-map.json\n./packages/kbn-ts-projects/config-paths.json\n./packages/kbn-ui-shared-deps-npm/BUILD.bazel\n./packages/kbn-ui-shared-deps-src/BUILD.bazel\n./src/dev/build/tasks/build_packages_task.ts\n./src/platform/packages/private/kbn-repo-packages/jest.config.js\n./src/platform/packages/private/kbn-repo-packages/package-map.json\n./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel\n./src/platform/packages/shared/kbn-cbor/jest.config.js\n./src/platform/packages/shared/kbn-repo-info/jest.config.js\n./src/platform/packages/shared/kbn-rison/jest.config.js\n./src/platform/packages/shared/kbn-utils/jest.config.js\n./tsconfig.base.json\n./yarn.lock\n.github/CODEOWNERS\n```\n\n</details><details >\n<summary>Updated relative paths</summary>\n\n```\nsrc/platform/packages/private/kbn-repo-packages/jest.config.js:12\nsrc/platform/packages/private/kbn-repo-packages/tsconfig.json:2\nsrc/platform/packages/private/kbn-ui-shared-deps-npm/tsconfig.json:2\nsrc/platform/packages/private/kbn-ui-shared-deps-src/tsconfig.json:2\nsrc/platform/packages/shared/kbn-cbor/jest.config.js:12\nsrc/platform/packages/shared/kbn-cbor/tsconfig.json:12\nsrc/platform/packages/shared/kbn-cbor/tsconfig.json:2\nsrc/platform/packages/shared/kbn-repo-info/jest.config.js:12\nsrc/platform/packages/shared/kbn-repo-info/tsconfig.json:2\nsrc/platform/packages/shared/kbn-rison/jest.config.js:12\nsrc/platform/packages/shared/kbn-rison/tsconfig.json:2\nsrc/platform/packages/shared/kbn-ui-theme/tsconfig.json:2\nsrc/platform/packages/shared/kbn-utility-types-jest/tsconfig.json:2\nsrc/platform/packages/shared/kbn-utils/jest.config.js:12\nsrc/platform/packages/shared/kbn-utils/tsconfig.json:2\n```\n\n</details>\n\n---------\n\nCo-authored-by: Alex Szabo <[email protected]>\nCo-authored-by: Jonathan Budzenski <[email protected]>\nCo-authored-by: Michael Dokolin <[email protected]>","sha":"6a25db96053ae5dd39a7f2d4c4ac27182fd92bc4"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202739","number":202739,"mergeCommit":{"message":"Sustainable Kibana Architecture: Move modules owned by `@elastic/kibana-operations` (#202739)\n\n## Summary\n\nThis PR aims at relocating some of the Kibana modules (plugins and\npackages) into a new folder structure, according to the _Sustainable\nKibana Architecture_ initiative.\n\n> [!IMPORTANT]\n> * We kindly ask you to:\n> * Manually fix the errors in the error section below (if there are\nany).\n> * Search for the `packages[\\/\\\\]` and `plugins[\\/\\\\]` patterns in the\nsource code (Babel and Eslint config files), and update them\nappropriately.\n> * Manually review\n`.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that\nany CI pipeline customizations continue to be correctly applied after\nthe changed path names\n> * Review all of the updated files, specially the `.ts` and `.js` files\nlisted in the sections below, as some of them contain relative paths\nthat have been updated.\n> * Think of potential impact of the move, including tooling and\nconfiguration files that can be pointing to the relocated modules. E.g.:\n> * customised eslint rules\n> * docs pointing to source code\n\n> [!NOTE]\n> * This PR has been auto-generated.\n> * Any manual contributions will be lost if the 'relocate' script is\nre-run.\n> * Try to obtain the missing reviews / approvals before applying manual\nfixes, and/or keep your changes in a .patch / git stash.\n> * Please use\n[#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E)\nSlack channel for feedback.\n\nAre you trying to rebase this PR to solve merge conflicts? Please follow\nthe steps describe\n[here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E).\n\n#### 9 packages(s) are going to be relocated:\n\n| Id | Target folder |\n| -- | ------------- |\n| `@kbn/cbor` | `src/platform/packages/shared/kbn-cbor` |\n| `@kbn/repo-info` | `src/platform/packages/shared/kbn-repo-info` |\n| `@kbn/repo-packages` |\n`src/platform/packages/private/kbn-repo-packages` |\n| `@kbn/rison` | `src/platform/packages/shared/kbn-rison` |\n| `@kbn/ui-shared-deps-npm` |\n`src/platform/packages/private/kbn-ui-shared-deps-npm` |\n| `@kbn/ui-shared-deps-src` |\n`src/platform/packages/private/kbn-ui-shared-deps-src` |\n| `@kbn/ui-theme` | `src/platform/packages/shared/kbn-ui-theme` |\n| `@kbn/utility-types-jest` |\n`src/platform/packages/shared/kbn-utility-types-jest` |\n| `@kbn/utils` | `src/platform/packages/shared/kbn-utils` |\n\n\n<details >\n<summary>Updated references</summary>\n\n```\n./kbn_pm/src/lib/bazel.mjs\n./kbn_pm/src/lib/external_packages.js\n./package.json\n./packages/core/rendering/core-rendering-server-internal/src/bootstrap/get_theme_tag.ts\n./packages/kbn-babel-register/BUILD.bazel\n./packages/kbn-eslint-plugin-imports/src/helpers/groups.ts\n./packages/kbn-monaco/BUILD.bazel\n./packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts\n./packages/kbn-repo-packages/package-map.json\n./packages/kbn-ts-projects/config-paths.json\n./packages/kbn-ui-shared-deps-npm/BUILD.bazel\n./packages/kbn-ui-shared-deps-src/BUILD.bazel\n./src/dev/build/tasks/build_packages_task.ts\n./src/platform/packages/private/kbn-repo-packages/jest.config.js\n./src/platform/packages/private/kbn-repo-packages/package-map.json\n./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel\n./src/platform/packages/shared/kbn-cbor/jest.config.js\n./src/platform/packages/shared/kbn-repo-info/jest.config.js\n./src/platform/packages/shared/kbn-rison/jest.config.js\n./src/platform/packages/shared/kbn-utils/jest.config.js\n./tsconfig.base.json\n./yarn.lock\n.github/CODEOWNERS\n```\n\n</details><details >\n<summary>Updated relative paths</summary>\n\n```\nsrc/platform/packages/private/kbn-repo-packages/jest.config.js:12\nsrc/platform/packages/private/kbn-repo-packages/tsconfig.json:2\nsrc/platform/packages/private/kbn-ui-shared-deps-npm/tsconfig.json:2\nsrc/platform/packages/private/kbn-ui-shared-deps-src/tsconfig.json:2\nsrc/platform/packages/shared/kbn-cbor/jest.config.js:12\nsrc/platform/packages/shared/kbn-cbor/tsconfig.json:12\nsrc/platform/packages/shared/kbn-cbor/tsconfig.json:2\nsrc/platform/packages/shared/kbn-repo-info/jest.config.js:12\nsrc/platform/packages/shared/kbn-repo-info/tsconfig.json:2\nsrc/platform/packages/shared/kbn-rison/jest.config.js:12\nsrc/platform/packages/shared/kbn-rison/tsconfig.json:2\nsrc/platform/packages/shared/kbn-ui-theme/tsconfig.json:2\nsrc/platform/packages/shared/kbn-utility-types-jest/tsconfig.json:2\nsrc/platform/packages/shared/kbn-utils/jest.config.js:12\nsrc/platform/packages/shared/kbn-utils/tsconfig.json:2\n```\n\n</details>\n\n---------\n\nCo-authored-by: Alex Szabo <[email protected]>\nCo-authored-by: Jonathan Budzenski <[email protected]>\nCo-authored-by: Michael Dokolin <[email protected]>","sha":"6a25db96053ae5dd39a7f2d4c4ac27182fd92bc4"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Gerard Soldevila <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…na-operations` (elastic#202739) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 9 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cbor` | `src/platform/packages/shared/kbn-cbor` | | `@kbn/repo-info` | `src/platform/packages/shared/kbn-repo-info` | | `@kbn/repo-packages` | `src/platform/packages/private/kbn-repo-packages` | | `@kbn/rison` | `src/platform/packages/shared/kbn-rison` | | `@kbn/ui-shared-deps-npm` | `src/platform/packages/private/kbn-ui-shared-deps-npm` | | `@kbn/ui-shared-deps-src` | `src/platform/packages/private/kbn-ui-shared-deps-src` | | `@kbn/ui-theme` | `src/platform/packages/shared/kbn-ui-theme` | | `@kbn/utility-types-jest` | `src/platform/packages/shared/kbn-utility-types-jest` | | `@kbn/utils` | `src/platform/packages/shared/kbn-utils` | <details > <summary>Updated references</summary> ``` ./kbn_pm/src/lib/bazel.mjs ./kbn_pm/src/lib/external_packages.js ./package.json ./packages/core/rendering/core-rendering-server-internal/src/bootstrap/get_theme_tag.ts ./packages/kbn-babel-register/BUILD.bazel ./packages/kbn-eslint-plugin-imports/src/helpers/groups.ts ./packages/kbn-monaco/BUILD.bazel ./packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-ui-shared-deps-npm/BUILD.bazel ./packages/kbn-ui-shared-deps-src/BUILD.bazel ./src/dev/build/tasks/build_packages_task.ts ./src/platform/packages/private/kbn-repo-packages/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-cbor/jest.config.js ./src/platform/packages/shared/kbn-repo-info/jest.config.js ./src/platform/packages/shared/kbn-rison/jest.config.js ./src/platform/packages/shared/kbn-utils/jest.config.js ./tsconfig.base.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-repo-packages/jest.config.js:12 src/platform/packages/private/kbn-repo-packages/tsconfig.json:2 src/platform/packages/private/kbn-ui-shared-deps-npm/tsconfig.json:2 src/platform/packages/private/kbn-ui-shared-deps-src/tsconfig.json:2 src/platform/packages/shared/kbn-cbor/jest.config.js:12 src/platform/packages/shared/kbn-cbor/tsconfig.json:12 src/platform/packages/shared/kbn-cbor/tsconfig.json:2 src/platform/packages/shared/kbn-repo-info/jest.config.js:12 src/platform/packages/shared/kbn-repo-info/tsconfig.json:2 src/platform/packages/shared/kbn-rison/jest.config.js:12 src/platform/packages/shared/kbn-rison/tsconfig.json:2 src/platform/packages/shared/kbn-ui-theme/tsconfig.json:2 src/platform/packages/shared/kbn-utility-types-jest/tsconfig.json:2 src/platform/packages/shared/kbn-utils/jest.config.js:12 src/platform/packages/shared/kbn-utils/tsconfig.json:2 ``` </details> --------- Co-authored-by: Alex Szabo <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]> Co-authored-by: Michael Dokolin <[email protected]>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…na-operations` (elastic#202739) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 9 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cbor` | `src/platform/packages/shared/kbn-cbor` | | `@kbn/repo-info` | `src/platform/packages/shared/kbn-repo-info` | | `@kbn/repo-packages` | `src/platform/packages/private/kbn-repo-packages` | | `@kbn/rison` | `src/platform/packages/shared/kbn-rison` | | `@kbn/ui-shared-deps-npm` | `src/platform/packages/private/kbn-ui-shared-deps-npm` | | `@kbn/ui-shared-deps-src` | `src/platform/packages/private/kbn-ui-shared-deps-src` | | `@kbn/ui-theme` | `src/platform/packages/shared/kbn-ui-theme` | | `@kbn/utility-types-jest` | `src/platform/packages/shared/kbn-utility-types-jest` | | `@kbn/utils` | `src/platform/packages/shared/kbn-utils` | <details > <summary>Updated references</summary> ``` ./kbn_pm/src/lib/bazel.mjs ./kbn_pm/src/lib/external_packages.js ./package.json ./packages/core/rendering/core-rendering-server-internal/src/bootstrap/get_theme_tag.ts ./packages/kbn-babel-register/BUILD.bazel ./packages/kbn-eslint-plugin-imports/src/helpers/groups.ts ./packages/kbn-monaco/BUILD.bazel ./packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-ui-shared-deps-npm/BUILD.bazel ./packages/kbn-ui-shared-deps-src/BUILD.bazel ./src/dev/build/tasks/build_packages_task.ts ./src/platform/packages/private/kbn-repo-packages/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-cbor/jest.config.js ./src/platform/packages/shared/kbn-repo-info/jest.config.js ./src/platform/packages/shared/kbn-rison/jest.config.js ./src/platform/packages/shared/kbn-utils/jest.config.js ./tsconfig.base.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-repo-packages/jest.config.js:12 src/platform/packages/private/kbn-repo-packages/tsconfig.json:2 src/platform/packages/private/kbn-ui-shared-deps-npm/tsconfig.json:2 src/platform/packages/private/kbn-ui-shared-deps-src/tsconfig.json:2 src/platform/packages/shared/kbn-cbor/jest.config.js:12 src/platform/packages/shared/kbn-cbor/tsconfig.json:12 src/platform/packages/shared/kbn-cbor/tsconfig.json:2 src/platform/packages/shared/kbn-repo-info/jest.config.js:12 src/platform/packages/shared/kbn-repo-info/tsconfig.json:2 src/platform/packages/shared/kbn-rison/jest.config.js:12 src/platform/packages/shared/kbn-rison/tsconfig.json:2 src/platform/packages/shared/kbn-ui-theme/tsconfig.json:2 src/platform/packages/shared/kbn-utility-types-jest/tsconfig.json:2 src/platform/packages/shared/kbn-utils/jest.config.js:12 src/platform/packages/shared/kbn-utils/tsconfig.json:2 ``` </details> --------- Co-authored-by: Alex Szabo <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]> Co-authored-by: Michael Dokolin <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
…na-operations` (elastic#202739) ## Summary This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). #### 9 packages(s) are going to be relocated: | Id | Target folder | | -- | ------------- | | `@kbn/cbor` | `src/platform/packages/shared/kbn-cbor` | | `@kbn/repo-info` | `src/platform/packages/shared/kbn-repo-info` | | `@kbn/repo-packages` | `src/platform/packages/private/kbn-repo-packages` | | `@kbn/rison` | `src/platform/packages/shared/kbn-rison` | | `@kbn/ui-shared-deps-npm` | `src/platform/packages/private/kbn-ui-shared-deps-npm` | | `@kbn/ui-shared-deps-src` | `src/platform/packages/private/kbn-ui-shared-deps-src` | | `@kbn/ui-theme` | `src/platform/packages/shared/kbn-ui-theme` | | `@kbn/utility-types-jest` | `src/platform/packages/shared/kbn-utility-types-jest` | | `@kbn/utils` | `src/platform/packages/shared/kbn-utils` | <details > <summary>Updated references</summary> ``` ./kbn_pm/src/lib/bazel.mjs ./kbn_pm/src/lib/external_packages.js ./package.json ./packages/core/rendering/core-rendering-server-internal/src/bootstrap/get_theme_tag.ts ./packages/kbn-babel-register/BUILD.bazel ./packages/kbn-eslint-plugin-imports/src/helpers/groups.ts ./packages/kbn-monaco/BUILD.bazel ./packages/kbn-plugin-helpers/src/tasks/bazel_packages.ts ./packages/kbn-repo-packages/package-map.json ./packages/kbn-ts-projects/config-paths.json ./packages/kbn-ui-shared-deps-npm/BUILD.bazel ./packages/kbn-ui-shared-deps-src/BUILD.bazel ./src/dev/build/tasks/build_packages_task.ts ./src/platform/packages/private/kbn-repo-packages/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/private/kbn-ui-shared-deps-src/BUILD.bazel ./src/platform/packages/shared/kbn-cbor/jest.config.js ./src/platform/packages/shared/kbn-repo-info/jest.config.js ./src/platform/packages/shared/kbn-rison/jest.config.js ./src/platform/packages/shared/kbn-utils/jest.config.js ./tsconfig.base.json ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/platform/packages/private/kbn-repo-packages/jest.config.js:12 src/platform/packages/private/kbn-repo-packages/tsconfig.json:2 src/platform/packages/private/kbn-ui-shared-deps-npm/tsconfig.json:2 src/platform/packages/private/kbn-ui-shared-deps-src/tsconfig.json:2 src/platform/packages/shared/kbn-cbor/jest.config.js:12 src/platform/packages/shared/kbn-cbor/tsconfig.json:12 src/platform/packages/shared/kbn-cbor/tsconfig.json:2 src/platform/packages/shared/kbn-repo-info/jest.config.js:12 src/platform/packages/shared/kbn-repo-info/tsconfig.json:2 src/platform/packages/shared/kbn-rison/jest.config.js:12 src/platform/packages/shared/kbn-rison/tsconfig.json:2 src/platform/packages/shared/kbn-ui-theme/tsconfig.json:2 src/platform/packages/shared/kbn-utility-types-jest/tsconfig.json:2 src/platform/packages/shared/kbn-utils/jest.config.js:12 src/platform/packages/shared/kbn-utils/tsconfig.json:2 ``` </details> --------- Co-authored-by: Alex Szabo <[email protected]> Co-authored-by: Jonathan Budzenski <[email protected]> Co-authored-by: Michael Dokolin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.
Important
packages[\/\\]andplugins[\/\\]patterns in the source code (Babel and Eslint config files), and update them appropriately..buildkite/scripts/pipelines/pull_request/pipeline.tsto ensure that any CI pipeline customizations continue to be correctly applied after the changed path names.tsand.jsfiles listed in the sections below, as some of them contain relative paths that have been updated.Note
Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.
9 packages(s) are going to be relocated:
@kbn/cborsrc/platform/packages/shared/kbn-cbor@kbn/repo-infosrc/platform/packages/shared/kbn-repo-info@kbn/repo-packagessrc/platform/packages/private/kbn-repo-packages@kbn/risonsrc/platform/packages/shared/kbn-rison@kbn/ui-shared-deps-npmsrc/platform/packages/private/kbn-ui-shared-deps-npm@kbn/ui-shared-deps-srcsrc/platform/packages/private/kbn-ui-shared-deps-src@kbn/ui-themesrc/platform/packages/shared/kbn-ui-theme@kbn/utility-types-jestsrc/platform/packages/shared/kbn-utility-types-jest@kbn/utilssrc/platform/packages/shared/kbn-utilsUpdated references
Updated relative paths