Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[One Discover] Restore alerts search rule on obs contextual experience #203113

Closed
tonyghiani opened this issue Dec 5, 2024 · 2 comments · Fixed by #204755
Closed

[One Discover] Restore alerts search rule on obs contextual experience #203113

tonyghiani opened this issue Dec 5, 2024 · 2 comments · Fixed by #204755
Assignees
@jughosta
Labels
Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team

Comments

@tonyghiani
Copy link
Contributor

📓 Summary

The changes made in #198987 to customize the app menu in the contextual environment replaced the default search rule with a custom threshold rule for the O11y context.

This has no support for ES|QL editors, which seems off compared to previous behaviour.

We want to add the search rule back among the custom threshold one to let the user decide which best suits the need.

✔ Acceptance criteria

  • The search rule should be displayed as the first item in the alerts sub-menu.
@tonyghiani tonyghiani added Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team labels Dec 5, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@davismcphee davismcphee added Feature:Discover Discover Application loe:small Small Level of Effort impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. labels Dec 5, 2024
@jughosta jughosta mentioned this issue Dec 18, 2024
Merged
jughosta added a commit that referenced this issue Jan 24, 2025
@jughosta @davismcphee
[Discover] Restore the default Discover alert action for Observabilit…
407a42d 
…y profile (#204755)

- Closes #203113

## Summary

Previously in Observability profile "Create custom threshold rule"
action replaced the "Create search threshold rule" action. With this PR,
both actions will be available.

<img width="611" alt="Screenshot 2024-12-18 at 14 12 39"
src="https://github.com/user-attachments/assets/ad24194a-92cb-41a3-b6b3-f9d8bf6be314"
/>

---------

Co-authored-by: Davis McPhee <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 24, 2025
@jughosta
[Discover] Restore the default Discover alert action for Observabilit…
f9fe0b5 
…y profile (elastic#204755)

- Closes elastic#203113

## Summary

Previously in Observability profile "Create custom threshold rule"
action replaced the "Create search threshold rule" action. With this PR,
both actions will be available.

<img width="611" alt="Screenshot 2024-12-18 at 14 12 39"
src="https://github.com/user-attachments/assets/ad24194a-92cb-41a3-b6b3-f9d8bf6be314"
/>

---------

Co-authored-by: Davis McPhee <[email protected]>
(cherry picked from commit 407a42d)
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this issue Jan 27, 2025
@jughosta @davismcphee @JoseLuisGJ
[Discover] Restore the default Discover alert action for Observabilit…
d90eff6 
…y profile (elastic#204755)

- Closes elastic#203113

## Summary

Previously in Observability profile "Create custom threshold rule"
action replaced the "Create search threshold rule" action. With this PR,
both actions will be available.

<img width="611" alt="Screenshot 2024-12-18 at 14 12 39"
src="https://github.com/user-attachments/assets/ad24194a-92cb-41a3-b6b3-f9d8bf6be314"
/>

---------

Co-authored-by: Davis McPhee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jughosta jughosta

Labels
Feature:Discover Discover Application impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:OneDiscover Enrich Discover with contextual awareness Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Discover] Restore the default Discover alert action for Observability profile jughosta/kibana
4 participants
@jughosta @elasticmachine @davismcphee @tonyghiani