Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Meta] Audit createPointInTimeFinder usage in core code #203144

Closed
TinaHeiligers opened this issue Dec 5, 2024 · 1 comment
Closed

[Meta] Audit createPointInTimeFinder usage in core code #203144

TinaHeiligers opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
chore Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Dec 5, 2024

Part of #203017
Audit core code for createPointInTimeFinder() usage where all results are loaded in memory

Code Line # Line # Line # Team Verified? Issue (if needed)/comments
src/plugins/ftr_apis/server/routes/kbn_client_so/clean.ts 33 @elastic/kibana-core Yes
src/plugins/kibana_usage_collection/server/collectors/application_usage/telemetry_application_usage_collector.ts 72 110 @elastic/kibana-core Yes doesn't store everything in memory
src/plugins/kibana_usage_collection/server/collectors/application_usage/rollups/total.ts 32 55 @elastic/kibana-core Yes doesn't store everything in memory
src/plugins/kibana_usage_collection/server/collectors/common/counters.ts 34 @elastic/kibana-core Yes Uses paginated find with targeted search fields #204676
src/plugins/kibana_usage_collection/server/collectors/ui_metric/telemetry_ui_metric_collector.ts 52 @elastic/kibana-core Yes doesn't store everything in memory
packages/core/saved-objects/core-saved-objects-api-server/src/saved_objects_client.ts 378 (ts doc example) 393 (SO client type definition) @elastic/kibana-core Yes
packages/core/saved-objects/core-saved-objects-api-server/src/saved_objects_repository.ts 530 (ts doc example) 541 (repository api type definition) @elastic/kibana-core yes
packages/core/saved-objects/core-saved-objects-api-server-internal/src/saved_objects_client.ts 181 (core SO repository API) 185 (core SO repository API) @elastic/kibana-core Yes
packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/repository.ts 548 (Core SO PIT implementation, passthrough) @elastic/kibana-core Yes
packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/apis/internals/find_legacy_url_aliases.ts 38 (aggregates results & closes PIT) @elastic/kibana-core Yes
packages/core/saved-objects/core-saved-objects-api-server-internal/src/lib/apis/utils/find_shared_origin_objects.ts 48 (aggregates) @elastic/kibana-core Yes
packages/core/saved-objects/core-saved-objects-import-export-server-internal/src/export/saved_objects_exporter.ts 159 @elastic/kibana-core Yes
@TinaHeiligers TinaHeiligers added chore Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Dec 5, 2024
@TinaHeiligers TinaHeiligers self-assigned this Dec 9, 2024
@TinaHeiligers
Copy link
Contributor Author

Audit complete with no findings of inefficient use

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Meta Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

1 participant