Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Allow readonly user to access /agent_policies_spaces API #203434

Merged
merged 5 commits into from
Dec 10, 2024

Conversation

nchaulet
Copy link
Member

@nchaulet nchaulet commented Dec 9, 2024

Summary

Resolve #193814

Fix permission to the /agent_policies_spaces API to allow read only user to access it

There was a delay displaying the space selector when an an user with readonly permission access the agent policy settings page, this was due to missing permissions and react query retrying the query.

That PR fix it by allowing user with readonly to access that API.

@nchaulet nchaulet added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Dec 9, 2024
@nchaulet nchaulet self-assigned this Dec 9, 2024
@nchaulet nchaulet requested a review from a team as a code owner December 9, 2024 14:04
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@nchaulet
Copy link
Member Author

nchaulet commented Dec 9, 2024

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Dec 9, 2024

@elasticmachine merge upstream

@nchaulet
Copy link
Member Author

nchaulet commented Dec 9, 2024

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 9, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #55 / Observability AI Assistant API tests public_complete/public_complete.spec.ts /api/observability_ai_assistant/chat/complete after executing an action closes the stream without persisting the conversation
  • [job] [logs] FTR Configs #32 / serverless search UI connectors connector table confirm searchBar to exist
  • [job] [logs] FTR Configs #32 / serverless search UI connectors connector table confirm searchBar to exist

Metrics [docs]

✅ unchanged

History

cc @nchaulet

Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nchaulet
Copy link
Member Author

@elasticmachine merge upstream

@nchaulet nchaulet merged commit ebcbb0b into elastic:main Dec 10, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12258841205

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 10, 2024
#203434) (#203602)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] Allow readonly user to access /agent_policies_spaces API
(#203434)](#203434)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nicolas
Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:00:50Z","message":"[Fleet]
Allow readonly user to access /agent_policies_spaces API
(#203434)","sha":"ebcbb0b26e2a9bc947af3aac7d972c7537635ca0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
Allow readonly user to access /agent_policies_spaces
API","number":203434,"url":"https://github.com/elastic/kibana/pull/203434","mergeCommit":{"message":"[Fleet]
Allow readonly user to access /agent_policies_spaces API
(#203434)","sha":"ebcbb0b26e2a9bc947af3aac7d972c7537635ca0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203434","number":203434,"mergeCommit":{"message":"[Fleet]
Allow readonly user to access /agent_policies_spaces API
(#203434)","sha":"ebcbb0b26e2a9bc947af3aac7d972c7537635ca0"}}]}]
BACKPORT-->

Co-authored-by: Nicolas Chaulet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.18.0 v9.0.0
Projects
None yet
4 participants