-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] Allow readonly user to access /agent_policies_spaces API #203434
[Fleet] Allow readonly user to access /agent_policies_spaces API #203434
Conversation
Pinging @elastic/fleet (Team:Fleet) |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
@elasticmachine merge upstream |
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History
cc @nchaulet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@elasticmachine merge upstream |
Starting backport for target branches: 8.x |
…stic#203434) (cherry picked from commit ebcbb0b)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
#203434) (#203602) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Allow readonly user to access /agent_policies_spaces API (#203434)](#203434) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-10T15:00:50Z","message":"[Fleet] Allow readonly user to access /agent_policies_spaces API (#203434)","sha":"ebcbb0b26e2a9bc947af3aac7d972c7537635ca0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Allow readonly user to access /agent_policies_spaces API","number":203434,"url":"https://github.com/elastic/kibana/pull/203434","mergeCommit":{"message":"[Fleet] Allow readonly user to access /agent_policies_spaces API (#203434)","sha":"ebcbb0b26e2a9bc947af3aac7d972c7537635ca0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203434","number":203434,"mergeCommit":{"message":"[Fleet] Allow readonly user to access /agent_policies_spaces API (#203434)","sha":"ebcbb0b26e2a9bc947af3aac7d972c7537635ca0"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <[email protected]>
Summary
Resolve #193814
Fix permission to the
/agent_policies_spaces
API to allow read only user to access itThere was a delay displaying the space selector when an an user with readonly permission access the agent policy settings page, this was due to missing permissions and react query retrying the query.
That PR fix it by allowing user with readonly to access that API.