[ML][UX]: Consistent Layout and UI Enhancements for ML Pages #203813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adcoelho
approved these changes
Dec 17, 2024
rbrtj
added
:ml
v9.0.0
Team:ML
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
changed the title
walterra
approved these changes
Dec 19, 2024
| @@ -90,10 +90,6 @@ interface DatePickerWrapperProps { | |||
| /** | |||
| * Boolean flag to set use of flex group wrapper | |||
| */ | |||
| flexGroup?: boolean; | |||
| /** | |||
There was a problem hiding this comment.
Looks like you accidentaly removed the comment for the next prop and not flexGroup.
There was a problem hiding this comment.
Good catch, done in: #d73ab5d
| /** | ||
| * Titles for the cases toast messages | ||
| */ | ||
| export const TITLES = { |
There was a problem hiding this comment.
Suggest to make this a bit more specific like CASES_TOAST_MESSAGES_TITLES.
There was a problem hiding this comment.
Agree, done in: #7f47fad
| /** | ||
| * Titles for the cases toast messages | ||
| */ | ||
| export const TITLES = { |
There was a problem hiding this comment.
Again, suggest to make this const more specific like CASES_TOAST_MESSAGES_TITLES.
peteharverson
approved these changes
Dec 19, 2024
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsasync chunk count
ESLint disabled line counts
Total ESLint disabled count
History
cc @rbrtj |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
2 tasks
kibanamachine
added
the
backport missing
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
4 similar comments
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
rbrtj
added a commit
to rbrtj/kibana
that referenced
this pull request
Dec 31, 2024
…#203813) ## Summary * Updated alignment for `Add to` action buttons across various ML pages - see: elastic#184109 * Fixed the overflowing date picker on `Anomaly Detection` pages - see: [elastic#204394](elastic#204394) * Standardized gaps around items on pages to maintain consistent values of `8px` (`gutterSize = 's'`) * Fixed the header on the Data Visualizer page - see: [elastic#204393](elastic#204393) * Adjusted the layout for Change Point Detection * Updated toast messages & toast action button - see: elastic#184109 * Added icons for attachments actions Exploration around new `Add to` actions buttons - the right column is the most recent one, see: elastic#184109 : | Before | After (add_to button) | After (icon button) - current | | ------------- | ------------- | ------------- | |  |  |  | |  |  |  | |  |  |  | |  |  |  | |  |  |  | Toasts: | Before | After | | ------ | ------ | | <img width="376" alt="image" src="https://github.com/user-attachments/assets/c58000c2-30d4-4312-be53-0e3e9a6e3ae6" /> |  | Other changes: | Before | After | | ------ | ------ | |  |  | |  |  | |  |  | |  |  | |  |  | |  |  | | <img width="342" alt="image" src="https://github.com/user-attachments/assets/6529eebe-510e-4688-81e6-4cf3e880c610" /> | <img width="323" alt="image" src="https://github.com/user-attachments/assets/6dada83e-252f-45d5-95d2-a03fa856d70a" /> | - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit 0cc887b) # Conflicts: # x-pack/platform/plugins/private/data_visualizer/public/application/index_data_visualizer/components/index_data_visualizer_view/index_data_visualizer_view.tsx
|
Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync. |
stratoula
pushed a commit
to stratoula/kibana
that referenced
this pull request
Jan 2, 2025
…#203813) ## Summary * Updated alignment for `Add to` action buttons across various ML pages - see: elastic#184109 * Fixed the overflowing date picker on `Anomaly Detection` pages - see: [elastic#204394](elastic#204394) * Standardized gaps around items on pages to maintain consistent values of `8px` (`gutterSize = 's'`) * Fixed the header on the Data Visualizer page - see: [elastic#204393](elastic#204393) * Adjusted the layout for Change Point Detection * Updated toast messages & toast action button - see: elastic#184109 * Added icons for attachments actions Exploration around new `Add to` actions buttons - the right column is the most recent one, see: elastic#184109 : | Before | After (add_to button) | After (icon button) - current | | ------------- | ------------- | ------------- | |  |  |  | |  |  |  | |  |  |  | |  |  |  | |  |  |  | Toasts: | Before | After | | ------ | ------ | | <img width="376" alt="image" src="https://github.com/user-attachments/assets/c58000c2-30d4-4312-be53-0e3e9a6e3ae6" /> |  | Other changes: | Before | After | | ------ | ------ | |  |  | |  |  | |  |  | |  |  | |  |  | |  |  | | <img width="342" alt="image" src="https://github.com/user-attachments/assets/6529eebe-510e-4688-81e6-4cf3e880c610" /> | <img width="323" alt="image" src="https://github.com/user-attachments/assets/6dada83e-252f-45d5-95d2-a03fa856d70a" /> | - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: kibanamachine <[email protected]>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Jan 2, 2025
…#203813) ## Summary * Updated alignment for `Add to` action buttons across various ML pages - see: elastic#184109 * Fixed the overflowing date picker on `Anomaly Detection` pages - see: [elastic#204394](elastic#204394) * Standardized gaps around items on pages to maintain consistent values of `8px` (`gutterSize = 's'`) * Fixed the header on the Data Visualizer page - see: [elastic#204393](elastic#204393) * Adjusted the layout for Change Point Detection * Updated toast messages & toast action button - see: elastic#184109 * Added icons for attachments actions Exploration around new `Add to` actions buttons - the right column is the most recent one, see: elastic#184109 : | Before | After (add_to button) | After (icon button) - current | | ------------- | ------------- | ------------- | |  |  |  | |  |  |  | |  |  |  | |  |  |  | |  |  |  | Toasts: | Before | After | | ------ | ------ | | <img width="376" alt="image" src="https://github.com/user-attachments/assets/c58000c2-30d4-4312-be53-0e3e9a6e3ae6" /> |  | Other changes: | Before | After | | ------ | ------ | |  |  | |  |  | |  |  | |  |  | |  |  | |  |  | | <img width="342" alt="image" src="https://github.com/user-attachments/assets/6529eebe-510e-4688-81e6-4cf3e880c610" /> | <img width="323" alt="image" src="https://github.com/user-attachments/assets/6dada83e-252f-45d5-95d2-a03fa856d70a" /> | - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) --------- Co-authored-by: kibanamachine <[email protected]>
rbrtj
added a commit
that referenced
this pull request
Jan 2, 2025
…203813) (#205328) # Backport This will backport the following commits from `main` to `8.x`: - [[ML][UX]: Consistent Layout and UI Enhancements for ML Pages (#203813)](#203813) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Robert Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-23T10:56:12Z","message":"[ML][UX]: Consistent Layout and UI Enhancements for ML Pages (#203813)\n\n## Summary\n\n* Updated alignment for `Add to` action buttons across various ML pages\n- see: #184109\n* Fixed the overflowing date picker on `Anomaly Detection` pages - see:\n[#204394](https://github.com/elastic/kibana/issues/204394)\n* Standardized gaps around items on pages to maintain consistent values\nof `8px` (`gutterSize = 's'`)\n* Fixed the header on the Data Visualizer page - see:\n[#204393](https://github.com/elastic/kibana/issues/204393)\n* Adjusted the layout for Change Point Detection\n* Updated toast messages & toast action button - see: #184109\n* Added icons for attachments actions\n\nExploration around new `Add to` actions buttons - the right column is\nthe most recent one, see: #184109 :\n\n| Before | After (add_to button) | After (icon button) - current |\n| ------------- | ------------- | ------------- |\n| \n| \n| \n|\n| \n| \n| \n|\n| \n| \n|\n\n|\n| \n| \n| \n|\n| \n| \n|\n\n|\n\nToasts:\n| Before | After |\n| ------ | ------ | \n| <img width=\"376\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c58000c2-30d4-4312-be53-0e3e9a6e3ae6\"\n/> |\n\n|\n\n\n\nOther changes:\n\n| Before | After |\n| ------ | ------ | \n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| <img width=\"342\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/6529eebe-510e-4688-81e6-4cf3e880c610\"\n/> | <img width=\"323\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/6dada83e-252f-45d5-95d2-a03fa856d70a\"\n/> |\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"0cc887be92df434671ad37fe89cb4ebcc0d5af3d","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","backport missing","v9.0.0","Team:ML","backport:version","v8.18.0"],"number":203813,"url":"https://github.com/elastic/kibana/pull/203813","mergeCommit":{"message":"[ML][UX]: Consistent Layout and UI Enhancements for ML Pages (#203813)\n\n## Summary\n\n* Updated alignment for `Add to` action buttons across various ML pages\n- see: #184109\n* Fixed the overflowing date picker on `Anomaly Detection` pages - see:\n[#204394](https://github.com/elastic/kibana/issues/204394)\n* Standardized gaps around items on pages to maintain consistent values\nof `8px` (`gutterSize = 's'`)\n* Fixed the header on the Data Visualizer page - see:\n[#204393](https://github.com/elastic/kibana/issues/204393)\n* Adjusted the layout for Change Point Detection\n* Updated toast messages & toast action button - see: #184109\n* Added icons for attachments actions\n\nExploration around new `Add to` actions buttons - the right column is\nthe most recent one, see: #184109 :\n\n| Before | After (add_to button) | After (icon button) - current |\n| ------------- | ------------- | ------------- |\n| \n| \n| \n|\n| \n| \n| \n|\n| \n| \n|\n\n|\n| \n| \n| \n|\n| \n| \n|\n\n|\n\nToasts:\n| Before | After |\n| ------ | ------ | \n| <img width=\"376\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c58000c2-30d4-4312-be53-0e3e9a6e3ae6\"\n/> |\n\n|\n\n\n\nOther changes:\n\n| Before | After |\n| ------ | ------ | \n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| <img width=\"342\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/6529eebe-510e-4688-81e6-4cf3e880c610\"\n/> | <img width=\"323\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/6dada83e-252f-45d5-95d2-a03fa856d70a\"\n/> |\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"0cc887be92df434671ad37fe89cb4ebcc0d5af3d"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203813","number":203813,"mergeCommit":{"message":"[ML][UX]: Consistent Layout and UI Enhancements for ML Pages (#203813)\n\n## Summary\n\n* Updated alignment for `Add to` action buttons across various ML pages\n- see: #184109\n* Fixed the overflowing date picker on `Anomaly Detection` pages - see:\n[#204394](https://github.com/elastic/kibana/issues/204394)\n* Standardized gaps around items on pages to maintain consistent values\nof `8px` (`gutterSize = 's'`)\n* Fixed the header on the Data Visualizer page - see:\n[#204393](https://github.com/elastic/kibana/issues/204393)\n* Adjusted the layout for Change Point Detection\n* Updated toast messages & toast action button - see: #184109\n* Added icons for attachments actions\n\nExploration around new `Add to` actions buttons - the right column is\nthe most recent one, see: #184109 :\n\n| Before | After (add_to button) | After (icon button) - current |\n| ------------- | ------------- | ------------- |\n| \n| \n| \n|\n| \n| \n| \n|\n| \n| \n|\n\n|\n| \n| \n| \n|\n| \n| \n|\n\n|\n\nToasts:\n| Before | After |\n| ------ | ------ | \n| <img width=\"376\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/c58000c2-30d4-4312-be53-0e3e9a6e3ae6\"\n/> |\n\n|\n\n\n\nOther changes:\n\n| Before | After |\n| ------ | ------ | \n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| \n| \n|\n| <img width=\"342\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/6529eebe-510e-4688-81e6-4cf3e880c610\"\n/> | <img width=\"323\" alt=\"image\"\nsrc=\"https://github.com/user-attachments/assets/6dada83e-252f-45d5-95d2-a03fa856d70a\"\n/> |\n\n- [ ] Any text added follows [EUI's writing\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\nsentence case text and includes [i18n\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\n\n---------\n\nCo-authored-by: kibanamachine <[email protected]>","sha":"0cc887be92df434671ad37fe89cb4ebcc0d5af3d"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add toaction buttons across various ML pages - see: [ML][UX]: Updates to ML embeddable 'Add to' action #184109Anomaly Detectionpages - see: #2043948px(gutterSize = 's')Exploration around new
Add toactions buttons - the right column is the most recent one, see: #184109 :Toasts:
Other changes: