Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency @elastic/charts to v68.0.4 (main) #203955

Merged
merged 11 commits into from
Dec 19, 2024

Conversation

elastic-renovate-prod[bot]
Copy link
Contributor

@elastic-renovate-prod elastic-renovate-prod bot commented Dec 12, 2024

This PR contains the following updates:

Package Type Update Change
@elastic/charts dependencies patch 68.0.3 -> 68.0.4

This version of charts exports a helper function to correct an issue with the chart background color for the new Borealis theme. In addition to this we created a simplified hook useElasticChartsTheme from the @kbn/charts-theme package which reads the euiTheme.

-import { Chart, Settings, LIGHT_THEME, DARK_THEME } from '@elastic/charts';
+import { Chart, Settings } from '@elastic/charts';
-import { useEuiTheme } from '@elastic/eui';

+import { useElasticChartsTheme } from '@kbn/charts-theme';
 
 export function MyComponent() {
-  const euiTheme = useEuiTheme();
-  const baseTheme = euiTheme.colorMode === 'LIGHT' ? LIGHT_THEME : DARK_THEME;
+  const baseTheme = useElasticChartsTheme();
 
   return (
     <Chart>
       <Settings
         baseTheme={baseTheme}
         {/* ... */}
       />
       {/* ... */}
     </Chart>
   )
 }

Release Notes

elastic/elastic-charts (@​elastic/charts)

v68.0.4

Compare Source

Bug Fixes
Performance Improvements

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@elastic-renovate-prod elastic-renovate-prod bot added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Dec 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

@nickofthyme nickofthyme requested review from a team as code owners December 13, 2024 21:30
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Dec 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@nickofthyme
Copy link
Contributor

This version of charts exports a helper function to correct an issue with the chart background color for the new Borealis theme. In addition to this we created a simplified hook useElasticChartsTheme from the @kbn/charts-theme package which reads the euiTheme.

-import { Chart, Settings, LIGHT_THEME, DARK_THEME } from '@elastic/charts';
+import { Chart, Settings } from '@elastic/charts';
-import { useEuiTheme } from '@elastic/eui';

+import { useElasticChartsTheme } from '@kbn/charts-theme';
 
 export function MyComponent() {
-  const euiTheme = useEuiTheme();
-  const baseTheme = euiTheme.colorMode === 'LIGHT' ? LIGHT_THEME : DARK_THEME;
+  const baseTheme = useElasticChartsTheme();
 
   return (
     <Chart>
       <Settings
         baseTheme={baseTheme}
         {/* ... */}
       />
       {/* ... */}
     </Chart>
   )
 }

@nickofthyme nickofthyme requested review from a team as code owners December 13, 2024 21:42
@botelastic botelastic bot added the Team:obs-ux-management Observability Management User Experience Team label Dec 13, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elastic-renovate-prod
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@markov00 markov00 requested a review from a team as a code owner December 18, 2024 23:07
@elasticmachine
Copy link
Contributor

elasticmachine commented Dec 19, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #18 / FileNameLink renders clickable name if file is image

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1929 1930 +1
dashboard 694 695 +1
dataUsage 144 145 +1
eventAnnotationListing 637 638 +1
filesManagement 200 201 +1
graph 312 313 +1
infra 1544 1545 +1
maps 1265 1266 +1
ml 2138 2139 +1
observabilityAIAssistantApp 423 424 +1
observabilityShared 231 232 +1
securitySolution 6473 6474 +1
visualizations 493 494 +1
total +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 5.7MB 5.6MB -29.8KB
dashboard 667.7KB 667.8KB +85.0B
dataUsage 243.7KB 243.8KB +89.0B
eventAnnotationListing 232.2KB 232.3KB +84.0B
filesManagement 126.0KB 126.1KB +84.0B
graph 418.7KB 418.8KB +84.0B
infra 1.7MB 1.7MB +134.0B
maps 3.0MB 3.0MB +84.0B
ml 4.7MB 4.7MB -56.0B
observabilityAIAssistantApp 295.1KB 295.2KB +180.0B
securitySolution 21.4MB 21.4MB +84.0B
synthetics 1.1MB 1.1MB +180.0B
uptime 467.4KB 467.5KB +55.0B
visualizations 322.2KB 322.2KB +84.0B
total -28.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
apm 38.5KB 38.5KB +24.0B
kbnUiSharedDeps-npmDll 5.9MB 5.9MB +1.4KB
observabilityShared 93.9KB 94.0KB +64.0B
total +1.5KB
Unknown metric groups

API count

id before after diff
@kbn/charts-theme - 1 +1

async chunk count

id before after diff
apm 60 61 +1

History

Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared UX changes LGTM

Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared UX changes LGTM

@markov00 markov00 merged commit 841bf73 into main Dec 19, 2024
9 checks passed
@markov00 markov00 deleted the renovate/main-@elasticcharts branch December 19, 2024 17:34
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12417832935

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 203955

Questions ?

Please refer to the Backport tool documentation

JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Dec 19, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | patch | [`68.0.3` ->
`68.0.4`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/68.0.3/68.0.4)
|

This version of charts exports a helper function to correct an issue
with the chart background color for the new Borealis theme. In addition
to this we created a simplified hook `useElasticChartsTheme` from the
`@kbn/charts-theme` package which reads the `euiTheme`.


```diff
-import { Chart, Settings, LIGHT_THEME, DARK_THEME } from '@elastic/charts';
+import { Chart, Settings } from '@elastic/charts';
-import { useEuiTheme } from '@elastic/eui';

+import { useElasticChartsTheme } from '@kbn/charts-theme';
 
 export function MyComponent() {
-  const euiTheme = useEuiTheme();
-  const baseTheme = euiTheme.colorMode === 'LIGHT' ? LIGHT_THEME : DARK_THEME;
+  const baseTheme = useElasticChartsTheme();
 
   return (
     <Chart>
       <Settings
         baseTheme={baseTheme}
         {/* ... */}
       />
       {/* ... */}
     </Chart>
   )
 }
```


---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v68.0.4`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6804-2024-12-11)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v68.0.3...v68.0.4)

##### Bug Fixes

- **xy:** compute per series and global minPointsDistance
([#&elastic#8203;2571](https://togithub.com/elastic/elastic-charts/issues/2571))
([8dae2c1](https://togithub.com/elastic/elastic-charts/commit/8dae2c1f4c99146aa757b2d3eec9d72846248cc7))

##### Performance Improvements

- fix unnecessary re-render
([#&elastic#8203;2573](https://togithub.com/elastic/elastic-charts/issues/2573))
([feacfd6](https://togithub.com/elastic/elastic-charts/commit/feacfd6247b9580a8d32bc5d6284329b2035c1ba))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6cHJldi1taW5vciIsInJlbGVhc2Vfbm90ZTpza2lwIl19-->

---------

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: nickofthyme <[email protected]>
Co-authored-by: adcoelho <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 20, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

7 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

stratoula pushed a commit to stratoula/kibana that referenced this pull request Jan 2, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | patch | [`68.0.3` ->
`68.0.4`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/68.0.3/68.0.4)
|

This version of charts exports a helper function to correct an issue
with the chart background color for the new Borealis theme. In addition
to this we created a simplified hook `useElasticChartsTheme` from the
`@kbn/charts-theme` package which reads the `euiTheme`.


```diff
-import { Chart, Settings, LIGHT_THEME, DARK_THEME } from '@elastic/charts';
+import { Chart, Settings } from '@elastic/charts';
-import { useEuiTheme } from '@elastic/eui';

+import { useElasticChartsTheme } from '@kbn/charts-theme';
 
 export function MyComponent() {
-  const euiTheme = useEuiTheme();
-  const baseTheme = euiTheme.colorMode === 'LIGHT' ? LIGHT_THEME : DARK_THEME;
+  const baseTheme = useElasticChartsTheme();
 
   return (
     <Chart>
       <Settings
         baseTheme={baseTheme}
         {/* ... */}
       />
       {/* ... */}
     </Chart>
   )
 }
```


---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v68.0.4`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6804-2024-12-11)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v68.0.3...v68.0.4)

##### Bug Fixes

- **xy:** compute per series and global minPointsDistance
([#&elastic#8203;2571](https://togithub.com/elastic/elastic-charts/issues/2571))
([8dae2c1](https://togithub.com/elastic/elastic-charts/commit/8dae2c1f4c99146aa757b2d3eec9d72846248cc7))

##### Performance Improvements

- fix unnecessary re-render
([#&elastic#8203;2573](https://togithub.com/elastic/elastic-charts/issues/2573))
([feacfd6](https://togithub.com/elastic/elastic-charts/commit/feacfd6247b9580a8d32bc5d6284329b2035c1ba))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6cHJldi1taW5vciIsInJlbGVhc2Vfbm90ZTpza2lwIl19-->

---------

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: nickofthyme <[email protected]>
Co-authored-by: adcoelho <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
benakansara pushed a commit to benakansara/kibana that referenced this pull request Jan 2, 2025
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | patch | [`68.0.3` ->
`68.0.4`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/68.0.3/68.0.4)
|

This version of charts exports a helper function to correct an issue
with the chart background color for the new Borealis theme. In addition
to this we created a simplified hook `useElasticChartsTheme` from the
`@kbn/charts-theme` package which reads the `euiTheme`.


```diff
-import { Chart, Settings, LIGHT_THEME, DARK_THEME } from '@elastic/charts';
+import { Chart, Settings } from '@elastic/charts';
-import { useEuiTheme } from '@elastic/eui';

+import { useElasticChartsTheme } from '@kbn/charts-theme';
 
 export function MyComponent() {
-  const euiTheme = useEuiTheme();
-  const baseTheme = euiTheme.colorMode === 'LIGHT' ? LIGHT_THEME : DARK_THEME;
+  const baseTheme = useElasticChartsTheme();
 
   return (
     <Chart>
       <Settings
         baseTheme={baseTheme}
         {/* ... */}
       />
       {/* ... */}
     </Chart>
   )
 }
```


---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v68.0.4`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6804-2024-12-11)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v68.0.3...v68.0.4)

##### Bug Fixes

- **xy:** compute per series and global minPointsDistance
([#&elastic#8203;2571](https://togithub.com/elastic/elastic-charts/issues/2571))
([8dae2c1](https://togithub.com/elastic/elastic-charts/commit/8dae2c1f4c99146aa757b2d3eec9d72846248cc7))

##### Performance Improvements

- fix unnecessary re-render
([#&elastic#8203;2573](https://togithub.com/elastic/elastic-charts/issues/2573))
([feacfd6](https://togithub.com/elastic/elastic-charts/commit/feacfd6247b9580a8d32bc5d6284329b2035c1ba))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6cHJldi1taW5vciIsInJlbGVhc2Vfbm90ZTpza2lwIl19-->

---------

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: nickofthyme <[email protected]>
Co-authored-by: adcoelho <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 203955 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:Obs AI Assistant Observability AI Assistant Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team Team:Visualizations Visualization editors, elastic-charts and infrastructure v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.