Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection Engine] Verify if changes to saved query privileges in 9.0 can cause rule failures #204127

Open
marshallmain opened this issue Dec 12, 2024 · 6 comments
Assignees
Labels
Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@marshallmain
Copy link
Contributor

See https://github.com/elastic/dev/issues/2775#issuecomment-2387066863 - access to saved queries in 9.0 will change. We need to check to see if this can cause rule failures, and if so, what can we do to mitigate issues on upgrade.

@marshallmain marshallmain added Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area labels Dec 12, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@yctercero
Copy link
Contributor

@vitaliidm @marshallmain Ryland will take this one for 9.0.

@rylnd
Copy link
Contributor

rylnd commented Jan 10, 2025

@marshallmain @yctercero I did some cursory exploration here and I'm having trouble understanding how this fits into the broader effort described in https://github.com/elastic/dev/issues/2775:

  1. Are we defining new feature privileges, and a migration path for them? I reviewed e.g. [SecuritySolution] Breaking out timeline & note privileges #201780, which introduces new privileges for notes and timeline, but have not seen similar discussion/movement about rules privileges.
  2. As far as I can tell, we use the alerting-provided SavedObjects client to retrieve our saved query. I'll need to investigate further to answer:
    1. Whether this client is scoped to the current user
    2. Whether it respects a user's feature privileges, vs. e.g. a snapshot of ES privileges
    3. Whether it is dynamic with changes to feature privileges, and would e.g. be migrated automatically with the appropriate replacedBy declaration.

If either of you can help provide context for 1, I will continue to investigate 2.

@yctercero
Copy link
Contributor

From our discussion at team sync:

Are we defining new feature privileges, and a migration path for them? I reviewed e.g. #201780, which introduces new privileges for notes and timeline, but have not seen similar discussion/movement about rules privileges.

We are not updating our privileges in 8.x series. Planned changes are for 9.1+.

As far as I can tell, we use the alerting-provided SavedObjects client to retrieve our saved query. I'll need to investigate further to answer:

Discussed reaching out to alerting for this.

@rylnd
Copy link
Contributor

rylnd commented Jan 23, 2025

Quick update: this is still being discussed internally, but I've so far confirmed that feature privileges are encoded as part of a user/rule's API key. We're still collectively trying to figure out whether/how that works with the privilege migration/lifecycle mechanisms, and whether e.g. the savedObjectsClient will be able to leverage the replacedBy declaration for the outdated, encoded privilege(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

No branches or pull requests

6 participants