Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon #204286

Merged

Conversation

clintandrewhall
Copy link
Contributor

@clintandrewhall clintandrewhall commented Dec 13, 2024

A follow-up to #203879

Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc)

Note: the scaling of the icon/avatar before was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

@clintandrewhall clintandrewhall added review release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.18.0 labels Dec 13, 2024
@clintandrewhall clintandrewhall requested review from a team as code owners December 13, 2024 22:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@clintandrewhall clintandrewhall removed the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Dec 13, 2024
@clintandrewhall clintandrewhall requested review from joeypoon, parkiino and vitaliidm and removed request for joeypoon, parkiino and vitaliidm December 13, 2024 22:17
@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner December 13, 2024 22:37
@clintandrewhall clintandrewhall requested a review from a team as a code owner December 16, 2024 12:36
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Integration Assistant plugin

Copy link
Contributor

@vitaliidm vitaliidm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detection Engine area LGTM

@clintandrewhall clintandrewhall force-pushed the ai/assistant-logo-security branch from 08fdb43 to c8296b0 Compare December 18, 2024 15:51
@clintandrewhall clintandrewhall requested a review from a team as a code owner December 18, 2024 15:51
@clintandrewhall clintandrewhall force-pushed the ai/assistant-logo-security branch from b9235cf to 16e0ccd Compare December 31, 2024 19:16
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
integrationAssistant 466 470 +4
observabilityAIAssistant 118 117 -1
observabilityAIAssistantApp 419 418 -1
observabilityAiAssistantManagement 388 387 -1
searchAssistant 262 261 -1
securitySolution 6488 6485 -3
securitySolutionEss 117 122 +5
securitySolutionServerless 152 157 +5
total +7

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/elastic-assistant 145 144 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
integrationAssistant 877.6KB 878.3KB +733.0B
observabilityAIAssistantApp 294.0KB 294.0KB +5.0B
searchAssistant 163.4KB 163.2KB -177.0B
securitySolution 21.4MB 21.4MB +2.8KB
securitySolutionEss 62.1KB 64.6KB +2.4KB
securitySolutionServerless 133.2KB 135.6KB +2.4KB
total +8.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
@kbn/elastic-assistant 10 9 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observabilityAIAssistantApp 14.7KB 14.5KB -182.0B
securitySolutionServerless 26.4KB 26.4KB +1.0B
total -181.0B
Unknown metric groups

API count

id before after diff
@kbn/elastic-assistant 174 172 -2

async chunk count

id before after diff
integrationAssistant 2 3 +1
securitySolutionEss 4 5 +1
securitySolutionServerless 16 17 +1
total +3

References to deprecated APIs

id before after diff
@kbn/ecs-data-quality-dashboard 2 0 -2
integrationAssistant 4 0 -4
securitySolution 489 464 -25
total -31

History

Copy link
Contributor

@eokoneyo eokoneyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shared UX changes look good

Copy link
Member

@sphilipse sphilipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@szwarckonrad szwarckonrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DW changes LGTM!

@clintandrewhall clintandrewhall added v9.0.0 backport:version Backport to applied version labels backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting v9.0.0 backport:version Backport to applied version labels v8.18.0 labels Jan 2, 2025
@clintandrewhall clintandrewhall merged commit de0dc52 into elastic:main Jan 2, 2025
19 checks passed
@clintandrewhall clintandrewhall deleted the ai/assistant-logo-security branch January 2, 2025 16:27
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12585508134

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2025
…stant logo and beacon (elastic#204286)

> A follow-up to elastic#203879

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Security. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon for
consistency, (e.g. welcome screens, upsells, etc)

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit de0dc52)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2025
…w Assistant logo and beacon (#204286) (#205409)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ai][assistant] Refactor Security solution properties to use new
Assistant logo and beacon
(#204286)](#204286)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Clint Andrew
Hall","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T16:27:17Z","message":"[ai][assistant]
Refactor Security solution properties to use new Assistant logo and
beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n##
Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and
Avatar into\r\nsolutions and packages owned by Security. In most cases
this was a 1:1\r\nreplacement, but in a few, Icon was replaced with
Beacon for\r\nconsistency, (e.g. welcome screens, upsells,
etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one
different from\r\nEUI. The new components match EUI directly and
represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl',
etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ai][assistant]
Refactor Security solution properties to use new Assistant logo and
beacon","number":204286,"url":"https://github.com/elastic/kibana/pull/204286","mergeCommit":{"message":"[ai][assistant]
Refactor Security solution properties to use new Assistant logo and
beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n##
Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and
Avatar into\r\nsolutions and packages owned by Security. In most cases
this was a 1:1\r\nreplacement, but in a few, Icon was replaced with
Beacon for\r\nconsistency, (e.g. welcome screens, upsells,
etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one
different from\r\nEUI. The new components match EUI directly and
represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl',
etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204286","number":204286,"mergeCommit":{"message":"[ai][assistant]
Refactor Security solution properties to use new Assistant logo and
beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n##
Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and
Avatar into\r\nsolutions and packages owned by Security. In most cases
this was a 1:1\r\nreplacement, but in a few, Icon was replaced with
Beacon for\r\nconsistency, (e.g. welcome screens, upsells,
etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one
different from\r\nEUI. The new components match EUI directly and
represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl',
etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine
<[email protected]>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984"}}]}]
BACKPORT-->

---------

Co-authored-by: Clint Andrew Hall <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
…stant logo and beacon (elastic#204286)

> A follow-up to elastic#203879 

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Security. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon for
consistency, (e.g. welcome screens, upsells, etc)

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…stant logo and beacon (elastic#204286)

> A follow-up to elastic#203879 

## Summary

This PR integrates the new Assistant Icon, Beacon, and Avatar into
solutions and packages owned by Security. In most cases this was a 1:1
replacement, but in a few, Icon was replaced with Beacon for
consistency, (e.g. welcome screens, upsells, etc)

Note: the scaling of the icon/avatar _before_ was one different from
EUI. The new components match EUI directly and represent a 2x scale
change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes review v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants