-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon #204286
[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon #204286
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
...security_solution/public/detection_engine/rule_creation_ui/components/ai_assistant/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Integration Assistant plugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Detection Engine area LGTM
...platform/packages/shared/kbn-elastic-assistant/impl/assistant/assistant_body/empty_convo.tsx
Outdated
Show resolved
Hide resolved
08fdb43
to
c8296b0
Compare
b9235cf
to
16e0ccd
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
References to deprecated APIs
History
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shared UX changes look good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DW changes LGTM!
Starting backport for target branches: 8.x |
…stant logo and beacon (elastic#204286) > A follow-up to elastic#203879 ## Summary This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc) Note: the scaling of the icon/avatar _before_ was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc). --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit de0dc52)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…w Assistant logo and beacon (#204286) (#205409) # Backport This will backport the following commits from `main` to `8.x`: - [[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)](#204286) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Clint Andrew Hall","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T16:27:17Z","message":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages owned by Security. In most cases this was a 1:1\r\nreplacement, but in a few, Icon was replaced with Beacon for\r\nconsistency, (e.g. welcome screens, upsells, etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one different from\r\nEUI. The new components match EUI directly and represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["review","release_note:skip","v9.0.0","backport:prev-minor"],"title":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon","number":204286,"url":"https://github.com/elastic/kibana/pull/204286","mergeCommit":{"message":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages owned by Security. In most cases this was a 1:1\r\nreplacement, but in a few, Icon was replaced with Beacon for\r\nconsistency, (e.g. welcome screens, upsells, etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one different from\r\nEUI. The new components match EUI directly and represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/204286","number":204286,"mergeCommit":{"message":"[ai][assistant] Refactor Security solution properties to use new Assistant logo and beacon (#204286)\n\n> A follow-up to #203879 \r\n\r\n## Summary\r\n\r\nThis PR integrates the new Assistant Icon, Beacon, and Avatar into\r\nsolutions and packages owned by Security. In most cases this was a 1:1\r\nreplacement, but in a few, Icon was replaced with Beacon for\r\nconsistency, (e.g. welcome screens, upsells, etc)\r\n\r\nNote: the scaling of the icon/avatar _before_ was one different from\r\nEUI. The new components match EUI directly and represent a 2x scale\r\nchange (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"de0dc5282476c1983e90d0872fdd9909b6cdf984"}}]}] BACKPORT--> --------- Co-authored-by: Clint Andrew Hall <[email protected]>
…stant logo and beacon (elastic#204286) > A follow-up to elastic#203879 ## Summary This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc) Note: the scaling of the icon/avatar _before_ was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc). --------- Co-authored-by: kibanamachine <[email protected]>
…stant logo and beacon (elastic#204286) > A follow-up to elastic#203879 ## Summary This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc) Note: the scaling of the icon/avatar _before_ was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc). --------- Co-authored-by: kibanamachine <[email protected]>
Summary
This PR integrates the new Assistant Icon, Beacon, and Avatar into solutions and packages owned by Security. In most cases this was a 1:1 replacement, but in a few, Icon was replaced with Beacon for consistency, (e.g. welcome screens, upsells, etc)
Note: the scaling of the icon/avatar before was one different from EUI. The new components match EUI directly and represent a 2x scale change (e.g. 's' becomes 'l', 'm' becomes 'xl', etc).