Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security:Rules:Detection Rules:Create Rule] Time input interval spinner for timeperiod input to suppress alerts is missing form label #204498

Closed
bhavyarm opened this issue Dec 16, 2024 · 2 comments · Fixed by #205387
Closed

[Security:Rules:Detection Rules:Create Rule] Time input interval spinner for timeperiod input to suppress alerts is missing form label #204498

bhavyarm opened this issue Dec 16, 2024 · 2 comments · Fixed by #205387
Assignees
@alexwizp
Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A

Comments

@bhavyarm
Copy link
Contributor

Description
The time input interval box for timeperiod input for suppressing alerts is missing form label

Preconditions
Security -> Rules->Detection Rules(SIEM) page is open

Steps to reproduce

  1. Click on Rules ->Detection rules (SIEM) ->create new rule and pick custom query
  2. Run axe-core on the page
  3. Notice the critical a11y violation error for Time input interval spinner missing form label.
Image

Kibana Version: 8.17.0

OS: OX X

Browser: Chrome latest

WCAG or Vendor Guidance (optional)

Guidelines:
Understanding SC 4.1.2: Name, Role, Value (Level A)

Related to: https://github.com/elastic/kibana-team/issues/1280
@bhavyarm bhavyarm added the bug Fixes for quality problems that affect the customer experience label Dec 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm removed bug Fixes for quality problems that affect the customer experience needs-team Issues missing a team label labels Dec 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm added WCAG A and removed needs-team Issues missing a team label labels Dec 16, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Dec 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@bhavyarm bhavyarm added defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. labels Dec 16, 2024
@alexwizp alexwizp self-assigned this Jan 2, 2025
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 2, 2025
@alexwizp
fix: [Security:Rules:Detection Rules:Create Rule] Time input interval…
590ef74 
… spinner for timeperiod input to suppress alerts is missing form label

Closes: elastic#204498
@alexwizp alexwizp mentioned this issue Jan 2, 2025
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 3, 2025
@alexwizp
fix: [Security:Rules:Detection Rules:Create Rule] Time input interval…
11c1801 
… spinner for timeperiod input to suppress alerts is missing form label (elastic#205387)

Closes: elastic#204498

## Description
The time input interval box for timeperiod input for suppressing alerts
is missing form label
Preconditions: Security -> Rules->Detection Rules(SIEM) page is open

## Changes made:

`aria-label` attribute was added for mentioned place

## Screen:

![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)

(cherry picked from commit 020e17e)
kibanamachine added a commit that referenced this issue Jan 3, 2025
@kibanamachine @alexwizp
[8.x] fix: [Security:Rules:Detection Rules:Create Rule] Time input in…
c902715 
…terval spinner for timeperiod input to suppress alerts is missing form label (#205387) (#205480)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Rules:Detection Rules:Create Rule] Time input interval
spinner for timeperiod input to suppress alerts is missing form label
(#205387)](#205387)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-03T11:14:39Z","message":"fix:
[Security:Rules:Detection Rules:Create Rule] Time input interval spinner
for timeperiod input to suppress alerts is missing form label
(#205387)\n\nCloses: #204498\r\n\r\n## Description \r\nThe time input
interval box for timeperiod input for suppressing alerts\r\nis missing
form label\r\nPreconditions: Security -> Rules->Detection Rules(SIEM)
page is open\r\n\r\n## Changes made:\r\n\r\n`aria-label` attribute was
added for mentioned place\r\n\r\n## Screen:
\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)","sha":"020e17e0add45d3cd9eae0e9b15ce398cb3a75a1","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor"],"title":"fix:
[Security:Rules:Detection Rules:Create Rule] Time input interval spinner
for timeperiod input to suppress alerts is missing form
label","number":205387,"url":"https://github.com/elastic/kibana/pull/205387","mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules:Create Rule] Time input interval spinner
for timeperiod input to suppress alerts is missing form label
(#205387)\n\nCloses: #204498\r\n\r\n## Description \r\nThe time input
interval box for timeperiod input for suppressing alerts\r\nis missing
form label\r\nPreconditions: Security -> Rules->Detection Rules(SIEM)
page is open\r\n\r\n## Changes made:\r\n\r\n`aria-label` attribute was
added for mentioned place\r\n\r\n## Screen:
\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)","sha":"020e17e0add45d3cd9eae0e9b15ce398cb3a75a1"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205387","number":205387,"mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules:Create Rule] Time input interval spinner
for timeperiod input to suppress alerts is missing form label
(#205387)\n\nCloses: #204498\r\n\r\n## Description \r\nThe time input
interval box for timeperiod input for suppressing alerts\r\nis missing
form label\r\nPreconditions: Security -> Rules->Detection Rules(SIEM)
page is open\r\n\r\n## Changes made:\r\n\r\n`aria-label` attribute was
added for mentioned place\r\n\r\n## Screen:
\r\n\r\n\r\n![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)","sha":"020e17e0add45d3cd9eae0e9b15ce398cb3a75a1"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
@alexwizp @CAWilson94
fix: [Security:Rules:Detection Rules:Create Rule] Time input interval…
5fb0a1c 
… spinner for timeperiod input to suppress alerts is missing form label (elastic#205387)

Closes: elastic#204498

## Description 
The time input interval box for timeperiod input for suppressing alerts
is missing form label
Preconditions: Security -> Rules->Detection Rules(SIEM) page is open

## Changes made:

`aria-label` attribute was added for mentioned place

## Screen: 


![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@alexwizp @viduni94
fix: [Security:Rules:Detection Rules:Create Rule] Time input interval…
bedfc08 
… spinner for timeperiod input to suppress alerts is missing form label (elastic#205387)

Closes: elastic#204498

## Description 
The time input interval box for timeperiod input for suppressing alerts
is missing form label
Preconditions: Security -> Rules->Detection Rules(SIEM) page is open

## Changes made:

`aria-label` attribute was added for mentioned place

## Screen: 


![image](https://github.com/user-attachments/assets/0d78a57d-8b96-4d53-ac69-39d3f2ae42ba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@bhavyarm @elasticmachine @alexwizp