-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Error details missing language syntax highlight #204957
Labels
apm:errors-page
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Comments
crespocarlos
added
bug
Fixes for quality problems that affect the customer experience
apm:errors-page
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
labels
Dec 19, 2024
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
added a commit
that referenced
this issue
Dec 30, 2024
fixes: [#204957](#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 30, 2024
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a78f616)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this issue
Dec 30, 2024
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a78f616)
kibanamachine
added a commit
that referenced
this issue
Dec 30, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[APM] Fix stack trace syntax highlight (#205187)](#205187) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T15:48:38Z","message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services"],"title":"[APM] Fix stack trace syntax highlight","number":205187,"url":"https://github.com/elastic/kibana/pull/205187","mergeCommit":{"message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205187","number":205187,"mergeCommit":{"message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
kibanamachine
added a commit
that referenced
this issue
Dec 30, 2024
# Backport This will backport the following commits from `main` to `8.17`: - [[APM] Fix stack trace syntax highlight (#205187)](#205187) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T15:48:38Z","message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services"],"title":"[APM] Fix stack trace syntax highlight","number":205187,"url":"https://github.com/elastic/kibana/pull/205187","mergeCommit":{"message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205187","number":205187,"mergeCommit":{"message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}}]}] BACKPORT--> Co-authored-by: Carlos Crespo <[email protected]>
stratoula
pushed a commit
to stratoula/kibana
that referenced
this issue
Jan 2, 2025
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]>
crespocarlos
added a commit
to crespocarlos/kibana
that referenced
this issue
Jan 2, 2025
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]> (cherry picked from commit a78f616) # Conflicts: # x-pack/test/api_integration/deployment_agnostic/apis/observability/apm/mobile/errors/group_id_samples.spec.ts
crespocarlos
added a commit
that referenced
this issue
Jan 2, 2025
# Backport This will backport the following commits from `main` to `8.16`: - [[APM] Fix stack trace syntax highlight (#205187)](#205187) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Carlos Crespo","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-30T15:48:38Z","message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","Team:obs-ux-infra_services","v8.18.0","v8.17.1"],"number":205187,"url":"https://github.com/elastic/kibana/pull/205187","mergeCommit":{"message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205187","number":205187,"mergeCommit":{"message":"[APM] Fix stack trace syntax highlight (#205187)\n\nfixes: [#204957](https://github.com/elastic/kibana/issues/204957)\r\n\r\n## Summary\r\n\r\nThis PR fixes the stack trace syntax highlight\r\n\r\n<img width=\"1452\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <[email protected]>","sha":"a78f61691f6de231b76083a52bdcb3db602df1a0"}},{"branch":"8.x","label":"v8.18.0","labelRegex":"^v8.18.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205273","number":205273,"state":"MERGED","mergeCommit":{"sha":"29b636b1fdc0ee1af3582eea4a229a4a6a437be5","message":"[8.x] [APM] Fix stack trace syntax highlight (#205187) (#205273)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[APM] Fix stack trace syntax highlight\n(#205187)](https://github.com/elastic/kibana/pull/205187)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-30T15:48:38Z\",\"message\":\"[APM]\nFix stack trace syntax highlight (#205187)\\n\\nfixes:\n[#204957](https://github.com/elastic/kibana/issues/204957)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the stack trace syntax\nhighlight\\r\\n\\r\\n<img width=\\\"1452\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\\\"\\r\\n/>\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"a78f61691f6de231b76083a52bdcb3db602df1a0\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-major\",\"Team:obs-ux-infra_services\"],\"title\":\"[APM]\nFix stack trace syntax\nhighlight\",\"number\":205187,\"url\":\"https://github.com/elastic/kibana/pull/205187\",\"mergeCommit\":{\"message\":\"[APM]\nFix stack trace syntax highlight (#205187)\\n\\nfixes:\n[#204957](https://github.com/elastic/kibana/issues/204957)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the stack trace syntax\nhighlight\\r\\n\\r\\n<img width=\\\"1452\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\\\"\\r\\n/>\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"a78f61691f6de231b76083a52bdcb3db602df1a0\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/205187\",\"number\":205187,\"mergeCommit\":{\"message\":\"[APM]\nFix stack trace syntax highlight (#205187)\\n\\nfixes:\n[#204957](https://github.com/elastic/kibana/issues/204957)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the stack trace syntax\nhighlight\\r\\n\\r\\n<img width=\\\"1452\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\\\"\\r\\n/>\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"a78f61691f6de231b76083a52bdcb3db602df1a0\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Carlos Crespo <[email protected]>"}},{"branch":"8.17","label":"v8.17.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/205272","number":205272,"state":"MERGED","mergeCommit":{"sha":"249e5ba71ba9146555d501d6a1dd91e8aefcf92a","message":"[8.17] [APM] Fix stack trace syntax highlight (#205187) (#205272)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.17`:\n- [[APM] Fix stack trace syntax highlight\n(#205187)](https://github.com/elastic/kibana/pull/205187)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Carlos\nCrespo\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-12-30T15:48:38Z\",\"message\":\"[APM]\nFix stack trace syntax highlight (#205187)\\n\\nfixes:\n[#204957](https://github.com/elastic/kibana/issues/204957)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the stack trace syntax\nhighlight\\r\\n\\r\\n<img width=\\\"1452\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\\\"\\r\\n/>\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"a78f61691f6de231b76083a52bdcb3db602df1a0\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.18.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-major\",\"Team:obs-ux-infra_services\"],\"title\":\"[APM]\nFix stack trace syntax\nhighlight\",\"number\":205187,\"url\":\"https://github.com/elastic/kibana/pull/205187\",\"mergeCommit\":{\"message\":\"[APM]\nFix stack trace syntax highlight (#205187)\\n\\nfixes:\n[#204957](https://github.com/elastic/kibana/issues/204957)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the stack trace syntax\nhighlight\\r\\n\\r\\n<img width=\\\"1452\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\\\"\\r\\n/>\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"a78f61691f6de231b76083a52bdcb3db602df1a0\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/205187\",\"number\":205187,\"mergeCommit\":{\"message\":\"[APM]\nFix stack trace syntax highlight (#205187)\\n\\nfixes:\n[#204957](https://github.com/elastic/kibana/issues/204957)\\r\\n\\r\\n##\nSummary\\r\\n\\r\\nThis PR fixes the stack trace syntax\nhighlight\\r\\n\\r\\n<img width=\\\"1452\\\"\nalt=\\\"image\\\"\\r\\nsrc=\\\"https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26\\\"\\r\\n/>\\r\\n\\r\\n---------\\r\\n\\r\\nCo-authored-by:\nkibanamachine\n<[email protected]>\",\"sha\":\"a78f61691f6de231b76083a52bdcb3db602df1a0\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Carlos Crespo <[email protected]>"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <[email protected]>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this issue
Jan 2, 2025
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]>
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this issue
Jan 2, 2025
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this issue
Jan 13, 2025
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]>
viduni94
pushed a commit
to viduni94/kibana
that referenced
this issue
Jan 23, 2025
fixes: [elastic#204957](elastic#204957) ## Summary This PR fixes the stack trace syntax highlight <img width="1452" alt="image" src="https://github.com/user-attachments/assets/ee076fc6-c901-4e8f-a760-8c85a5470a26" /> --------- Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
apm:errors-page
bug
Fixes for quality problems that affect the customer experience
Team:obs-ux-infra_services
Observability Infrastructure & Services User Experience Team
Summary
The exception stack trace component is not rendering the stack trace with the appropriate syntax highlight
This is how it should render
The
get_error_sample_details
is not returning theservice.language.name
, necessary for the syntax highlight to workAC
The text was updated successfully, but these errors were encountered: