Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security:Rules:Detection Rules:Create Rule] EQL Query text area is missing accessible label in Create new rule panel of type event correlation #205054

Closed
bhavyarm opened this issue Dec 20, 2024 · 2 comments · Fixed by #206972
Closed

[Security:Rules:Detection Rules:Create Rule] EQL Query text area is missing accessible label in Create new rule panel of type event correlation #205054

bhavyarm opened this issue Dec 20, 2024 · 2 comments · Fixed by #206972
Assignees
@alexwizp
Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A

Comments

@bhavyarm
Copy link
Contributor

Description
EQL Query text area is missing accessible label in create new rule panel of type event correlation

Preconditions
Security -> Rules->Detection Rules(SIEM) ->create rule is open

Steps to reproduce

  1. Click on Event correlation type for rule type
  2. Run axe-core on the page
  3. Notice the critical a11y violation error for EQL query text area
Image

Kibana Version: 8.17.0

OS: OX X

Browser: Chrome latest

WCAG or Vendor Guidance (optional)

Guidelines:
Understanding SC 4.1.2: Name, Role, Value (Level A)

Related to: https://github.com/elastic/kibana-team/issues/1280
@bhavyarm bhavyarm added defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A labels Dec 20, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@alexwizp alexwizp self-assigned this Jan 2, 2025
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 16, 2025
@alexwizp
fix: [Security:Rules:Detection Rules:Create Rule] EQL Query text area…
cdf6dde 
… is missing accessible label in Create new rule panel of type event correlation

Closes: elastic#205054
@alexwizp alexwizp mentioned this issue Jan 16, 2025
Merged
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 20, 2025
@alexwizp
Merge branch 'main' into elastic#205054
def3abe
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 20, 2025
@alexwizp
fix: [Security:Rules:Detection Rules:Create Rule] EQL Query text area…
636ea5a 
… is missing accessible label in Create new rule panel of type event correlation (elastic#206972)

Closes: elastic#205054

**Description**
EQL Query text area is missing accessible label in create new rule panel
of type event correlation

**Preconditions**
Security -> Rules->Detection Rules(SIEM) ->create rule is open

**Steps to reproduce**
1. Click on Event correlation type for rule type
2. Run axe-core on the page
3. Notice the critical a11y violation error for  EQL query text area

**Changes made**
1. Added `aria-label` attribute for mentioned places

**Screen**

<img width="897" alt="image"
src="https://github.com/user-attachments/assets/7bcf592b-03d7-407a-aa94-3506d535c161"
/>

(cherry picked from commit 4dbad26)
kibanamachine added a commit that referenced this issue Jan 20, 2025
@kibanamachine @alexwizp
[8.x] fix: [Security:Rules:Detection Rules:Create Rule] EQL Query tex…
3187fb6 
…t area is missing accessible label in Create new rule panel of type event correlation (#206972) (#207201)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Rules:Detection Rules:Create Rule] EQL Query text area
is missing accessible label in Create new rule panel of type event
correlation (#206972)](#206972)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-20T14:00:55Z","message":"fix:
[Security:Rules:Detection Rules:Create Rule] EQL Query text area is
missing accessible label in Create new rule panel of type event
correlation (#206972)\n\nCloses: #205054\r\n\r\n**Description**\r\nEQL
Query text area is missing accessible label in create new rule
panel\r\nof type event correlation\r\n\r\n**Preconditions**\r\nSecurity
-> Rules->Detection Rules(SIEM) ->create rule is open \r\n\r\n**Steps to
reproduce**\r\n1. Click on Event correlation type for rule type\r\n2.
Run axe-core on the page \r\n3. Notice the critical a11y violation error
for EQL query text area\r\n\r\n**Changes made**\r\n1. Added `aria-label`
attribute for mentioned places\r\n\r\n**Screen**\r\n\r\n<img
width=\"897\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7bcf592b-03d7-407a-aa94-3506d535c161\"\r\n/>","sha":"4dbad26404277c56b4e09029071d22d61554eb65","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix:
[Security:Rules:Detection Rules:Create Rule] EQL Query text area is
missing accessible label in Create new rule panel of type event
correlation","number":206972,"url":"https://github.com/elastic/kibana/pull/206972","mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules:Create Rule] EQL Query text area is
missing accessible label in Create new rule panel of type event
correlation (#206972)\n\nCloses: #205054\r\n\r\n**Description**\r\nEQL
Query text area is missing accessible label in create new rule
panel\r\nof type event correlation\r\n\r\n**Preconditions**\r\nSecurity
-> Rules->Detection Rules(SIEM) ->create rule is open \r\n\r\n**Steps to
reproduce**\r\n1. Click on Event correlation type for rule type\r\n2.
Run axe-core on the page \r\n3. Notice the critical a11y violation error
for EQL query text area\r\n\r\n**Changes made**\r\n1. Added `aria-label`
attribute for mentioned places\r\n\r\n**Screen**\r\n\r\n<img
width=\"897\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7bcf592b-03d7-407a-aa94-3506d535c161\"\r\n/>","sha":"4dbad26404277c56b4e09029071d22d61554eb65"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206972","number":206972,"mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules:Create Rule] EQL Query text area is
missing accessible label in Create new rule panel of type event
correlation (#206972)\n\nCloses: #205054\r\n\r\n**Description**\r\nEQL
Query text area is missing accessible label in create new rule
panel\r\nof type event correlation\r\n\r\n**Preconditions**\r\nSecurity
-> Rules->Detection Rules(SIEM) ->create rule is open \r\n\r\n**Steps to
reproduce**\r\n1. Click on Event correlation type for rule type\r\n2.
Run axe-core on the page \r\n3. Notice the critical a11y violation error
for EQL query text area\r\n\r\n**Changes made**\r\n1. Added `aria-label`
attribute for mentioned places\r\n\r\n**Screen**\r\n\r\n<img
width=\"897\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/7bcf592b-03d7-407a-aa94-3506d535c161\"\r\n/>","sha":"4dbad26404277c56b4e09029071d22d61554eb65"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
cqliu1 pushed a commit to cqliu1/kibana that referenced this issue Jan 21, 2025
@alexwizp @cqliu1
fix: [Security:Rules:Detection Rules:Create Rule] EQL Query text area…
437552a 
… is missing accessible label in Create new rule panel of type event correlation (elastic#206972)

Closes: elastic#205054

**Description**
EQL Query text area is missing accessible label in create new rule panel
of type event correlation

**Preconditions**
Security -> Rules->Detection Rules(SIEM) ->create rule is open 

**Steps to reproduce**
1. Click on Event correlation type for rule type
2. Run axe-core on the page 
3. Notice the critical a11y violation error for  EQL query text area

**Changes made**
1. Added `aria-label` attribute for mentioned places

**Screen**

<img width="897" alt="image"
src="https://github.com/user-attachments/assets/7bcf592b-03d7-407a-aa94-3506d535c161"
/>
viduni94 pushed a commit to viduni94/kibana that referenced this issue Jan 23, 2025
@alexwizp @viduni94
fix: [Security:Rules:Detection Rules:Create Rule] EQL Query text area…
301e1cd 
… is missing accessible label in Create new rule panel of type event correlation (elastic#206972)

Closes: elastic#205054

**Description**
EQL Query text area is missing accessible label in create new rule panel
of type event correlation

**Preconditions**
Security -> Rules->Detection Rules(SIEM) ->create rule is open 

**Steps to reproduce**
1. Click on Event correlation type for rule type
2. Run axe-core on the page 
3. Notice the critical a11y violation error for  EQL query text area

**Changes made**
1. Added `aria-label` attribute for mentioned places

**Screen**

<img width="897" alt="image"
src="https://github.com/user-attachments/assets/7bcf592b-03d7-407a-aa94-3506d535c161"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A
Projects
None yet
Milestone
No milestone
3 participants
@bhavyarm @elasticmachine @alexwizp