-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement #205391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng title from announcement Closes: elastic#204206
alexwizp
added
Project:Accessibility
release_note:skip
Skip the PR/issue when compiling release notes
v9.0.0
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Jan 2, 2025
/ci |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
|
Pinging @elastic/kibana-accessibility (Project:Accessibility) |
adcoelho
approved these changes
Jan 2, 2025
Starting backport for target branches: 8.x |
cqliu1
pushed a commit
to cqliu1/kibana
that referenced
this pull request
Jan 2, 2025
…ng title from announcement (elastic#205391) Closes: elastic#204206 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## Changes made: 1. The `aria-labelledby` attribute has been added for the mentioned EuiModal. This change is recommended by the EUI team, see: https://eui.elastic.co/#/layout/modal for more details ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc" />
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jan 2, 2025
…ng title from announcement (elastic#205391) Closes: elastic#204206 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## Changes made: 1. The `aria-labelledby` attribute has been added for the mentioned EuiModal. This change is recommended by the EUI team, see: https://eui.elastic.co/#/layout/modal for more details ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc" /> (cherry picked from commit 50509d5)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jan 2, 2025
… missing title from announcement (#205391) (#205428) # Backport This will backport the following commits from `main` to `8.x`: - [fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement (#205391)](#205391) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Alexey Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T19:06:47Z","message":"fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement (#205391)\n\nCloses: #204206\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## Changes made: \r\n\r\n1. The `aria-labelledby` attribute has been added for the mentioned\r\nEuiModal. This change is recommended by the EUI team, see:\r\nhttps://eui.elastic.co/#/layout/modal for more details\r\n\r\n## Screen\r\n\r\n<img width=\"1652\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc\"\r\n/>","sha":"50509d5c3b9b9062b7d080cfc2c99448c9c1c622","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement","number":205391,"url":"https://github.com/elastic/kibana/pull/205391","mergeCommit":{"message":"fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement (#205391)\n\nCloses: #204206\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## Changes made: \r\n\r\n1. The `aria-labelledby` attribute has been added for the mentioned\r\nEuiModal. This change is recommended by the EUI team, see:\r\nhttps://eui.elastic.co/#/layout/modal for more details\r\n\r\n## Screen\r\n\r\n<img width=\"1652\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc\"\r\n/>","sha":"50509d5c3b9b9062b7d080cfc2c99448c9c1c622"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205391","number":205391,"mergeCommit":{"message":"fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement (#205391)\n\nCloses: #204206\r\n\r\n## Description\r\nDialog modal visible title should be announced for the users, especially\r\nusing assistive technology to know what dialog modal, flyout opened.\r\n\r\n## Changes made: \r\n\r\n1. The `aria-labelledby` attribute has been added for the mentioned\r\nEuiModal. This change is recommended by the EUI team, see:\r\nhttps://eui.elastic.co/#/layout/modal for more details\r\n\r\n## Screen\r\n\r\n<img width=\"1652\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc\"\r\n/>","sha":"50509d5c3b9b9062b7d080cfc2c99448c9c1c622"}}]}] BACKPORT--> Co-authored-by: Alexey Antonov <[email protected]>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
…ng title from announcement (elastic#205391) Closes: elastic#204206 ## Description Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened. ## Changes made: 1. The `aria-labelledby` attribute has been added for the mentioned EuiModal. This change is recommended by the EUI team, see: https://eui.elastic.co/#/layout/modal for more details ## Screen <img width="1652" alt="image" src="https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
Project:Accessibility
release_note:skip
Skip the PR/issue when compiling release notes
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #204206
Description
Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened.
Changes made:
aria-labelledby
attribute has been added for the mentioned EuiModal. This change is recommended by the EUI team, see: https://eui.elastic.co/#/layout/modal for more detailsScreen