Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Security:Get Started page]Modal dialogs for AI assistants missing title from announcement #205391

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 2, 2025

Closes: #204206

Description

Dialog modal visible title should be announced for the users, especially using assistive technology to know what dialog modal, flyout opened.

Changes made:

  1. The aria-labelledby attribute has been added for the mentioned EuiModal. This change is recommended by the EUI team, see: https://eui.elastic.co/#/layout/modal for more details

Screen

image

@alexwizp alexwizp added Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Jan 2, 2025
@alexwizp
Copy link
Contributor Author

alexwizp commented Jan 2, 2025

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #4 / ConnectorSelector should set the selected connector to none if the connector is not available

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.7MB 1.7MB +47.0B

@alexwizp alexwizp marked this pull request as ready for review January 2, 2025 16:09
@alexwizp alexwizp requested a review from a team as a code owner January 2, 2025 16:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@alexwizp alexwizp merged commit 50509d5 into elastic:main Jan 2, 2025
17 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12587437472

cqliu1 pushed a commit to cqliu1/kibana that referenced this pull request Jan 2, 2025
…ng title from announcement (elastic#205391)

Closes: elastic#204206

## Description
Dialog modal visible title should be announced for the users, especially
using assistive technology to know what dialog modal, flyout opened.

## Changes made: 

1. The `aria-labelledby` attribute has been added for the mentioned
EuiModal. This change is recommended by the EUI team, see:
https://eui.elastic.co/#/layout/modal for more details

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc"
/>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 2, 2025
…ng title from announcement (elastic#205391)

Closes: elastic#204206

## Description
Dialog modal visible title should be announced for the users, especially
using assistive technology to know what dialog modal, flyout opened.

## Changes made:

1. The `aria-labelledby` attribute has been added for the mentioned
EuiModal. This change is recommended by the EUI team, see:
https://eui.elastic.co/#/layout/modal for more details

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc"
/>

(cherry picked from commit 50509d5)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 2, 2025
… missing title from announcement (#205391) (#205428)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Get Started page]Modal dialogs for AI assistants
missing title from announcement
(#205391)](#205391)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-02T19:06:47Z","message":"fix:
[Security:Get Started page]Modal dialogs for AI assistants missing title
from announcement (#205391)\n\nCloses: #204206\r\n\r\n##
Description\r\nDialog modal visible title should be announced for the
users, especially\r\nusing assistive technology to know what dialog
modal, flyout opened.\r\n\r\n## Changes made: \r\n\r\n1. The
`aria-labelledby` attribute has been added for the
mentioned\r\nEuiModal. This change is recommended by the EUI team,
see:\r\nhttps://eui.elastic.co/#/layout/modal for more details\r\n\r\n##
Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc\"\r\n/>","sha":"50509d5c3b9b9062b7d080cfc2c99448c9c1c622","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix:
[Security:Get Started page]Modal dialogs for AI assistants missing title
from
announcement","number":205391,"url":"https://github.com/elastic/kibana/pull/205391","mergeCommit":{"message":"fix:
[Security:Get Started page]Modal dialogs for AI assistants missing title
from announcement (#205391)\n\nCloses: #204206\r\n\r\n##
Description\r\nDialog modal visible title should be announced for the
users, especially\r\nusing assistive technology to know what dialog
modal, flyout opened.\r\n\r\n## Changes made: \r\n\r\n1. The
`aria-labelledby` attribute has been added for the
mentioned\r\nEuiModal. This change is recommended by the EUI team,
see:\r\nhttps://eui.elastic.co/#/layout/modal for more details\r\n\r\n##
Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc\"\r\n/>","sha":"50509d5c3b9b9062b7d080cfc2c99448c9c1c622"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205391","number":205391,"mergeCommit":{"message":"fix:
[Security:Get Started page]Modal dialogs for AI assistants missing title
from announcement (#205391)\n\nCloses: #204206\r\n\r\n##
Description\r\nDialog modal visible title should be announced for the
users, especially\r\nusing assistive technology to know what dialog
modal, flyout opened.\r\n\r\n## Changes made: \r\n\r\n1. The
`aria-labelledby` attribute has been added for the
mentioned\r\nEuiModal. This change is recommended by the EUI team,
see:\r\nhttps://eui.elastic.co/#/layout/modal for more details\r\n\r\n##
Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc\"\r\n/>","sha":"50509d5c3b9b9062b7d080cfc2c99448c9c1c622"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
…ng title from announcement (elastic#205391)

Closes: elastic#204206

## Description
Dialog modal visible title should be announced for the users, especially
using assistive technology to know what dialog modal, flyout opened.

## Changes made: 

1. The `aria-labelledby` attribute has been added for the mentioned
EuiModal. This change is recommended by the EUI team, see:
https://eui.elastic.co/#/layout/modal for more details

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/28ee1893-3a1e-4a01-af4d-c67b841c12bc"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Security:Get Started page]Modal dialogs for AI assistants missing title from announcement
4 participants