Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eem] readSourceDefinitions to accept multiple types as input #206267

Open
klacabane opened this issue Jan 10, 2025 · 2 comments
Open

[eem] readSourceDefinitions to accept multiple types as input #206267

klacabane opened this issue Jan 10, 2025 · 2 comments
Labels
Team:obs-entities Observability Entities Team

Comments

@klacabane
Copy link
Contributor

See #202298 (comment) for context

Api consumers may need to read n type sources in a path which results in n requests executed. We should update the readSourceDefinitions api to accept multiple types so we only have to execute a single request

@klacabane klacabane added the Team:obs-entities Observability Entities Team label Jan 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-entities (Team:obs-entities)

@miltonhultgren
Copy link
Contributor

I wonder if perhaps we should avoid exposing sources directly like this?

Or rather, perhaps when reading the type, we automatically also include all the sources? Or that the type endpoint takes an option for that behaviour and a filter for which types you care about?

I think that would align better with what consumers are wanting to achieve, since from their perspective it's all about the type (the source being a bit of a sub detail that we force on them as a separate API call).

WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-entities Observability Entities Team
Projects
None yet
Development

No branches or pull requests

3 participants