Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rules migration] Use user profile UID instead of username #206299

Merged
merged 3 commits into from
Jan 12, 2025

Conversation

e40pud
Copy link
Contributor

@e40pud e40pud commented Jan 10, 2025

Summary

Internal link to the feature details

With these changes we switch to using user's profile_id instead of username as a user identification for the migration rules create and update operations.

@e40pud e40pud added release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) labels Jan 10, 2025
@e40pud e40pud requested a review from semd January 10, 2025 15:21
@e40pud e40pud self-assigned this Jan 10, 2025
@e40pud e40pud requested a review from a team as a code owner January 10, 2025 15:21
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @e40pud

@e40pud e40pud merged commit a1f8532 into elastic:main Jan 12, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12733317216

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 12, 2025
…06299)

## Summary

[Internal link](elastic/security-team#10820)
to the feature details

With these changes we switch to using user's `profile_id` instead of
`username` as a user identification for the migration rules create and
update operations.

(cherry picked from commit a1f8532)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 12, 2025
…6299) (#206378)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Rules migration] Use user profile UID instead of username
(#206299)](#206299)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ievgen
Sorokopud","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-12T12:06:13Z","message":"[Rules
migration] Use user profile UID instead of username (#206299)\n\n##
Summary\r\n\r\n[Internal
link](https://github.com/elastic/security-team/issues/10820)\r\nto the
feature details\r\n\r\nWith these changes we switch to using user's
`profile_id` instead of\r\n`username` as a user identification for the
migration rules create and\r\nupdate
operations.","sha":"a1f85326e8166857f51e581ae6a3e94bc480428e","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Threat
Hunting","Team: SecuritySolution","backport:prev-minor"],"title":"[Rules
migration] Use user profile UID instead of
username","number":206299,"url":"https://github.com/elastic/kibana/pull/206299","mergeCommit":{"message":"[Rules
migration] Use user profile UID instead of username (#206299)\n\n##
Summary\r\n\r\n[Internal
link](https://github.com/elastic/security-team/issues/10820)\r\nto the
feature details\r\n\r\nWith these changes we switch to using user's
`profile_id` instead of\r\n`username` as a user identification for the
migration rules create and\r\nupdate
operations.","sha":"a1f85326e8166857f51e581ae6a3e94bc480428e"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/206299","number":206299,"mergeCommit":{"message":"[Rules
migration] Use user profile UID instead of username (#206299)\n\n##
Summary\r\n\r\n[Internal
link](https://github.com/elastic/security-team/issues/10820)\r\nto the
feature details\r\n\r\nWith these changes we switch to using user's
`profile_id` instead of\r\n`username` as a user identification for the
migration rules create and\r\nupdate
operations.","sha":"a1f85326e8166857f51e581ae6a3e94bc480428e"}}]}]
BACKPORT-->

Co-authored-by: Ievgen Sorokopud <[email protected]>
delanni pushed a commit to delanni/kibana that referenced this pull request Jan 13, 2025
…06299)

## Summary

[Internal link](elastic/security-team#10820)
to the feature details

With these changes we switch to using user's `profile_id` instead of
`username` as a user identification for the migration rules create and
update operations.
viduni94 pushed a commit to viduni94/kibana that referenced this pull request Jan 23, 2025
…06299)

## Summary

[Internal link](elastic/security-team#10820)
to the feature details

With these changes we switch to using user's `profile_id` instead of
`username` as a user identification for the migration rules create and
update operations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Threat Hunting Security Solution Threat Hunting Team v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants