[Dashboard][Vega] Panel wrongly reporting unsaved changes #207781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dej611
added
Feature:Add Data
kibanamachine
added
the
Team:Presentation
|
Pinging @elastic/kibana-visualizations (Team:Visualizations) |
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@dej611 can you explain more about how the saved object was wrong? Was it modified outside of the Dashboard app perhaps? Was the Vega misconfigured? |
|
@ThomThomson the Vega panel was configured as by reference but at the same time stored as a by value. |
|
Great explanation, and good fix! Thank you! |
Dosant
approved these changes
Jan 24, 2025
dej611
added
impact:low
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
|
JoseLuisGJ
pushed a commit
to JoseLuisGJ/kibana
that referenced
this pull request
Jan 27, 2025
…7781) ## Summary Fixes elastic#196954 Apparently the root issue here is the wrong dashboard SO, so here's the SO has been fixed and the bug is no longer present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #196954
Apparently the root issue here is the wrong dashboard SO, so here's the SO has been fixed and the bug is no longer present.