Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ML] Daylight saving time calendar events (#193605) #195262

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

Adds new pages for creating and managing DST calendars.
Closes elastic#189469

New section added to Settings home page.

![image](https://github.com/user-attachments/assets/9165906f-e571-46be-a5ac-bf7dc9cd2801)

New page for listing DST calendars. The original calendar page does not
show DST calendars.

![image](https://github.com/user-attachments/assets/32a64a31-b4e5-4516-85fd-19e63aa9d5c4)

New page for creating DST calendars.
The ability to apply to all jobs and add a description has been removed.
It is not possible manually add events. Events are automatically
generated for a selected time zone.
<img width="1170" alt="image"
src="https://github.com/user-attachments/assets/557b8d39-6c17-448a-aa30-a282d8a424a7">

If the selected time zone does not observe daylight savings, an info
callout is displayed
<img width="1178" alt="image"
src="https://github.com/user-attachments/assets/627043bf-0368-4ab3-8ca7-1931f9622387">

A new DST calendar section is added to all AD job wizards.

![image](https://github.com/user-attachments/assets/6359192b-faac-4ffb-ad3e-b8193f40f02f)

(cherry picked from commit 2881b04)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
ml 2041 2044 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.6MB 4.6MB +10.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
ml 74.4KB 74.8KB +483.0B
Unknown metric groups

ESLint disabled line counts

id before after diff
ml 563 567 +4

Total ESLint disabled count

id before after diff
ml 566 570 +4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

@kibanamachine kibanamachine merged commit 8811474 into elastic:8.x Oct 7, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants