From 328871a43e612366b27ec6ab4a661669a9baa01b Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 26 Nov 2024 15:30:09 +0000 Subject: [PATCH 01/17] fix(NA): cache missing entrypoint --- packages/kbn-ui-shared-deps-npm/webpack.config.js | 2 ++ packages/kbn-ui-shared-deps-src/src/definitions.js | 1 + packages/kbn-ui-shared-deps-src/src/entry.js | 1 + 3 files changed, 4 insertions(+) diff --git a/packages/kbn-ui-shared-deps-npm/webpack.config.js b/packages/kbn-ui-shared-deps-npm/webpack.config.js index 384071e0b9168..8faf6c0c1ab76 100644 --- a/packages/kbn-ui-shared-deps-npm/webpack.config.js +++ b/packages/kbn-ui-shared-deps-npm/webpack.config.js @@ -65,10 +65,12 @@ module.exports = (_, argv) => { '@elastic/eui/optimize/es/components/provider/nested', '@elastic/eui/optimize/es/services', '@elastic/eui/optimize/es/services/format', + '@elastic/eui/optimize/es/services/theme/warning', '@elastic/eui/dist/eui_theme_amsterdam_light.json', '@elastic/eui/dist/eui_theme_amsterdam_dark.json', '@elastic/eui/dist/eui_theme_borealis_light.json', '@elastic/eui/dist/eui_theme_borealis_dark.json', + '@elastic/eui-theme-borealis', '@elastic/numeral', '@emotion/cache', '@emotion/react', diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index 3e66e5a102f06..86fcda8f526b6 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -77,6 +77,7 @@ const externals = { '__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider', '@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices', '@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat', + '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', '@elastic/eui-theme-borealis': '__kbnSharedDeps__.ElasticEuiThemeBorealis', // transient dep of eui diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index 1d7e6442e29d0..0f2a7dc135289 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -45,6 +45,7 @@ export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested'); export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); +export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); export const KbnDatemath = require('@kbn/datemath'); export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd'); export const ReduxjsToolkit = require('@reduxjs/toolkit'); From 25b9c23b29d69962affc6691f53fda96beb315ae Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Mon, 2 Dec 2024 04:53:03 +0000 Subject: [PATCH 02/17] fix(NA): remove all cached src deps --- packages/kbn-ui-shared-deps-npm/webpack.config.js | 2 +- packages/kbn-ui-shared-deps-src/BUILD.bazel | 2 +- packages/kbn-ui-shared-deps-src/src/definitions.js | 4 ++-- packages/kbn-ui-shared-deps-src/src/entry.js | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/kbn-ui-shared-deps-npm/webpack.config.js b/packages/kbn-ui-shared-deps-npm/webpack.config.js index 8faf6c0c1ab76..6f72187427fb1 100644 --- a/packages/kbn-ui-shared-deps-npm/webpack.config.js +++ b/packages/kbn-ui-shared-deps-npm/webpack.config.js @@ -65,7 +65,7 @@ module.exports = (_, argv) => { '@elastic/eui/optimize/es/components/provider/nested', '@elastic/eui/optimize/es/services', '@elastic/eui/optimize/es/services/format', - '@elastic/eui/optimize/es/services/theme/warning', + // '@elastic/eui/optimize/es/services/theme/warning', '@elastic/eui/dist/eui_theme_amsterdam_light.json', '@elastic/eui/dist/eui_theme_amsterdam_dark.json', '@elastic/eui/dist/eui_theme_borealis_light.json', diff --git a/packages/kbn-ui-shared-deps-src/BUILD.bazel b/packages/kbn-ui-shared-deps-src/BUILD.bazel index b0d7bb65843d9..72dbcb20604bf 100644 --- a/packages/kbn-ui-shared-deps-src/BUILD.bazel +++ b/packages/kbn-ui-shared-deps-src/BUILD.bazel @@ -39,7 +39,7 @@ webpack_cli( "//packages/shared-ux/error_boundary", "//packages/kbn-rison", "//packages/shared-ux/code_editor/impl:code_editor", - "//packages/react/kibana_context/theme", + #"//packages/react/kibana_context/theme", ], output_dir = True, args = [ diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index 86fcda8f526b6..4961d6b81b330 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -77,7 +77,7 @@ const externals = { '__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider', '@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices', '@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat', - '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', + // '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', '@elastic/eui-theme-borealis': '__kbnSharedDeps__.ElasticEuiThemeBorealis', // transient dep of eui @@ -107,7 +107,7 @@ const externals = { '@kbn/esql-ast': '__kbnSharedDeps__.KbnEsqlAst', '@kbn/ebt-tools': '__kbnSharedDeps__.KbnEbtTools', '@elastic/apm-rum-core': '__kbnSharedDeps__.ElasticApmRumCore', - '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', + // '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', }; module.exports = { distDir, jsFilename, cssDistFilename, externals }; diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index 0f2a7dc135289..fce03a7d76a36 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -45,7 +45,7 @@ export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested'); export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); -export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); +// export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); export const KbnDatemath = require('@kbn/datemath'); export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd'); export const ReduxjsToolkit = require('@reduxjs/toolkit'); @@ -80,4 +80,4 @@ export const KbnCodeEditor = require('@kbn/code-editor'); export const KbnEsqlAst = require('@kbn/esql-ast'); export const KbnEbtTools = require('@kbn/ebt-tools'); export const ElasticApmRumCore = require('@elastic/apm-rum-core'); -export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); +// export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); From 0148ca7d7f14db609291becc9f54bb236d288284 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Wed, 11 Dec 2024 17:36:45 +0000 Subject: [PATCH 03/17] fix(NA): remove unused eui exports --- packages/kbn-ui-shared-deps-npm/webpack.config.js | 4 ++-- packages/kbn-ui-shared-deps-src/src/definitions.js | 4 ++-- packages/kbn-ui-shared-deps-src/src/entry.js | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/kbn-ui-shared-deps-npm/webpack.config.js b/packages/kbn-ui-shared-deps-npm/webpack.config.js index e61c9df4966a2..820f678949337 100644 --- a/packages/kbn-ui-shared-deps-npm/webpack.config.js +++ b/packages/kbn-ui-shared-deps-npm/webpack.config.js @@ -63,8 +63,8 @@ module.exports = (_, argv) => { '@elastic/charts', '@elastic/eui', '@elastic/eui/optimize/es/components/provider/nested', - '@elastic/eui/optimize/es/services', - '@elastic/eui/optimize/es/services/format', + // '@elastic/eui/optimize/es/services', + // '@elastic/eui/optimize/es/services/format', // '@elastic/eui/optimize/es/services/theme/warning', '@elastic/eui/dist/eui_theme_amsterdam_light.json', '@elastic/eui/dist/eui_theme_amsterdam_dark.json', diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index 4961d6b81b330..d64d8730ba7c1 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -75,8 +75,8 @@ const externals = { '@elastic/eui': '__kbnSharedDeps__.ElasticEui', '@elastic/eui/lib/components/provider/nested': '__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider', - '@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices', - '@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat', + // '@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices', + // '@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat', // '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', '@elastic/eui-theme-borealis': '__kbnSharedDeps__.ElasticEuiThemeBorealis', diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index fce03a7d76a36..54b80ec1bd20e 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -43,8 +43,8 @@ export const ElasticCharts = require('@elastic/charts'); export const ElasticEui = require('@elastic/eui'); export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested'); -export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); -export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); +// export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); +// export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); // export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); export const KbnDatemath = require('@kbn/datemath'); export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd'); From 6db3f36c9ce8c1af53a79050953c969951d0ca73 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Wed, 11 Dec 2024 17:39:31 +0000 Subject: [PATCH 04/17] chore(NA): rearrange theme borealis order --- packages/kbn-ui-shared-deps-src/src/entry.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index 54b80ec1bd20e..d2a84f1f45792 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -41,11 +41,11 @@ export const Rxjs = require('rxjs'); export const ElasticNumeral = require('@elastic/numeral'); export const ElasticCharts = require('@elastic/charts'); export const ElasticEui = require('@elastic/eui'); -export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested'); // export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); // export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); // export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); +export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const KbnDatemath = require('@kbn/datemath'); export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd'); export const ReduxjsToolkit = require('@reduxjs/toolkit'); From b0c3c01fb1e445159c4c74dabe144e8cde198b11 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Wed, 11 Dec 2024 19:16:42 +0000 Subject: [PATCH 05/17] chore(NA): cache theme-warning --- packages/kbn-ui-shared-deps-npm/webpack.config.js | 2 +- packages/kbn-ui-shared-deps-src/src/definitions.js | 2 +- packages/kbn-ui-shared-deps-src/src/entry.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/kbn-ui-shared-deps-npm/webpack.config.js b/packages/kbn-ui-shared-deps-npm/webpack.config.js index 820f678949337..b10bb3ce16538 100644 --- a/packages/kbn-ui-shared-deps-npm/webpack.config.js +++ b/packages/kbn-ui-shared-deps-npm/webpack.config.js @@ -65,7 +65,7 @@ module.exports = (_, argv) => { '@elastic/eui/optimize/es/components/provider/nested', // '@elastic/eui/optimize/es/services', // '@elastic/eui/optimize/es/services/format', - // '@elastic/eui/optimize/es/services/theme/warning', + '@elastic/eui/optimize/es/services/theme/warning', '@elastic/eui/dist/eui_theme_amsterdam_light.json', '@elastic/eui/dist/eui_theme_amsterdam_dark.json', '@elastic/eui/dist/eui_theme_borealis_light.json', diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index d64d8730ba7c1..46bd59e6a76ab 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -77,7 +77,7 @@ const externals = { '__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider', // '@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices', // '@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat', - // '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', + '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', '@elastic/eui-theme-borealis': '__kbnSharedDeps__.ElasticEuiThemeBorealis', // transient dep of eui diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index d2a84f1f45792..afe6dca2727ce 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -44,7 +44,7 @@ export const ElasticEui = require('@elastic/eui'); export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested'); // export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); // export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); -// export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); +export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const KbnDatemath = require('@kbn/datemath'); export const HelloPangeaDnd = require('@hello-pangea/dnd/dist/dnd'); From 048504c67ba25f3a26073240514282aa64ddf934 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Wed, 11 Dec 2024 19:52:21 +0000 Subject: [PATCH 06/17] fix(NA): update limits --- packages/kbn-optimizer/limits.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml index 3152a02cd730f..0f7101b7956c5 100644 --- a/packages/kbn-optimizer/limits.yml +++ b/packages/kbn-optimizer/limits.yml @@ -32,7 +32,7 @@ pageLoadAssetSize: dataUsage: 30000 dataViewEditor: 28082 dataViewFieldEditor: 42021 - dataViewManagement: 5370 + dataViewManagement: 5450 dataViews: 65000 dataVisualizer: 30000 devTools: 38637 From 9c8e358616295bb60bd3575224489f29fa39feb9 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Thu, 12 Dec 2024 21:01:11 +0000 Subject: [PATCH 07/17] chore(NA): remove unused extra comments --- packages/kbn-ui-shared-deps-npm/webpack.config.js | 2 -- packages/kbn-ui-shared-deps-src/src/definitions.js | 2 -- packages/kbn-ui-shared-deps-src/src/entry.js | 2 -- 3 files changed, 6 deletions(-) diff --git a/packages/kbn-ui-shared-deps-npm/webpack.config.js b/packages/kbn-ui-shared-deps-npm/webpack.config.js index b10bb3ce16538..7e9fb94cf7de4 100644 --- a/packages/kbn-ui-shared-deps-npm/webpack.config.js +++ b/packages/kbn-ui-shared-deps-npm/webpack.config.js @@ -63,8 +63,6 @@ module.exports = (_, argv) => { '@elastic/charts', '@elastic/eui', '@elastic/eui/optimize/es/components/provider/nested', - // '@elastic/eui/optimize/es/services', - // '@elastic/eui/optimize/es/services/format', '@elastic/eui/optimize/es/services/theme/warning', '@elastic/eui/dist/eui_theme_amsterdam_light.json', '@elastic/eui/dist/eui_theme_amsterdam_dark.json', diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index 46bd59e6a76ab..f48868a22b76b 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -75,8 +75,6 @@ const externals = { '@elastic/eui': '__kbnSharedDeps__.ElasticEui', '@elastic/eui/lib/components/provider/nested': '__kbnSharedDeps__.ElasticEuiLibComponentsUseIsNestedEuiProvider', - // '@elastic/eui/lib/services': '__kbnSharedDeps__.ElasticEuiLibServices', - // '@elastic/eui/lib/services/format': '__kbnSharedDeps__.ElasticEuiLibServicesFormat', '@elastic/eui/lib/services/theme/warning': '__kbnSharedDeps__.ElasticEuiLibServicesThemeWarning', '@elastic/eui-theme-borealis': '__kbnSharedDeps__.ElasticEuiThemeBorealis', diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index afe6dca2727ce..ad5db78c113cd 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -42,8 +42,6 @@ export const ElasticNumeral = require('@elastic/numeral'); export const ElasticCharts = require('@elastic/charts'); export const ElasticEui = require('@elastic/eui'); export const ElasticEuiLibComponentsUseIsNestedEuiProvider = require('@elastic/eui/optimize/es/components/provider/nested'); -// export const ElasticEuiLibServices = require('@elastic/eui/optimize/es/services'); -// export const ElasticEuiLibServicesFormat = require('@elastic/eui/optimize/es/services/format'); export const ElasticEuiLibServicesThemeWarning = require('@elastic/eui/optimize/es/services/theme/warning'); export const ElasticEuiThemeBorealis = require('@elastic/eui-theme-borealis'); export const KbnDatemath = require('@kbn/datemath'); From 81fb3160ee00029035e560f97d327ceffa89b6d5 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Thu, 12 Dec 2024 21:45:05 +0000 Subject: [PATCH 08/17] chore(NA): re-cache again react/kibana_context/theme --- packages/kbn-ui-shared-deps-src/BUILD.bazel | 2 +- packages/kbn-ui-shared-deps-src/src/definitions.js | 2 +- packages/kbn-ui-shared-deps-src/src/entry.js | 2 +- packages/kbn-ui-shared-deps-src/webpack.config.js | 2 ++ 4 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/kbn-ui-shared-deps-src/BUILD.bazel b/packages/kbn-ui-shared-deps-src/BUILD.bazel index 2dbb7a3723822..e8ff7302faa67 100644 --- a/packages/kbn-ui-shared-deps-src/BUILD.bazel +++ b/packages/kbn-ui-shared-deps-src/BUILD.bazel @@ -39,7 +39,7 @@ webpack_cli( "//packages/shared-ux/error_boundary", "//packages/kbn-rison", "//packages/shared-ux/code_editor/impl:code_editor", - #"//packages/react/kibana_context/theme", + "//packages/react/kibana_context/theme", ], output_dir = True, args = [ diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index f48868a22b76b..a7786bf3556a5 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -105,7 +105,7 @@ const externals = { '@kbn/esql-ast': '__kbnSharedDeps__.KbnEsqlAst', '@kbn/ebt-tools': '__kbnSharedDeps__.KbnEbtTools', '@elastic/apm-rum-core': '__kbnSharedDeps__.ElasticApmRumCore', - // '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', + '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', }; module.exports = { distDir, jsFilename, cssDistFilename, externals }; diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index ad5db78c113cd..f30f75f7bd5af 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -78,4 +78,4 @@ export const KbnCodeEditor = require('@kbn/code-editor'); export const KbnEsqlAst = require('@kbn/esql-ast'); export const KbnEbtTools = require('@kbn/ebt-tools'); export const ElasticApmRumCore = require('@elastic/apm-rum-core'); -// export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); +export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); diff --git a/packages/kbn-ui-shared-deps-src/webpack.config.js b/packages/kbn-ui-shared-deps-src/webpack.config.js index 26eac38c3060c..53b7d11177863 100644 --- a/packages/kbn-ui-shared-deps-src/webpack.config.js +++ b/packages/kbn-ui-shared-deps-src/webpack.config.js @@ -109,6 +109,8 @@ module.exports = { extensions: ['.js', '.ts', '.tsx'], alias: { '@elastic/eui$': '@elastic/eui/optimize/es', + '@elastic/eui/lib/components/provider/nested$': '@elastic/eui/optimize/es/components/provider/nested', + '@elastic/eui/lib/services/theme/warning$': '@elastic/eui/optimize/es/services/theme/warning', moment: MOMENT_SRC, // NOTE: Used to include react profiling on bundles // https://gist.github.com/bvaughn/25e6233aeb1b4f0cdb8d8366e54a3977#webpack-4 From 6ec2b917c42ecce4f909ddb9e39ee20817ed7a99 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Thu, 12 Dec 2024 21:46:02 +0000 Subject: [PATCH 09/17] fix(NA): restore previous optimizer limits --- packages/kbn-optimizer/limits.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml index 0f7101b7956c5..3152a02cd730f 100644 --- a/packages/kbn-optimizer/limits.yml +++ b/packages/kbn-optimizer/limits.yml @@ -32,7 +32,7 @@ pageLoadAssetSize: dataUsage: 30000 dataViewEditor: 28082 dataViewFieldEditor: 42021 - dataViewManagement: 5450 + dataViewManagement: 5370 dataViews: 65000 dataVisualizer: 30000 devTools: 38637 From ba4acf2b48de3d7f2dd30ef4aa6425c7dccd5b74 Mon Sep 17 00:00:00 2001 From: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Date: Thu, 12 Dec 2024 22:07:49 +0000 Subject: [PATCH 10/17] [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' --- packages/kbn-ui-shared-deps-src/webpack.config.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/kbn-ui-shared-deps-src/webpack.config.js b/packages/kbn-ui-shared-deps-src/webpack.config.js index 53b7d11177863..a1ee7dbf768e1 100644 --- a/packages/kbn-ui-shared-deps-src/webpack.config.js +++ b/packages/kbn-ui-shared-deps-src/webpack.config.js @@ -109,7 +109,8 @@ module.exports = { extensions: ['.js', '.ts', '.tsx'], alias: { '@elastic/eui$': '@elastic/eui/optimize/es', - '@elastic/eui/lib/components/provider/nested$': '@elastic/eui/optimize/es/components/provider/nested', + '@elastic/eui/lib/components/provider/nested$': + '@elastic/eui/optimize/es/components/provider/nested', '@elastic/eui/lib/services/theme/warning$': '@elastic/eui/optimize/es/services/theme/warning', moment: MOMENT_SRC, // NOTE: Used to include react profiling on bundles From bc4f13968e2684a9ab87dcb4e487c2a143a7b545 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Fri, 13 Dec 2024 00:47:23 +0000 Subject: [PATCH 11/17] fix(NA): update limits --- packages/kbn-optimizer/limits.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml index 3152a02cd730f..3dfb14fb5b745 100644 --- a/packages/kbn-optimizer/limits.yml +++ b/packages/kbn-optimizer/limits.yml @@ -32,7 +32,7 @@ pageLoadAssetSize: dataUsage: 30000 dataViewEditor: 28082 dataViewFieldEditor: 42021 - dataViewManagement: 5370 + dataViewManagement: 5375 dataViews: 65000 dataVisualizer: 30000 devTools: 38637 From 207549af691ec0b3d4d2a62a4726438393b0075a Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Fri, 13 Dec 2024 07:43:40 +0000 Subject: [PATCH 12/17] fix(NA): update limits --- packages/kbn-optimizer/limits.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml index 3dfb14fb5b745..3ebe5ecc3f020 100644 --- a/packages/kbn-optimizer/limits.yml +++ b/packages/kbn-optimizer/limits.yml @@ -32,7 +32,7 @@ pageLoadAssetSize: dataUsage: 30000 dataViewEditor: 28082 dataViewFieldEditor: 42021 - dataViewManagement: 5375 + dataViewManagement: 5380 dataViews: 65000 dataVisualizer: 30000 devTools: 38637 From 49a3581302866f9ab0a807caf5c330cf2206142b Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Fri, 13 Dec 2024 16:39:10 +0000 Subject: [PATCH 13/17] fix(NA): update limits --- packages/kbn-optimizer/limits.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml index 3ebe5ecc3f020..75dd8265702e4 100644 --- a/packages/kbn-optimizer/limits.yml +++ b/packages/kbn-optimizer/limits.yml @@ -32,7 +32,7 @@ pageLoadAssetSize: dataUsage: 30000 dataViewEditor: 28082 dataViewFieldEditor: 42021 - dataViewManagement: 5380 + dataViewManagement: 5500 dataViews: 65000 dataVisualizer: 30000 devTools: 38637 From 4f9a4b1c17256f5e144899b07fa6a08554bd6f33 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Mon, 23 Dec 2024 16:38:42 +0000 Subject: [PATCH 14/17] chore(NA): experiment not to cache react kibana context theme --- packages/kbn-ui-shared-deps-src/BUILD.bazel | 2 +- packages/kbn-ui-shared-deps-src/src/definitions.js | 2 +- packages/kbn-ui-shared-deps-src/src/entry.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/kbn-ui-shared-deps-src/BUILD.bazel b/packages/kbn-ui-shared-deps-src/BUILD.bazel index e8ff7302faa67..2dbb7a3723822 100644 --- a/packages/kbn-ui-shared-deps-src/BUILD.bazel +++ b/packages/kbn-ui-shared-deps-src/BUILD.bazel @@ -39,7 +39,7 @@ webpack_cli( "//packages/shared-ux/error_boundary", "//packages/kbn-rison", "//packages/shared-ux/code_editor/impl:code_editor", - "//packages/react/kibana_context/theme", + #"//packages/react/kibana_context/theme", ], output_dir = True, args = [ diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index a7786bf3556a5..f48868a22b76b 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -105,7 +105,7 @@ const externals = { '@kbn/esql-ast': '__kbnSharedDeps__.KbnEsqlAst', '@kbn/ebt-tools': '__kbnSharedDeps__.KbnEbtTools', '@elastic/apm-rum-core': '__kbnSharedDeps__.ElasticApmRumCore', - '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', + // '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', }; module.exports = { distDir, jsFilename, cssDistFilename, externals }; diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index f30f75f7bd5af..ad5db78c113cd 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -78,4 +78,4 @@ export const KbnCodeEditor = require('@kbn/code-editor'); export const KbnEsqlAst = require('@kbn/esql-ast'); export const KbnEbtTools = require('@kbn/ebt-tools'); export const ElasticApmRumCore = require('@elastic/apm-rum-core'); -export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); +// export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); From d5e5f985ec6964de315d3384f8f5c2c7d36b3411 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 24 Dec 2024 01:30:15 +0000 Subject: [PATCH 15/17] fix(NA): test uncomment eui provider dev warning --- .../core-chrome-browser-internal/src/chrome_service.tsx | 4 +--- test/plugin_functional/test_suites/shared_ux/eui_provider.ts | 3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx b/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx index 511100fff6d40..434639b07efdf 100644 --- a/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx +++ b/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx @@ -182,7 +182,6 @@ export class ChromeService { }; // Ensure developers are notified if working in a context that lacks the EUI Provider. - // @ts-expect-error private handleEuiDevProviderWarning = (notifications: NotificationsStart) => { const isDev = this.params.coreContext.env.mode.name === 'development'; if (isDev) { @@ -241,8 +240,7 @@ export class ChromeService { }: StartDeps): Promise { this.initVisibility(application); this.handleEuiFullScreenChanges(); - // commented out until https://github.com/elastic/kibana/issues/201805 can be fixed - // this.handleEuiDevProviderWarning(notifications); + this.handleEuiDevProviderWarning(notifications); const globalHelpExtensionMenuLinks$ = new BehaviorSubject( [] diff --git a/test/plugin_functional/test_suites/shared_ux/eui_provider.ts b/test/plugin_functional/test_suites/shared_ux/eui_provider.ts index b35e25bb9121b..fd503db46d27d 100644 --- a/test/plugin_functional/test_suites/shared_ux/eui_provider.ts +++ b/test/plugin_functional/test_suites/shared_ux/eui_provider.ts @@ -15,8 +15,7 @@ export default function ({ getPageObjects, getService }: PluginFunctionalProvide const testSubjects = getService('testSubjects'); const browser = getService('browser'); - // skipped until https://github.com/elastic/kibana/issues/201805 is resolved - describe.skip('EUI Provider Dev Warning', () => { + describe('EUI Provider Dev Warning', () => { it('shows error toast to developer', async () => { const pageTitle = 'EuiProvider test - Elastic'; From 3d2f6d35704652f6308d153fb09ee902b0998c80 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 24 Dec 2024 03:00:04 +0000 Subject: [PATCH 16/17] Revert "fix(NA): test uncomment eui provider dev warning" This reverts commit d5e5f985ec6964de315d3384f8f5c2c7d36b3411. --- .../core-chrome-browser-internal/src/chrome_service.tsx | 4 +++- test/plugin_functional/test_suites/shared_ux/eui_provider.ts | 3 ++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx b/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx index 434639b07efdf..511100fff6d40 100644 --- a/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx +++ b/packages/core/chrome/core-chrome-browser-internal/src/chrome_service.tsx @@ -182,6 +182,7 @@ export class ChromeService { }; // Ensure developers are notified if working in a context that lacks the EUI Provider. + // @ts-expect-error private handleEuiDevProviderWarning = (notifications: NotificationsStart) => { const isDev = this.params.coreContext.env.mode.name === 'development'; if (isDev) { @@ -240,7 +241,8 @@ export class ChromeService { }: StartDeps): Promise { this.initVisibility(application); this.handleEuiFullScreenChanges(); - this.handleEuiDevProviderWarning(notifications); + // commented out until https://github.com/elastic/kibana/issues/201805 can be fixed + // this.handleEuiDevProviderWarning(notifications); const globalHelpExtensionMenuLinks$ = new BehaviorSubject( [] diff --git a/test/plugin_functional/test_suites/shared_ux/eui_provider.ts b/test/plugin_functional/test_suites/shared_ux/eui_provider.ts index fd503db46d27d..b35e25bb9121b 100644 --- a/test/plugin_functional/test_suites/shared_ux/eui_provider.ts +++ b/test/plugin_functional/test_suites/shared_ux/eui_provider.ts @@ -15,7 +15,8 @@ export default function ({ getPageObjects, getService }: PluginFunctionalProvide const testSubjects = getService('testSubjects'); const browser = getService('browser'); - describe('EUI Provider Dev Warning', () => { + // skipped until https://github.com/elastic/kibana/issues/201805 is resolved + describe.skip('EUI Provider Dev Warning', () => { it('shows error toast to developer', async () => { const pageTitle = 'EuiProvider test - Elastic'; From 15676010d1e7cd69b307b75c95503ed139639650 Mon Sep 17 00:00:00 2001 From: Tiago Costa Date: Tue, 24 Dec 2024 03:00:41 +0000 Subject: [PATCH 17/17] Revert "chore(NA): experiment not to cache react kibana context theme" This reverts commit 4f9a4b1c17256f5e144899b07fa6a08554bd6f33. --- packages/kbn-ui-shared-deps-src/BUILD.bazel | 2 +- packages/kbn-ui-shared-deps-src/src/definitions.js | 2 +- packages/kbn-ui-shared-deps-src/src/entry.js | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/kbn-ui-shared-deps-src/BUILD.bazel b/packages/kbn-ui-shared-deps-src/BUILD.bazel index 2dbb7a3723822..e8ff7302faa67 100644 --- a/packages/kbn-ui-shared-deps-src/BUILD.bazel +++ b/packages/kbn-ui-shared-deps-src/BUILD.bazel @@ -39,7 +39,7 @@ webpack_cli( "//packages/shared-ux/error_boundary", "//packages/kbn-rison", "//packages/shared-ux/code_editor/impl:code_editor", - #"//packages/react/kibana_context/theme", + "//packages/react/kibana_context/theme", ], output_dir = True, args = [ diff --git a/packages/kbn-ui-shared-deps-src/src/definitions.js b/packages/kbn-ui-shared-deps-src/src/definitions.js index f48868a22b76b..a7786bf3556a5 100644 --- a/packages/kbn-ui-shared-deps-src/src/definitions.js +++ b/packages/kbn-ui-shared-deps-src/src/definitions.js @@ -105,7 +105,7 @@ const externals = { '@kbn/esql-ast': '__kbnSharedDeps__.KbnEsqlAst', '@kbn/ebt-tools': '__kbnSharedDeps__.KbnEbtTools', '@elastic/apm-rum-core': '__kbnSharedDeps__.ElasticApmRumCore', - // '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', + '@kbn/react-kibana-context-theme': '__kbnSharedDeps__.KbnReactKibanaContextTheme', }; module.exports = { distDir, jsFilename, cssDistFilename, externals }; diff --git a/packages/kbn-ui-shared-deps-src/src/entry.js b/packages/kbn-ui-shared-deps-src/src/entry.js index ad5db78c113cd..f30f75f7bd5af 100644 --- a/packages/kbn-ui-shared-deps-src/src/entry.js +++ b/packages/kbn-ui-shared-deps-src/src/entry.js @@ -78,4 +78,4 @@ export const KbnCodeEditor = require('@kbn/code-editor'); export const KbnEsqlAst = require('@kbn/esql-ast'); export const KbnEbtTools = require('@kbn/ebt-tools'); export const ElasticApmRumCore = require('@elastic/apm-rum-core'); -// export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme'); +export const KbnReactKibanaContextTheme = require('@kbn/react-kibana-context-theme');