Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Exploratory View] Audit new EUI Borealis theme #205212

Merged
merged 17 commits into from
Jan 15, 2025
Merged

[Exploratory View] Audit new EUI Borealis theme #205212

merged 17 commits into from
Jan 15, 2025

Conversation

fkanout
Copy link
Contributor

@fkanout fkanout commented Dec 27, 2024 •
edited
Loading

Summary

It fixes #205051

Files are excluded because of `euiScrollBar` and `euiScrollBarCorner` replacement (TBD) - x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/series_editor.tsx
  • x-pack/solutions/observability/plugins/exploratory_view/public/components/shared/exploratory_view/series_editor/components/filter_values_list.tsx
 ✅ DONE

@fkanout fkanout self-assigned this Dec 27, 2024
@fkanout fkanout added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:obs-ux-management Observability Management User Experience Team EUI Visual Refresh labels Dec 27, 2024
@fkanout fkanout marked this pull request as ready for review January 10, 2025 12:52
@fkanout fkanout requested a review from a team as a code owner January 10, 2025 12:52
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner January 10, 2025 13:01
jbudz
jbudz approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/kbn-babel-preset/styled_components_files.js LGTM

@fkanout fkanout requested a review from patpscal January 13, 2025 10:00
patpscal
patpscal approved these changes Jan 13, 2025
View reviewed changes
Copy link

@patpscal patpscal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Waiting for information from the theme working group about the text application of the visualization palette:
https://elastic.slack.com/archives/C060SDYTZ96/p1736773121682819

@patpscal
Copy link

patpscal commented Jan 13, 2025 •
edited
Loading

@fkanout Following up on the Slack thread, we should be using https://eui.elastic.co/#/display/stat, which has the proper color tokens built in, so they match the monitor status ones (which are correct)
image

@fkanout
Copy link
Contributor Author

fkanout commented Jan 14, 2025

@fkanout Following up on the Slack thread, we should be using https://eui.elastic.co/#/display/stat, which has the proper color tokens built in, so they match the monitor status ones (which are correct) image

@patpscal I was checking this, and it's a shared component from src/platform, so I don't believe this is within the scope of this PR.

@fkanout fkanout enabled auto-merge (squash) January 14, 2025 13:07
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
exploratoryView 163 179 +16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
exploratoryView 178.1KB 177.0KB -1.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
exploratoryView 43.9KB 55.3KB +11.4KB

History

cc @fkanout

shahzad31
shahzad31 approved these changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!

Thank you for taking care of it !!

@fkanout fkanout merged commit b0973cf into elastic:main Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patpscal patpscal patpscal approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@jbudz jbudz jbudz approved these changes

Assignees

@fkanout fkanout

Labels
backport:skip This commit does not require backporting EUI Visual Refresh release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-management Observability Management User Experience Team v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UX Plugin, Exploratory View] Audit new EUI Borealis theme
6 participants
@fkanout @elasticmachine @patpscal @jbudz @shahzad31 @kibanamachine