-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request]: Update Containers docs for Infrastructure #3745
Comments
@colleenmcginnis FYI |
Thanks for opening this issue. Marking as blocked and adding to our backlog until we know those Docker metric definitions. |
Hey @bmorelli25, We've completed this issue now (barring a minor bug with the logs tab) but hopefully this is good to start documenting? I'd imagine you'll need some support untangling this. Here is a summary:
Containers in InventoryThere are no changes to the UI behaviour for 'Docker Containers' in Inventory except for clicking on one will open the new 'Container View' fly-out (see 2. Container Views below). Details
However, if you are looking at non-docker containers, the metrics will all show as '0%' or '-' because the docker fields don't exist: We do plan to move towards a single 'Container' entity type which works for any runtime (i.e. Docker and other runtimes) but we can't get there yet Containers ViewsWe have updated the container view to be similar to 'Hosts', i.e. there is a fly-out and an updated container view: Metrics Even when there are no docker metrics, the UI will adapt to show the correct metrics based on the runtime (this was the case in the old view too). At the moment, it will adapt to either docker metrics or Kubernetes metrics (e.g.
Alerts
Why aren't we just showing 'Containers' instead of 'Docker Containers'?We want to get there but we need to figure out a way to ensure there is a single 'Container' entity that we can show in the UI and create alerts on. We could change this today if we wanted but the problem is that the inventory 'Docker Container' entity type with the respective 'metrics' is shared between 'Inventory' and the 'Inventory Alerts': Inventory - 'Docker Containers' and their metrics Inventory Alerts - 'Docker Containers' and their metrics However, if we were to 'docker containers' to 'containers' and make changes to the default metrics, this would impact existing inventory rules users may have. So, instead, we're moving cautiously and we're figuring out how to have a single 'container' entity type with normalised metrics which work with any container type. |
cc @jennypavlova are you able to assist the docs team at all on this? I'm thinking mainly about field names/usage for the container views as it adapts to docker vs K8s containers. |
(if they reach out that is) |
Sure, please let me know if you have any questions, I am happy to help :) |
Hey @bmorelli25, Just wanted to check if this one will have some assigned? It's not urgent but basically making container views. |
Hey @roshan-elastic, I have this on our list, but it'll need to take a backseat to ECO and OTel right now. I don't have an estimated date or writer yet. |
No problem @bmorelli25 - not a priority. |
@roshan-elastic do we know what the metrics definitions are?
|
@roshan-elastic To add to Brandon's question, I have a request. Can you quickly update this issue to reflect the current state of this request. For example, I'm assuming that this statement is no longer true:
I also want to make sure we're targeting the correct release. Currently the issue indicates that we are likely targeting 8.15:
|
Hey @bmorelli25 @dedemorton,
Sure.
That's right. This change went out in 8.15.
Yes, we have them now. When a container is using Docker, it should be using these definitions: When a container is using ContainerD (i.e. Kubernetes) then it should be using these metrics: Kubernetes Container Metric Definitions
QuestionWould it make sense to repurpose the https://www.elastic.co/guide/en/observability/current/docker-container-metrics.html page into a more generic container page which as sections for Docker Metrics and Kubernetes Container Metrics? We have short links in the UI which I can remotely change which are pointing towards Kubernetes or Docker metrics in a page (so you can change the URL without breaking any links in the UI - I can change the short-links to point to anywhere): e.g. (where the https://ela.st/docs-infra-k8s-metrics#key-metrics-memory https://ela.st/docs-infra-docker-container-metrics#key-metrics-cpu What I'm thinking is that if we had a single 'container' page with sections for Docker and K8s that I could point towards then https://ela.st/docs-infra-k8s-metrics#key-metrics-memory could point towards More information for the futureTL;DR : We're going to normalise all container types in the future to use the same fields for metrics (e.g. The UI is pretty inconsistent with containers because we're conditionally changing the metric formulae in the container view based on the available metrics. For example, the fields used to show 'CPU' are different between Docker containers and K8s containers. At the same time, when you go to Inventory, it shows 'Docker Containers' in the drop-down but it will show all containers with a This is described in more detail in this epic where we're going to eventually normalise all containers as "Containers" (instead of having references to "Docker Containers" with specific docker metrics) and use the generic container fields like We'll make all of these changes so that there are just 'Containers' which use generic fields for metrics and then we'll probably leave the existing metrics (which are used in Inventory and Inventory alert rules) as |
@roshan-elastic Sure we can have a single page that contains sections for both docker and K8s metrics. |
Description
We're going to be updating our container template to (a) use the new template we are using for hosts (b) making 'docker containers' support all containers.
Initially, this means we need to:
Update the metrics definitions
Update the inventory docs to reflect these are 'containers' (not just 'docker containers')
Old view of containers
What it will start to look like (showing 'hosts' for now)
Notes:
Resources
Which documentation set does this change impact?
Stateful and Serverless
Feature differences
None
What release is this request related to?
TBC (likely 8.15)
Collaboration model
I'm happy to help!
Point of contact.
Main contact: @roshan-elastic + @jennypavlova + @MiriamAparicio
Stakeholders:
@smith
The text was updated successfully, but these errors were encountered: