Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Unable to dowload a 64 bit version for a Windows 64 bit machine #34

Open
ducky427 opened this issue Sep 6, 2015 · 1 comment
Open

Unable to dowload a 64 bit version for a Windows 64 bit machine #34

ducky427 opened this issue Sep 6, 2015 · 1 comment

Comments

@ducky427
Copy link
Contributor

ducky427 commented Sep 6, 2015

On L28, it is always assumed that a Windows machine is a 32 bit machine. Looking the electron shell releases, it seems that Windows releases are of the type win32-ia32 and win32-x64. So in getArch function, the latter case is never handled.
@ducky427
Copy link
Contributor Author

ducky427 commented Sep 6, 2015

I've got a commit here which should fix it. If you think its acceptable, I can create a PR.

Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ducky427