This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Support for downloading for a platform other than the host platform. #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay in responding! This looks good @entropi, I'm going to test it out next week and try to get it merged. |
|
Could you merge or rebase this with master. There was an |
| @@ -24,6 +24,8 @@ grunt.loadNpmTasks('grunt-download-atom-shell'); | |||
| * `symbols` - Download debugging symbols instead of binaries, default to `false`. | |||
| * `rebuild` - Whether to rebuild native modules after atom-shell is downloaded. | |||
| * `apm` - The path to apm. | |||
| * `platform` - What platform to download (`win32`, `darwin`, `linux`). default is the host platform. | |||
| * `addPlatformToOutputPath` - Whether to put the downloaded atom-shell in a platform specific directory within outputDir. (e.g., outputDir/darwin/) Defaults to `false` for backwards compatibility. | |||
There was a problem hiding this comment.
I think we can remove the addPlatformToOutputPath option and assume that it is false. It would still work with Atom because it sets atomShellDownloadDir = path.join(os.tmpdir(), 'atom-cached-atom-shells').
|
I'm going to close this PR. Please leave a comment or create another PR if you get a chance to fix the issues I mentioned. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #4 by allowing you to specify an alternate platform to download. For backwards compatibility it still places the downloaded shell in the main outputDir by default, but also adds an option to have it append the platform name to the path (e.g., binaries/darwin/) automatically.