Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Update the build and bootstrap commands #3

Open
15 tasks
benogle opened this issue Jul 28, 2015 · 0 comments
Open
15 tasks

Update the build and bootstrap commands #3

benogle opened this issue Jul 28, 2015 · 0 comments

Comments

@benogle
Copy link
Contributor

benogle commented Jul 28, 2015

The run command now has specs and is written in a reasonable way. The other two commands need to be updated to match.

Bootstrap command

  • Upgrade to latest electron-rebuild
  • Write specs
  • Handle errors (see the run command as an example)
  • Use the Utils.log methods (see the run command as an example)
  • Use async/await rather than the async lib
  • Pass all unused cli args through to the electron-rebuild binary

Build command

For all of these, see the run command as an example

  • Make a decision on defaults for
    • --platform
    • --arch
    • --overwrite
  • Write specs
  • Handle errors
  • Use the Utils.log methods
  • Use async/await rather than the async lib
  • Pass all unused cli args through to the electron-packager binary

cc @mnquintana

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant