Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Use extract-zip instead of decompress-zip #3

Closed
develar opened this issue Mar 1, 2016 · 6 comments
Closed

Use extract-zip instead of decompress-zip #3

develar opened this issue Mar 1, 2016 · 6 comments

Comments

@develar
Copy link
Contributor

develar commented Mar 1, 2016

What do you think? I can prepare pull request if you don't mind.

It is important for me since asar uses mksnapshot.

@lee-dohm
Copy link

lee-dohm commented Mar 1, 2016

Is there something broken in decompress-zip? Something it isn't doing that it should?

@develar
Copy link
Contributor Author

develar commented Mar 1, 2016

My concern is only mentioned bower/decompress-zip#53

electron-builder uses electron-packager,
electron-packager uses asar,
asar uses mksnapshot,
mksnapshot uses decompress-zip

decompress-zip maintainers don't publish new version and ignore PR bower/decompress-zip#53

As result, users of electron-packager/electron-builder get warning "graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible." (and increased number of node dependencies).

@ahgan84
Copy link

ahgan84 commented Mar 7, 2016

Yes. I encounter this problem also whereby I will get the warnning "graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible." (and increased number of node dependencies)"

When I type "npm run pack" I got an error saying:
C:\node_modules\electron-builder\out\build-cli.js:5
const builder_1 = require("./builder");
^^^^^
SyntaxError: Use of const in strict mode.
at exports.runInThisContext (vm.js:73:16)
at Module._compile (module.js:443:25)
at Object.Module._extensions..js (module.js:478:10)
at Module.load (module.js:355:32)
at Function.Module._load (module.js:310:12)
at Function.Module.runMain (module.js:501:10)
at startup (node.js:129:16)
at node.js:814:3
Does this error related to the graceful-fs not update?

@develar
Copy link
Contributor Author

develar commented Mar 7, 2016

@ahgan84 Your issue is different, please ensure that you use NodeJS version 4+.

@ppitonak
Copy link

ppitonak commented Apr 4, 2016

Since bower/decompress-zip#53 was merged, can you please upgrade to decompress-zip 0.3.0?

@kevinsawicki
Copy link
Contributor

Fixed by #4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants