-
Notifications
You must be signed in to change notification settings - Fork 8
Use extract-zip instead of decompress-zip #3
Comments
Is there something broken in decompress-zip? Something it isn't doing that it should? |
My concern is only mentioned bower/decompress-zip#53 electron-builder uses electron-packager, decompress-zip maintainers don't publish new version and ignore PR bower/decompress-zip#53 As result, users of electron-packager/electron-builder get warning "graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible." (and increased number of node dependencies). |
Yes. I encounter this problem also whereby I will get the warnning "graceful-fs version 3 and before will fail on newer node releases. Please update to graceful-fs@^4.0.0 as soon as possible." (and increased number of node dependencies)" When I type "npm run pack" I got an error saying: |
@ahgan84 Your issue is different, please ensure that you use NodeJS version 4+. |
Since bower/decompress-zip#53 was merged, can you please upgrade to decompress-zip 0.3.0? |
Fixed by #4 |
What do you think? I can prepare pull request if you don't mind.
It is important for me since asar uses mksnapshot.
The text was updated successfully, but these errors were encountered: