Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Patterns: How should I remove irrelevant prebuild files? #3895

Closed
christianbundy opened this issue May 15, 2019 · 3 comments
Closed

File Patterns: How should I remove irrelevant prebuild files? #3895

christianbundy opened this issue May 15, 2019 · 3 comments
Labels

Comments

@christianbundy
Copy link
Contributor

  • Version: 20.40.2
  • Target: Linux x64

I think we want to glob for !**/prebuilds/!(${platform}-${arch})/* so that we remove irrelevant prebuilds, but that's not including any prebuild files in AppImages. Which glob(s) should we be using?

$ tree node_modules node_modules/sodium-native/prebuilds
node_modules/sodium-native/prebuilds
├── darwin-x64
│   ├── electron-47.node
│   ├── electron-48.node
│   ├── electron-49.node
│   ├── electron-50.node
│   ├── electron-51.node
│   ├── electron-53.node
│   ├── electron-54.node
│   ├── electron-57.node
│   ├── electron-64.node
│   ├── electron-69.node
│   ├── libsodium.dylib
│   ├── node-47.node
│   ├── node-48.node
│   ├── node-51.node
│   ├── node-57.node
│   ├── node-59.node
│   ├── node-64.node
│   └── node-67.node
├── linux-arm
│   ├── electron-47.node
│   ├── electron-48.node
│   ├── electron-49.node
│   ├── electron-50.node
│   ├── electron-51.node
│   ├── electron-53.node
│   ├── electron-54.node
│   ├── electron-57.node
│   ├── electron-64.node
│   ├── electron-69.node
│   ├── libsodium.so.23
│   ├── node-47.node
│   ├── node-48.node
│   ├── node-51.node
│   ├── node-57.node
│   ├── node-59.node
│   ├── node-64.node
│   └── node-67.node
├── linux-x64
│   ├── electron-47.node
│   ├── electron-48.node
│   ├── electron-49.node
│   ├── electron-50.node
│   ├── electron-51.node
│   ├── electron-53.node
│   ├── electron-54.node
│   ├── electron-57.node
│   ├── electron-64.node
│   ├── electron-69.node
│   ├── libsodium.so.23
│   ├── node-47.node
│   ├── node-48.node
│   ├── node-51.node
│   ├── node-57.node
│   ├── node-59.node
│   ├── node-64.node
│   └── node-67.node
├── win32-ia32
│   ├── electron-47.node
│   ├── electron-48.node
│   ├── electron-49.node
│   ├── electron-50.node
│   ├── electron-51.node
│   ├── electron-53.node
│   ├── electron-54.node
│   ├── electron-57.node
│   ├── electron-64.node
│   ├── electron-69.node
│   ├── libsodium.dll
│   ├── node-47.node
│   ├── node-48.node
│   ├── node-51.node
│   ├── node-57.node
│   ├── node-59.node
│   ├── node-64.node
│   └── node-67.node
└── win32-x64
    ├── electron-47.node
    ├── electron-48.node
    ├── electron-49.node
    ├── electron-50.node
    ├── electron-51.node
    ├── electron-53.node
    ├── electron-54.node
    ├── electron-57.node
    ├── electron-64.node
    ├── electron-69.node
    ├── libsodium.dll
    ├── node-47.node
    ├── node-48.node
    ├── node-51.node
    ├── node-57.node
    ├── node-59.node
    ├── node-64.node
    └── node-67.node

Backlink: ssbc/patchbay#333

@mixmix
Copy link

mixmix commented May 20, 2019

I tried quite a few different globs e.g. more explicit things like:

{
  files: [
    '**/*',
    '!node_modules/sodium-native/prebuilds/*',
    'node_modules/sodium-native/prebuilds/${platform}-${arch}/*' 
  ] 
}

@stale
Copy link

stale bot commented Jul 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the backlog label Jul 19, 2019
@stale stale bot removed the backlog label Jul 24, 2019
@stale
Copy link

stale bot commented Sep 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the backlog label Sep 22, 2019
@stale stale bot closed this as completed Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants