Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error creating MSI #16

Closed
raybooysen opened this issue Sep 20, 2016 · 2 comments
Closed

Error creating MSI #16

raybooysen opened this issue Sep 20, 2016 · 2 comments

Comments

@raybooysen
Copy link

raybooysen commented Sep 20, 2016

Hi there

I've recently had an issue where the MSI has stopped being generated. Turns out it's the same issue as electron-archive#96. I've tested with a newer version of rcedit.exe and the problem goes away.

What are the thoughts on upgrading the files that are in vendor?

@raybooysen
Copy link
Author

Just checked out master, and run:

npm install
npm run ci

And I get similar errors.

@raybooysen
Copy link
Author

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant